Gated the negative available area bug code path#307
Open
scottpeterson wants to merge 2 commits into
Open
Conversation
dektar
approved these changes
May 6, 2026
| int[] loc = new int[2]; | ||
| binding.filter.getLocationOnScreen(loc); | ||
| popup.setHeight(vf.bottom - loc[1] - binding.filter.getHeight()); | ||
| int available = vf.bottom - loc[1] - binding.filter.getHeight(); |
Collaborator
There was a problem hiding this comment.
LG, although we could have a minimum height so it doesn't end up 1 pixel tall or something. I find it looks pretty short in landscape mode on the small screen.
Collaborator
Author
There was a problem hiding this comment.
good call, just pushed a commit with a solution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing Issue #306
What type of PR is this? (check all applicable)
Description
Related Issues
Were the changes tested?
have not been included