chore: avoid hammering store at ntx builder startup#2064
Open
SantiagoPittella wants to merge 4 commits intomainfrom
Open
chore: avoid hammering store at ntx builder startup#2064SantiagoPittella wants to merge 4 commits intomainfrom
SantiagoPittella wants to merge 4 commits intomainfrom
Conversation
sergerad
reviewed
May 11, 2026
sergerad
reviewed
May 11, 2026
sergerad
reviewed
May 11, 2026
sergerad
reviewed
May 11, 2026
sergerad
reviewed
May 11, 2026
| /// Bounds the burst of `GetNetworkAccountDetailsById` and `GetUnconsumedNetworkNotes` calls the | ||
| /// ntx-builder fires when catching up after a restart. | ||
| const DEFAULT_STORE_HYDRATION_CONCURRENCY: NonZeroUsize = | ||
| NonZeroUsize::new(4).expect("literal is non-zero"); |
Collaborator
There was a problem hiding this comment.
Do we know how slow things could be because of this?
Collaborator
Author
There was a problem hiding this comment.
Not really, because my local DB isn't big enough to actually measure this. It would be really nice to have a copy of the DB in a server with similar specs to the devnet/testnet ones to compare it. Or at least running it locally with the testnet database.
Do you know if I can get access to it? maybe @Mirko-von-Leipzig ?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1952
This PR:
unconsumed_notesdelta per known account, dropping the per-accountGetNetworkAccountDetailsByIdcall.StoreClient(defaulted to 4) that bounds concurrent in-flight startup RPCs.store_sync_checkpointcolumn on chain_state (required a new SQL migration), distinct from the mempool-driven block_num.I tried it by:
mainversion of the node.