Sean/fea urchin by auroter · Pull Request #112 · 0xIntuition/intuition-beta-contracts

auroter · 2025-02-12T03:32:08Z

FeaUrchin Contract Implementation

Overview

This PR introduces the FeaUrchin contract, a fee-taking wrapper around the EthMultiVault that adds a configurable fee structure for all vault operations. The implementation includes support for both standard and bonding curve operations, and provides an interface which is forward compatible by abstracting out "curve" functions, as well as term abstraction for atoms/triples. The purpose of this is for app developers to be able to charge fees, for coffee, or to fund their back-end wallets. There is a new template project in the monorepo which will certainly use this.

Key Changes

New Contract: FeaUrchin

Implements a fee-taking wrapper around EthMultiVault operations
Configurable fee structure with numerator/denominator pattern
Tracks unique users, total assets moved, and fees collected
Supports both single and batch operations
Handles both standard and bonding curve operations

Interface Updates

Added bonding curve support to IEthMultiVault interface (This was missing)
New methods for curve-based deposits and redemptions for both atoms and triples
Added NATSPEC documentation for all new methods

Test Coverage

Comprehensive test suite in FeaUrchin.t.sol
Tests for initialization, fee configuration, atom/triple creation
Batch operation testing
Fee collection and withdrawal testing

Implementation Details

Fee Handling

Fees are calculated using the formula: fee = amount * feeNumerator / feeDenominator
Default configuration: 1% fee (100/10000)
Fees are collected in ETH and can be withdrawn by the admin

Asset Tracking

totalAssetsMoved: Total value of assets that have moved through the contract
totalAssetsStaked: Current total value of assets staked
totalFeesCollected: Total fees collected by the contract
uniqueUsersCount: Number of unique users interacting with the contract

Batch Operations

Support for batch creation of atoms and triples
Batch deposits and redemptions with curve specification
Efficient fee handling for batch operations

Testing

All core functionality has been tested, including:

Contract initialization
Fee calculations and collection
Asset tracking
User tracking
Batch operations
Integration with bonding curves

Security Considerations

Owner-only access for fee configuration and withdrawal
Safe ETH transfer handling
Maintains emergency redemption capabilities from EthMultiVault
Preserves all existing security checks from the base contract

Commits

Basic implementation
Fix everything, add term abstraction, curve abstraction, batch actions
Remove unused events
Add atomCost and tripleCost overrides to account for fees, fix redeem pass-through

Note:

WE DO NOT WANT TO MERGE THIS YET BECAUSE THE MAIN BRANCH IS BEING AUDITED. This PR is for educational purposes, for now.

… issue where redeem was not passing through the urchin.

github-actions · 2025-02-12T03:37:44Z

Summary of Test Results if Merged To Main:

Full logs & artifacts are available in the Actions tab
This comment will update automatically with new CI runs

✅ All 115 tests passed! (0 skipped, Total: 115)

Test Results for Merge

Test Suite	Status	Coverage	Time
`test/unit/EthMultiVault/RedeemAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/EthMultiVault/RedeemAtomCurve.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/AdminMultiVault.t.sol`	✅	100% (16/16)	0.008s
`test/unit/EthMultiVault/Approvals.t.sol`	✅	100% (2/2)	0.004s
`test/unit/EthMultiVault/RedeemTriple.t.sol`	✅	100% (5/5)	0.008s
`test/unit/EthMultiVault/RedeemTripleCurve.t.sol`	✅	100% (5/5)	0.017s
`test/unit/EthMultiVault/CreateTriple.t.sol`	✅	100% (6/6)	0.006s
`test/BaseTest.sol`	✅	100% (2/2)	0.012s
`test/unit/EthMultiVault/DepositAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/EthMultiVault/BatchCreateAtom.t.sol`	✅	100% (2/2)	0.004s
`test/unit/EthMultiVault/DepositAtomCurve.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/DepositTriple.t.sol`	✅	100% (4/4)	0.007s
`test/unit/EthMultiVault/BatchCreateTriple.t.sol`	✅	100% (4/4)	0.014s
`test/unit/EthMultiVault/CreateAtom.t.sol`	✅	100% (6/6)	0.003s
`test/unit/EthMultiVault/DepositTripleCurve.t.sol`	✅	100% (4/4)	0.014s
`test/unit/EthMultiVault/EmergencyRedeemTriple.t.sol`	✅	100% (5/5)	0.008s
`test/unit/EthMultiVault/EmergencyReedemAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/EthMultiVault/Helpers.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/UseCases.t.sol`	✅	100% (6/6)	0.060s
`test/unit/EthMultiVault/Profit.t.sol`	✅	100% (11/11)	0.031s
`test/unit/FeaUrchin.t.sol`	✅	100% (8/8)	0.009s

🔒 Security Analysis

⚠️ Found 1 High and 2 Medium severity issues

High Severity Issues

arbitrary-send-eth

Impact: AtomWallet._call(address,uint256,bytes) (src/AtomWallet.sol#214-221) sends eth to arbitrary user Dangerous calls: - (success,result) = target.call{value: value}(data) (src/AtomWallet.sol#215)

Affected Files:

src/AtomWallet.sol

View Detailed Findings

src/AtomWallet.sol:214 in _call

Medium Severity Issues

View Medium Severity Issues

##### incorrect-equality **Impact**: EthMultiVault._validateTimelock(bytes32) (src/EthMultiVault.sol#2214-2226) uses a dangerous strict equality: - timelock.readyTime == 0 (src/EthMultiVault.sol#2217)

Affected Files:

src/EthMultiVault.sol
src/EthMultiVault.sol:2214 in _validateTimelock

reentrancy-no-eth

Impact: Reentrancy in FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#219-241): External calls: - assets[i] = _redeem(shares[i],ids[i],curveIds[i]) (src/FeaUrchin.sol#232) - assets = ethMultiVault.redeemTriple(shares,address(this),id) (src/FeaUrchin.sol#145-147) - assets = ethMultiVault.redeemAtom(shares,address(this),id) (src/FeaUrchin.sol#145-147) - assets = ethMultiVault.redeemTripleCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#149-151) - assets = ethMultiVault.redeemAtomCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#149-151) State variables written after the call(s): - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#233) - totalAssetsMoved += assets (src/FeaUrchin.sol#76) FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#24) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#66-72) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#74-80) - FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#24) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#233) - totalAssetsStaked -= assets (src/FeaUrchin.sol#77) FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#25) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#66-72) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#74-80) - FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#25) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#233) - totalFeesCollected += fee (src/FeaUrchin.sol#78) FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#26) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#66-72) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#74-80) - FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#26)

Affected Files:

src/FeaUrchin.sol
src/FeaUrchin.sol:219 in batchRedeem

Recommended Actions

Review and fix all high severity issues before deployment
Implement thorough testing for affected components
Consider additional security measures:
- Access controls
- Input validation
- Invariant checks

⛽ Gas Analysis

📊 First gas snapshot created

github-actions · 2025-02-12T22:12:47Z

Summary of Test Results if Merged To Main:

Full logs & artifacts are available in the Actions tab
This comment will update automatically with new CI runs

✅ All 117 tests passed! (0 skipped, Total: 117)

Test Results for Merge

Test Suite	Status	Coverage	Time
`test/unit/EthMultiVault/RedeemAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/EthMultiVault/AdminMultiVault.t.sol`	✅	100% (16/16)	0.006s
`test/unit/EthMultiVault/RedeemAtomCurve.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/Approvals.t.sol`	✅	100% (2/2)	0.004s
`test/unit/EthMultiVault/RedeemTriple.t.sol`	✅	100% (5/5)	0.009s
`test/BaseTest.sol`	✅	100% (2/2)	0.011s
`test/unit/EthMultiVault/RedeemTripleCurve.t.sol`	✅	100% (5/5)	0.011s
`test/unit/EthMultiVault/BatchCreateAtom.t.sol`	✅	100% (2/2)	0.008s
`test/unit/EthMultiVault/BatchCreateTriple.t.sol`	✅	100% (4/4)	0.010s
`test/unit/EthMultiVault/CreateAtom.t.sol`	✅	100% (6/6)	0.007s
`test/unit/EthMultiVault/CreateTriple.t.sol`	✅	100% (6/6)	0.008s
`test/unit/EthMultiVault/DepositAtom.t.sol`	✅	100% (4/4)	0.006s
`test/unit/EthMultiVault/Helpers.t.sol`	✅	100% (4/4)	0.005s
`test/unit/EthMultiVault/DepositAtomCurve.t.sol`	✅	100% (4/4)	0.009s
`test/unit/EthMultiVault/UseCases.t.sol`	✅	100% (6/6)	0.045s
`test/unit/EthMultiVault/DepositTriple.t.sol`	✅	100% (4/4)	0.011s
`test/unit/EthMultiVault/Profit.t.sol`	✅	100% (11/11)	0.029s
`test/unit/EthMultiVault/DepositTripleCurve.t.sol`	✅	100% (4/4)	0.010s
`test/unit/FeaUrchin.t.sol`	✅	100% (8/8)	0.007s
`test/unit/EthMultiVault/EmergencyReedemAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/EthMultiVault/EmergencyRedeemTriple.t.sol`	✅	100% (5/5)	0.008s

🔒 Security Analysis

⚠️ Found 1 High and 2 Medium severity issues

High Severity Issues

arbitrary-send-eth

Impact: AtomWallet._call(address,uint256,bytes) (src/AtomWallet.sol#214-221) sends eth to arbitrary user Dangerous calls: - (success,result) = target.call{value: value}(data) (src/AtomWallet.sol#215)

Affected Files:

src/AtomWallet.sol

View Detailed Findings

src/AtomWallet.sol:214 in _call

Medium Severity Issues

View Medium Severity Issues

##### incorrect-equality **Impact**: EthMultiVault._validateTimelock(bytes32) (src/EthMultiVault.sol#2214-2226) uses a dangerous strict equality: - timelock.readyTime == 0 (src/EthMultiVault.sol#2217)

Affected Files:

src/EthMultiVault.sol
src/EthMultiVault.sol:2214 in _validateTimelock

reentrancy-no-eth

Impact: Reentrancy in FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#219-241): External calls: - assets[i] = _redeem(shares[i],ids[i],curveIds[i]) (src/FeaUrchin.sol#232) - assets = ethMultiVault.redeemTriple(shares,address(this),id) (src/FeaUrchin.sol#145-147) - assets = ethMultiVault.redeemAtom(shares,address(this),id) (src/FeaUrchin.sol#145-147) - assets = ethMultiVault.redeemTripleCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#149-151) - assets = ethMultiVault.redeemAtomCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#149-151) State variables written after the call(s): - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#233) - totalAssetsMoved += assets (src/FeaUrchin.sol#76) FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#24) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#66-72) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#74-80) - FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#24) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#233) - totalAssetsStaked -= assets (src/FeaUrchin.sol#77) FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#25) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#66-72) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#74-80) - FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#25) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#233) - totalFeesCollected += fee (src/FeaUrchin.sol#78) FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#26) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#66-72) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#74-80) - FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#26)

Affected Files:

src/FeaUrchin.sol
src/FeaUrchin.sol:219 in batchRedeem

Recommended Actions

Review and fix all high severity issues before deployment
Implement thorough testing for affected components
Consider additional security measures:
- Access controls
- Input validation
- Invariant checks

⛽ Gas Analysis

⚠️ No gas snapshot generated

github-actions · 2025-02-12T22:18:09Z

Summary of Test Results if Merged To Main:

Full logs & artifacts are available in the Actions tab
This comment will update automatically with new CI runs

✅ All 117 tests passed! (0 skipped, Total: 117)

Test Results for Merge

Test Suite	Status	Coverage	Time
`test/unit/EthMultiVault/RedeemAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/EthMultiVault/RedeemAtomCurve.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/AdminMultiVault.t.sol`	✅	100% (16/16)	0.011s
`test/unit/EthMultiVault/Approvals.t.sol`	✅	100% (2/2)	0.001s
`test/unit/EthMultiVault/CreateTriple.t.sol`	✅	100% (6/6)	0.014s
`test/unit/EthMultiVault/RedeemTriple.t.sol`	✅	100% (5/5)	0.008s
`test/unit/EthMultiVault/DepositAtom.t.sol`	✅	100% (4/4)	0.010s
`test/BaseTest.sol`	✅	100% (2/2)	0.016s
`test/unit/EthMultiVault/RedeemTripleCurve.t.sol`	✅	100% (5/5)	0.014s
`test/unit/EthMultiVault/BatchCreateAtom.t.sol`	✅	100% (2/2)	0.008s
`test/unit/EthMultiVault/DepositAtomCurve.t.sol`	✅	100% (4/4)	0.014s
`test/unit/EthMultiVault/DepositTriple.t.sol`	✅	100% (4/4)	0.007s
`test/unit/EthMultiVault/BatchCreateTriple.t.sol`	✅	100% (4/4)	0.016s
`test/unit/EthMultiVault/CreateAtom.t.sol`	✅	100% (6/6)	0.003s
`test/unit/EthMultiVault/DepositTripleCurve.t.sol`	✅	100% (4/4)	0.012s
`test/unit/EthMultiVault/EmergencyReedemAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/FeaUrchinFactory.t.sol`	✅	100% (2/2)	0.001s
`test/unit/EthMultiVault/EmergencyRedeemTriple.t.sol`	✅	100% (5/5)	0.015s
`test/unit/FeaUrchin.t.sol`	✅	100% (8/8)	0.007s
`test/unit/EthMultiVault/Helpers.t.sol`	✅	100% (4/4)	0.005s
`test/unit/EthMultiVault/Profit.t.sol`	✅	100% (11/11)	0.025s
`test/unit/EthMultiVault/UseCases.t.sol`	✅	100% (6/6)	0.084s

🔒 Security Analysis

⚠️ Found 1 High and 2 Medium severity issues

High Severity Issues

arbitrary-send-eth

Impact: AtomWallet._call(address,uint256,bytes) (src/AtomWallet.sol#214-221) sends eth to arbitrary user Dangerous calls: - (success,result) = target.call{value: value}(data) (src/AtomWallet.sol#215)

Affected Files:

src/AtomWallet.sol

View Detailed Findings

src/AtomWallet.sol:214 in _call

Medium Severity Issues

View Medium Severity Issues

##### incorrect-equality **Impact**: EthMultiVault._validateTimelock(bytes32) (src/EthMultiVault.sol#2214-2226) uses a dangerous strict equality: - timelock.readyTime == 0 (src/EthMultiVault.sol#2217)

Affected Files:

src/EthMultiVault.sol
src/EthMultiVault.sol:2214 in _validateTimelock

reentrancy-no-eth

Impact: Reentrancy in FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#367-389): External calls: - assets[i] = _redeem(shares[i],ids[i],curveIds[i]) (src/FeaUrchin.sol#380) - assets = ethMultiVault.redeemTriple(shares,address(this),id) (src/FeaUrchin.sol#267-269) - assets = ethMultiVault.redeemAtom(shares,address(this),id) (src/FeaUrchin.sol#267-269) - assets = ethMultiVault.redeemTripleCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#271-273) - assets = ethMultiVault.redeemAtomCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#271-273) State variables written after the call(s): - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#381) - totalAssetsMoved += assets (src/FeaUrchin.sol#165) FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#84) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#151-157) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#163-169) - FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#84) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#381) - totalAssetsStaked -= assets (src/FeaUrchin.sol#166) FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#86) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#151-157) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#163-169) - FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#86) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#381) - totalFeesCollected += fee (src/FeaUrchin.sol#167) FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#88) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#151-157) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#163-169) - FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#88)

Affected Files:

src/FeaUrchin.sol
src/FeaUrchin.sol:367 in batchRedeem

Recommended Actions

Review and fix all high severity issues before deployment
Implement thorough testing for affected components
Consider additional security measures:
- Access controls
- Input validation
- Invariant checks

⛽ Gas Analysis

📊 First gas snapshot created

github-actions · 2025-02-14T21:45:15Z

Summary of Test Results if Merged To Main:

Full logs & artifacts are available in the Actions tab
This comment will update automatically with new CI runs

✅ All 120 tests passed! (0 skipped, Total: 120)

Test Results for Merge

Test Suite	Status	Coverage	Time
`test/unit/EthMultiVault/DepositAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/EthMultiVault/BatchCreateAtom.t.sol`	✅	100% (2/2)	0.002s
`test/unit/EthMultiVault/DepositAtomCurve.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/AdminMultiVault.t.sol`	✅	100% (16/16)	0.009s
`test/unit/EthMultiVault/Approvals.t.sol`	✅	100% (2/2)	0.001s
`test/unit/EthMultiVault/DepositTriple.t.sol`	✅	100% (4/4)	0.006s
`test/unit/EthMultiVault/DepositTripleCurve.t.sol`	✅	100% (4/4)	0.007s
`test/BaseTest.sol`	✅	100% (2/2)	0.010s
`test/unit/EthMultiVault/EmergencyReedemAtom.t.sol`	✅	100% (4/4)	0.006s
`test/unit/EthMultiVault/EmergencyRedeemTriple.t.sol`	✅	100% (5/5)	0.008s
`test/unit/EthMultiVault/BatchCreateTriple.t.sol`	✅	100% (4/4)	0.024s
`test/unit/EthMultiVault/CreateAtom.t.sol`	✅	100% (6/6)	0.003s
`test/unit/EthMultiVault/RedeemAtomCurve.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/RedeemTriple.t.sol`	✅	100% (5/5)	0.008s
`test/unit/EthMultiVault/CreateTriple.t.sol`	✅	100% (6/6)	0.016s
`test/unit/EthMultiVault/RedeemTripleCurve.t.sol`	✅	100% (5/5)	0.009s
`test/unit/UD60x18.t.sol`	✅	100% (1/1)	0.001s
`test/unit/EthMultiVault/UseCases.t.sol`	✅	100% (6/6)	0.042s
`test/unit/EthMultiVault/Helpers.t.sol`	✅	100% (4/4)	0.007s
`test/unit/FeaUrchin.t.sol`	✅	100% (8/8)	0.009s
`test/unit/EthMultiVault/RedeemAtom.t.sol`	✅	100% (4/4)	0.006s
`test/unit/EthMultiVault/Profit.t.sol`	✅	100% (11/11)	0.028s

🔒 Security Analysis

⚠️ Found 2 High and 5 Medium severity issues

High Severity Issues

arbitrary-send-eth

Impact: AtomWallet._call(address,uint256,bytes) (src/AtomWallet.sol#214-221) sends eth to arbitrary user Dangerous calls: - (success,result) = target.call{value: value}(data) (src/AtomWallet.sol#215)

Affected Files:

src/AtomWallet.sol

View Detailed Findings

src/AtomWallet.sol:214 in _call

reentrancy-eth

Impact: Reentrancy in FeaUrchin.batchDeposit(address,uint256[],uint256[]) (src/FeaUrchin.sol#374-393): External calls: - shares[i] = _deposit(valuePerItem,receiver,ids[i],curveIds[i]) (src/FeaUrchin.sol#387) - shares = ethMultiVault.depositTriple{value: value}(receiver,id) (src/FeaUrchin.sol#245-247) - shares = ethMultiVault.depositAtom{value: value}(receiver,id) (src/FeaUrchin.sol#245-247) - shares = ethMultiVault.depositTripleCurve{value: value}(receiver,id,curveId) (src/FeaUrchin.sol#249-251) - shares = ethMultiVault.depositAtomCurve{value: value}(receiver,id,curveId) (src/FeaUrchin.sol#249-251) State variables written after the call(s): - userShares[receiver][ids[i]][curveIds[i]] += shares[i] (src/FeaUrchin.sol#388) FeaUrchin.userShares (src/FeaUrchin.sol#46) can be used in cross function reentrancies: - FeaUrchin.batchCreateAtom(bytes[]) (src/FeaUrchin.sol#340-348) - FeaUrchin.batchCreateTriple(uint256[],uint256[],uint256[]) (src/FeaUrchin.sol#355-367) - FeaUrchin.batchDeposit(address,uint256[],uint256[]) (src/FeaUrchin.sol#374-393) - FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#401-424) - FeaUrchin.createAtom(bytes) (src/FeaUrchin.sol#193-199) - FeaUrchin.createTriple(uint256,uint256,uint256) (src/FeaUrchin.sol#206-217) - FeaUrchin.deposit(address,uint256,uint256) (src/FeaUrchin.sol#224-235) - FeaUrchin.getVaultShares(address,uint256,uint256) (src/FeaUrchin.sol#148-150) - FeaUrchin.redeem(uint256,address,uint256,uint256) (src/FeaUrchin.sol#270-285)

Affected Files:

src/FeaUrchin.sol

View Detailed Findings

src/FeaUrchin.sol:374 in batchDeposit

Medium Severity Issues

View Medium Severity Issues

##### incorrect-equality **Impact**: EthMultiVault._validateTimelock(bytes32) (src/EthMultiVault.sol#2219-2231) uses a dangerous strict equality: - timelock.readyTime == 0 (src/EthMultiVault.sol#2222)

Affected Files:

src/EthMultiVault.sol
src/EthMultiVault.sol:2219 in _validateTimelock

reentrancy-no-eth

Impact: Reentrancy in FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#401-424): External calls: - assets[i] = _redeem(shares[i],ids[i],curveIds[i]) (src/FeaUrchin.sol#414) - assets = ethMultiVault.redeemTriple(shares,address(this),id) (src/FeaUrchin.sol#294-296) - assets = ethMultiVault.redeemAtom(shares,address(this),id) (src/FeaUrchin.sol#294-296) - assets = ethMultiVault.redeemTripleCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#298-300) - assets = ethMultiVault.redeemAtomCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#298-300) State variables written after the call(s): - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#416) - totalAssetsMoved += assets (src/FeaUrchin.sol#184) FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#35) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#170-176) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#182-188) - FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#35) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#416) - totalAssetsStaked -= assets (src/FeaUrchin.sol#185) FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#37) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#170-176) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#182-188) - FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#37) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#416) - totalFeesCollected += fee (src/FeaUrchin.sol#186) FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#39) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#170-176) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#182-188) - FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#39) - userShares[receiver][ids[i]][curveIds[i]] -= shares[i] (src/FeaUrchin.sol#415) FeaUrchin.userShares (src/FeaUrchin.sol#46) can be used in cross function reentrancies: - FeaUrchin.batchCreateAtom(bytes[]) (src/FeaUrchin.sol#340-348) - FeaUrchin.batchCreateTriple(uint256[],uint256[],uint256[]) (src/FeaUrchin.sol#355-367) - FeaUrchin.batchDeposit(address,uint256[],uint256[]) (src/FeaUrchin.sol#374-393) - FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#401-424) - FeaUrchin.createAtom(bytes) (src/FeaUrchin.sol#193-199) - FeaUrchin.createTriple(uint256,uint256,uint256) (src/FeaUrchin.sol#206-217) - FeaUrchin.deposit(address,uint256,uint256) (src/FeaUrchin.sol#224-235) - FeaUrchin.getVaultShares(address,uint256,uint256) (src/FeaUrchin.sol#148-150) - FeaUrchin.redeem(uint256,address,uint256,uint256) (src/FeaUrchin.sol#270-285)

Affected Files:

src/FeaUrchin.sol
src/FeaUrchin.sol:401 in batchRedeem
src/FeaUrchin.sol:270 in redeem

unused-return

Impact: FeaUrchin._getVaultShares(address,uint256,uint256) (src/FeaUrchin.sol#140-146) ignores return value by (shares,None) = ethMultiVault.getVaultStateForUserCurve(termId,bondingCurveId,user) (src/FeaUrchin.sol#144)

Affected Files:

src/FeaUrchin.sol
src/FeaUrchin.sol:140 in _getVaultShares
src/FeaUrchin.sol:140 in _getVaultShares

Recommended Actions

Review and fix all high severity issues before deployment
Implement thorough testing for affected components
Consider additional security measures:
- Access controls
- Input validation
- Invariant checks

⛽ Gas Analysis

📊 First gas snapshot created

github-actions · 2025-02-28T23:44:07Z

Summary of Test Results if Merged To Main:

Full logs & artifacts are available in the Actions tab
This comment will update automatically with new CI runs

✅ All 124 tests passed! (0 skipped, Total: 124)

Test Results for Merge

Test Suite	Status	Coverage	Time
`test/unit/EthMultiVault/DepositAtom.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/DepositAtomCurve.t.sol`	✅	100% (4/4)	0.004s
`test/unit/EthMultiVault/AdminMultiVault.t.sol`	✅	100% (16/16)	0.011s
`test/unit/EthMultiVault/RedeemAtomCurve.t.sol`	✅	100% (4/4)	0.008s
`test/unit/EthMultiVault/DepositTriple.t.sol`	✅	100% (4/4)	0.006s
`test/unit/EthMultiVault/Approvals.t.sol`	✅	100% (2/2)	0.005s
`test/unit/EthMultiVault/DepositTripleCurve.t.sol`	✅	100% (4/4)	0.006s
`test/unit/EthMultiVault/EmergencyRedeemTriple.t.sol`	✅	100% (5/5)	0.011s
`test/BaseTest.sol`	✅	100% (2/2)	0.017s
`test/unit/EthMultiVault/EmergencyReedemAtom.t.sol`	✅	100% (4/4)	0.003s
`test/unit/EthMultiVault/RedeemTriple.t.sol`	✅	100% (5/5)	0.030s
`test/unit/EthMultiVault/BatchCreateAtom.t.sol`	✅	100% (2/2)	0.008s
`test/unit/EthMultiVault/BatchCreateTriple.t.sol`	✅	100% (4/4)	0.015s
`test/unit/EthMultiVault/RedeemTripleCurve.t.sol`	✅	100% (5/5)	0.013s
`test/unit/EthMultiVault/CreateAtom.t.sol`	✅	100% (6/6)	0.003s
`test/unit/EthMultiVault/CreateTriple.t.sol`	✅	100% (6/6)	0.007s
`test/unit/EthMultiVault/UseCases.t.sol`	✅	100% (6/6)	0.060s
`test/unit/EthMultiVault/Profit.t.sol`	✅	100% (11/11)	0.023s
`test/unit/EthMultiVault/RedeemAtom.t.sol`	✅	100% (4/4)	0.005s
`test/unit/EthMultiVault/Helpers.t.sol`	✅	100% (4/4)	0.007s
`test/unit/EthMultiVault/Fees.t.sol`	✅	100% (2/2)	0.312s
`test/unit/FeaUrchin.t.sol`	✅	100% (8/8)	0.009s
`test/unit/FeaUrchinFactory.t.sol`	✅	100% (2/2)	0.001s

🔒 Security Analysis

⚠️ Found 2 High and 5 Medium severity issues

High Severity Issues

arbitrary-send-eth

Impact: AtomWallet._call(address,uint256,bytes) (src/AtomWallet.sol#214-221) sends eth to arbitrary user Dangerous calls: - (success,result) = target.call{value: value}(data) (src/AtomWallet.sol#215)

Affected Files:

src/AtomWallet.sol

View Detailed Findings

src/AtomWallet.sol:214 in _call

reentrancy-eth

Impact: Reentrancy in FeaUrchin.batchDeposit(address,uint256[],uint256[]) (src/FeaUrchin.sol#374-393): External calls: - shares[i] = _deposit(valuePerItem,receiver,ids[i],curveIds[i]) (src/FeaUrchin.sol#387) - shares = ethMultiVault.depositTriple{value: value}(receiver,id) (src/FeaUrchin.sol#245-247) - shares = ethMultiVault.depositAtom{value: value}(receiver,id) (src/FeaUrchin.sol#245-247) - shares = ethMultiVault.depositTripleCurve{value: value}(receiver,id,curveId) (src/FeaUrchin.sol#249-251) - shares = ethMultiVault.depositAtomCurve{value: value}(receiver,id,curveId) (src/FeaUrchin.sol#249-251) State variables written after the call(s): - userShares[receiver][ids[i]][curveIds[i]] += shares[i] (src/FeaUrchin.sol#388) FeaUrchin.userShares (src/FeaUrchin.sol#46) can be used in cross function reentrancies: - FeaUrchin.batchCreateAtom(bytes[]) (src/FeaUrchin.sol#340-348) - FeaUrchin.batchCreateTriple(uint256[],uint256[],uint256[]) (src/FeaUrchin.sol#355-367) - FeaUrchin.batchDeposit(address,uint256[],uint256[]) (src/FeaUrchin.sol#374-393) - FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#401-424) - FeaUrchin.createAtom(bytes) (src/FeaUrchin.sol#193-199) - FeaUrchin.createTriple(uint256,uint256,uint256) (src/FeaUrchin.sol#206-217) - FeaUrchin.deposit(address,uint256,uint256) (src/FeaUrchin.sol#224-235) - FeaUrchin.getVaultShares(address,uint256,uint256) (src/FeaUrchin.sol#148-150) - FeaUrchin.redeem(uint256,address,uint256,uint256) (src/FeaUrchin.sol#270-285)

Affected Files:

src/FeaUrchin.sol

View Detailed Findings

src/FeaUrchin.sol:374 in batchDeposit

Medium Severity Issues

View Medium Severity Issues

##### incorrect-equality **Impact**: EthMultiVault._validateTimelock(bytes32) (src/EthMultiVault.sol#2187-2199) uses a dangerous strict equality: - timelock.readyTime == 0 (src/EthMultiVault.sol#2190)

Affected Files:

src/EthMultiVault.sol
src/EthMultiVault.sol:2187 in _validateTimelock

reentrancy-no-eth

Impact: Reentrancy in FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#401-424): External calls: - assets[i] = _redeem(shares[i],ids[i],curveIds[i]) (src/FeaUrchin.sol#414) - assets = ethMultiVault.redeemTriple(shares,address(this),id) (src/FeaUrchin.sol#294-296) - assets = ethMultiVault.redeemAtom(shares,address(this),id) (src/FeaUrchin.sol#294-296) - assets = ethMultiVault.redeemTripleCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#298-300) - assets = ethMultiVault.redeemAtomCurve(shares,address(this),id,curveId) (src/FeaUrchin.sol#298-300) State variables written after the call(s): - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#416) - totalAssetsMoved += assets (src/FeaUrchin.sol#184) FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#35) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#170-176) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#182-188) - FeaUrchin.totalAssetsMoved (src/FeaUrchin.sol#35) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#416) - totalAssetsStaked -= assets (src/FeaUrchin.sol#185) FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#37) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#170-176) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#182-188) - FeaUrchin.totalAssetsStaked (src/FeaUrchin.sol#37) - (fee,netValue) = _processRedeem(assets[i]) (src/FeaUrchin.sol#416) - totalFeesCollected += fee (src/FeaUrchin.sol#186) FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#39) can be used in cross function reentrancies: - FeaUrchin._processDeposit(uint256) (src/FeaUrchin.sol#170-176) - FeaUrchin._processRedeem(uint256) (src/FeaUrchin.sol#182-188) - FeaUrchin.totalFeesCollected (src/FeaUrchin.sol#39) - userShares[receiver][ids[i]][curveIds[i]] -= shares[i] (src/FeaUrchin.sol#415) FeaUrchin.userShares (src/FeaUrchin.sol#46) can be used in cross function reentrancies: - FeaUrchin.batchCreateAtom(bytes[]) (src/FeaUrchin.sol#340-348) - FeaUrchin.batchCreateTriple(uint256[],uint256[],uint256[]) (src/FeaUrchin.sol#355-367) - FeaUrchin.batchDeposit(address,uint256[],uint256[]) (src/FeaUrchin.sol#374-393) - FeaUrchin.batchRedeem(uint256[],address,uint256[],uint256[]) (src/FeaUrchin.sol#401-424) - FeaUrchin.createAtom(bytes) (src/FeaUrchin.sol#193-199) - FeaUrchin.createTriple(uint256,uint256,uint256) (src/FeaUrchin.sol#206-217) - FeaUrchin.deposit(address,uint256,uint256) (src/FeaUrchin.sol#224-235) - FeaUrchin.getVaultShares(address,uint256,uint256) (src/FeaUrchin.sol#148-150) - FeaUrchin.redeem(uint256,address,uint256,uint256) (src/FeaUrchin.sol#270-285)

Affected Files:

src/FeaUrchin.sol
src/FeaUrchin.sol:401 in batchRedeem
src/FeaUrchin.sol:270 in redeem

unused-return

Impact: FeaUrchin._getVaultShares(address,uint256,uint256) (src/FeaUrchin.sol#140-146) ignores return value by (shares,None) = ethMultiVault.getVaultStateForUserCurve(termId,bondingCurveId,user) (src/FeaUrchin.sol#144)

Affected Files:

src/FeaUrchin.sol
src/FeaUrchin.sol:140 in _getVaultShares
src/FeaUrchin.sol:140 in _getVaultShares

Recommended Actions

Review and fix all high severity issues before deployment
Implement thorough testing for affected components
Consider additional security measures:
- Access controls
- Input validation
- Invariant checks

⛽ Gas Analysis

📊 First gas snapshot created

auroter added 4 commits February 11, 2025 12:22

basic implementation

76bb59c

fix everything, add term abstraction, curve abstraction, batch actions

cff11dc

remove unused events

662c8b3

Added atomCost and tripleCost overrides to account for fees. Fixed an…

10d5ab2

… issue where redeem was not passing through the urchin.

auroter requested review from mcclurejt and mihailo-maksa February 12, 2025 03:32

auroter added 2 commits February 12, 2025 15:08

factory

84cd416

NATSPEC

491e960

stashing

36abe4c

Merge branch 'main' into sean/FeaUrchin

43a4c10

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sean/fea urchin#112

Sean/fea urchin#112
auroter wants to merge 8 commits intomainfrom
sean/FeaUrchin

auroter commented Feb 12, 2025

Uh oh!

github-actions Bot commented Feb 12, 2025

reentrancy-no-eth

Uh oh!

github-actions Bot commented Feb 12, 2025

reentrancy-no-eth

Uh oh!

github-actions Bot commented Feb 12, 2025

reentrancy-no-eth

Uh oh!

github-actions Bot commented Feb 14, 2025

reentrancy-no-eth

unused-return

Uh oh!

github-actions Bot commented Feb 28, 2025

reentrancy-no-eth

unused-return

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

auroter commented Feb 12, 2025

FeaUrchin Contract Implementation

Overview

Key Changes

New Contract: FeaUrchin

Interface Updates

Test Coverage

Implementation Details

Fee Handling

Asset Tracking

Batch Operations

Testing

Security Considerations

Commits

Note:

WE DO NOT WANT TO MERGE THIS YET BECAUSE THE MAIN BRANCH IS BEING AUDITED. This PR is for educational purposes, for now.

Uh oh!

github-actions Bot commented Feb 12, 2025

Summary of Test Results if Merged To Main:

Test Results for Merge

🔒 Security Analysis

High Severity Issues

arbitrary-send-eth

Medium Severity Issues

reentrancy-no-eth

Recommended Actions

⛽ Gas Analysis

Uh oh!

github-actions Bot commented Feb 12, 2025

Summary of Test Results if Merged To Main:

Test Results for Merge

🔒 Security Analysis

High Severity Issues

arbitrary-send-eth

Medium Severity Issues

reentrancy-no-eth

Recommended Actions

⛽ Gas Analysis

Uh oh!

github-actions Bot commented Feb 12, 2025

Summary of Test Results if Merged To Main:

Test Results for Merge

🔒 Security Analysis

High Severity Issues

arbitrary-send-eth

Medium Severity Issues

reentrancy-no-eth

Recommended Actions

⛽ Gas Analysis

Uh oh!

github-actions Bot commented Feb 14, 2025

Summary of Test Results if Merged To Main:

Test Results for Merge

🔒 Security Analysis

High Severity Issues

arbitrary-send-eth

reentrancy-eth

Medium Severity Issues

reentrancy-no-eth

unused-return

Recommended Actions

⛽ Gas Analysis

Uh oh!

github-actions Bot commented Feb 28, 2025

Summary of Test Results if Merged To Main:

Test Results for Merge

🔒 Security Analysis

High Severity Issues

arbitrary-send-eth

reentrancy-eth

Medium Severity Issues

reentrancy-no-eth

unused-return

Recommended Actions

⛽ Gas Analysis

Uh oh!

Reviewers

Assignees

Labels