fix: use environment variable for private key instead of hardcoded#2
Open
thebookofiz wants to merge 1 commit into0xIntuition:mainfrom
Open
fix: use environment variable for private key instead of hardcoded#2thebookofiz wants to merge 1 commit into0xIntuition:mainfrom
thebookofiz wants to merge 1 commit into0xIntuition:mainfrom
Conversation
- Remove hardcoded Ethereum private key from setup.ts - Require PRIVATE_KEY environment variable (with helpful error message) - Update .env.example to document the required variable - This prevents accidentally committing secrets to version control
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes hardcoded Ethereum private key from src/setup.ts and requires PRIVATE_KEY env var instead. This is a security improvement.