Skip to content

Science upgrades#126

Open
IshanDutta11 wants to merge 11 commits into
umdloop:mainfrom
IshanDutta11:science-upgrades
Open

Science upgrades#126
IshanDutta11 wants to merge 11 commits into
umdloop:mainfrom
IshanDutta11:science-upgrades

Conversation

@IshanDutta11
Copy link
Copy Markdown
Contributor

  • Adds mission launch file
  • Updates science controller to include functionality for current science setup

int active_pump = 0; // 0 for pump a; 1 for pump b
int pump_right_toggle = 0;
int pump_left_toggle = 0;
bool prev_pump_up_button_ = false;
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the prev pump button be shared across active pumps? Chat said: Switching active_pump while a D-pad button is held re-triggers the edge on the newly selected pump, bumping its toggle by 1 unintentionally.

// Reference subscriber
ref_subscriber_ = get_node()->create_subscription<ControllerReferenceMsg>(
"/science_manual", subscribers_qos,
"/science/science_manual", subscribers_qos,
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason the namespace is hard coded, cross check with the launch files for science laucnh make sure this is correct.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was trying to get it working at like 9 am in the morning after an all nighter and couldn't figure it out. I will try and fix it now, totally forgot about this.


def controller_inputs(self):

joystick_vels = self.previous_axes
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whats the reason for dropping to 0 rather than last output, is that intentional / will it cause any issues with pygame if we don't get any axis updates (ex. joystick in same position as last time)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants