refactor: reduced linter warnings

Author: thorsten

SECURITY.md

@@ -55,7 +55,7 @@ In scope examples:
 - Cross-site scripting (XSS) and request forgery (CSRF) with meaningful impact
 - Sensitive information exposure (e.g., secrets, private data)
 
-Out of scope examples (non-exhaustive):
+Out-of-scope examples (non-exhaustive):
 - Denial of service without a clear, reproducible, and product-side fix
 - Third‑party service issues outside this repository
 - Clickjacking on non-sensitive pages, missing SPF/DMARC, best‑practice recommendations only

mago.toml

@@ -18,10 +18,11 @@ null-type-hint = "question"
 integrations = ["symfony", "php-unit"]
 
 [linter.rules]
-cyclomatic-complexity = { threshold = 75 }
-halstead = { difficulty-threshold = 15, volume-threshold = 3000, effort-threshold = 25000 }
-kan-defect = { threshold = 4.0 }
+cyclomatic-complexity = { threshold = 100 }
+halstead = { difficulty-threshold = 15, volume-threshold = 5000, effort-threshold = 25000 }
+kan-defect = { threshold = 5.0 }
 no-boolean-flag-parameter = { enabled = false }
 too-many-enum-cases = { threshold = 50 }
-too-many-methods = { threshold = 20 }
+too-many-methods = { threshold = 24 }
 too-many-properties = { threshold = 15 }
+excessive-parameter-list = { threshold = 7 }

phpmyfaq/src/phpMyFAQ/Attachment/Filesystem/File/EncryptedFile.php

@@ -43,7 +43,7 @@ public function __construct(string $filepath, string $mode, string $key)
     {
         $this->aes = new AES('cbc');
         $this->aes->setKey($key);
-        $this->aes->setIV(substr(hash('sha256', $key, true), 0, 16));
+        $this->aes->setIV(substr(hash('sha256', $key, binary: true), offset: 0, length: 16));
 
         parent::__construct($filepath, $mode);
     }

phpmyfaq/src/phpMyFAQ/Cache/CacheSettingsResolver.php

@@ -75,7 +75,7 @@ public function resolve(): CacheSettings
 
     private function normalizeRedisPrefix(string $redisPrefix): string
     {
-        $normalizedPrefix = preg_replace('/[^-+_.A-Za-z0-9]/', '_', subject: $redisPrefix) ?? '';
+        $normalizedPrefix = preg_replace('/[^-+_.A-Za-z0-9]/', replacement: '_', subject: $redisPrefix) ?? '';
 
         return trim($normalizedPrefix, characters: '_') !== '' ? $normalizedPrefix : self::DEFAULT_REDIS_PREFIX;
     }

phpmyfaq/src/phpMyFAQ/Configuration/Storage/DatabaseConfigurationStore.php

@@ -156,9 +156,11 @@ public function fetchValues(array $names): array
         }
 
         foreach ($rows as $row) {
-            if (is_object($row) && property_exists($row, 'config_name') && property_exists($row, 'config_value')) {
-                $values[(string) $row->config_name] = (string) $row->config_value;
+            if (!(is_object($row) && property_exists($row, 'config_name') && property_exists($row, 'config_value'))) {
+                continue;
             }
+
+            $values[(string) $row->config_name] = (string) $row->config_value;
         }
 
         return $values;

phpmyfaq/src/phpMyFAQ/Controller/AbstractController.php

@@ -217,7 +217,7 @@ protected function isSecured(): void
         }
 
         $request = Request::createFromGlobals();
-        $pathInfo = rtrim($request->getPathInfo(), '/');
+        $pathInfo = rtrim($request->getPathInfo(), characters: '/');
         $pathInfo = $pathInfo === '' ? '/' : $pathInfo;
 
         if ($this->isPublicAuthenticationPath($pathInfo)) {
@@ -249,7 +249,7 @@ private function isPublicAuthenticationPath(string $pathInfo): bool
             '/api/webauthn/login',
         ];
 
-        return in_array($pathInfo, $publicAuthenticationPaths, true);
+        return in_array($pathInfo, $publicAuthenticationPaths, strict: true);
     }
 
     /**

phpmyfaq/src/phpMyFAQ/Controller/Administration/Api/DashboardController.php

@@ -143,7 +143,7 @@ public function news(): JsonResponse
             if ($response->getStatusCode() === Response::HTTP_OK) {
                 $data = $response->toArray(throw: false);
                 if (isset($data['news']) && is_array($data['news'])) {
-                    $data['news'] = array_slice($data['news'], 0, 5);
+                    $data['news'] = array_slice($data['news'], offset: 0, length: 5);
                 }
 
                 return $this->json($data);

phpmyfaq/src/phpMyFAQ/Export/Pdf/Wrapper.php

@@ -710,7 +710,6 @@ private function getImageMimeType(string $data): string|false
      * @param string $align Allows centering or align the image on the current line
      */
     #[\Override]
-    /* @mago-ignore lint:excessive-parameter-list */
     public function WriteHTML(
         // phpcs:ignore
         $html,

phpmyfaq/src/phpMyFAQ/Glossary/GlossaryHelper.php

@@ -62,7 +62,12 @@ public function extractMatchParts(array $matches): array
 
     public function formatTooltip(string $definition, string $item, string $prefix = '', string $postfix = ''): string
     {
-        $fmt = '%s<abbr data-bs-toggle="tooltip" data-bs-placement="bottom" title="%s" class="initialism">%s</abbr>%s';
-        return sprintf($fmt, $prefix, htmlspecialchars($definition, ENT_QUOTES | ENT_HTML5, 'UTF-8'), $item, $postfix);
+        return sprintf(
+            '%s<abbr data-bs-toggle="tooltip" data-bs-placement="bottom" title="%s" class="initialism">%s</abbr>%s',
+            $prefix,
+            htmlspecialchars($definition, ENT_QUOTES | ENT_HTML5, encoding: 'UTF-8'),
+            $item,
+            $postfix,
+        );
     }
 }

phpmyfaq/src/phpMyFAQ/Search/Search/Elasticsearch.php

@@ -19,7 +19,6 @@
 
 namespace phpMyFAQ\Search\Search;
 
-use Elastic\Elasticsearch\Client;
 use Elastic\Elasticsearch\Exception\ClientResponseException;
 use Elastic\Elasticsearch\Exception\ServerResponseException;
 use phpMyFAQ\Configuration;