-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
[RFC]: Add napi/create-uint64 and napi/create-int64 #10922
Copy link
Copy link
Closed
Labels
AcceptedRFC feature request which has been accepted.RFC feature request which has been accepted.CIssue involves or relates to C.Issue involves or relates to C.FeatureIssue or pull request for adding a new feature.Issue or pull request for adding a new feature.Native AddonsIssue involves or relates to Node.js native add-ons.Issue involves or relates to Node.js native add-ons.RFCRequest for comments. Feature requests and proposed changes.Request for comments. Feature requests and proposed changes.difficulty: 2May require some initial design or R&D, but should be straightforward to resolve and/or implement.May require some initial design or R&D, but should be straightforward to resolve and/or implement.priority: NormalNormal priority concern or feature request.Normal priority concern or feature request.
Description
Metadata
Metadata
Assignees
Labels
AcceptedRFC feature request which has been accepted.RFC feature request which has been accepted.CIssue involves or relates to C.Issue involves or relates to C.FeatureIssue or pull request for adding a new feature.Issue or pull request for adding a new feature.Native AddonsIssue involves or relates to Node.js native add-ons.Issue involves or relates to Node.js native add-ons.RFCRequest for comments. Feature requests and proposed changes.Request for comments. Feature requests and proposed changes.difficulty: 2May require some initial design or R&D, but should be straightforward to resolve and/or implement.May require some initial design or R&D, but should be straightforward to resolve and/or implement.priority: NormalNormal priority concern or feature request.Normal priority concern or feature request.
Description
This RFC proposes
To add
napi/create-uint64andnapi/create-int64I see there are TODO's in packages:
blas/base/icamaxblas/base/idamaxand many more packages
TODO message
// TODO: revisit once we support 64-bit integers as return values and 64 integers more generally in JavaScriptWhen i dig further it seems we can implement the following now using the following napi function:
napi_create_bigint_uint64
napi_create_bigint_int64
These funcitons were added in the N-API Version: 6
Related Issues
Related issues # , # , and # .
Questions
No.
Other
No.
Checklist
RFC:.