Various fixes suggested by Clippy.

Author: ltratt

src/config.rs

@@ -102,13 +102,13 @@ impl Config {
                                         "Must allow at least 1 job",
                                     ))
                                 }
-                                Ok(x) if x > (std::usize::MAX - 1) / 2 => {
+                                Ok(x) if x > (usize::MAX - 1) / 2 => {
                                     return Err(error_at_span(
                                         &lexer,
                                         span,
                                         &format!(
                                             "Maximum number of jobs is {}",
-                                            (std::usize::MAX - 1) / 2
+                                            (usize::MAX - 1) / 2
                                         ),
                                     ))
                                 }

src/jobrunner.rs

@@ -63,7 +63,7 @@ impl JobRunner {
     fn new(snare: Arc<Snare>) -> Result<Self, Box<dyn Error>> {
         let shell = env::var("SHELL").unwrap_or_else(|_| "/bin/sh".to_owned());
         let maxjobs = snare.conf.lock().unwrap().maxjobs;
-        assert!(maxjobs <= (std::usize::MAX - 1) / 2);
+        assert!(maxjobs <= (usize::MAX - 1) / 2);
         let mut running = Vec::with_capacity(maxjobs);
         running.resize_with(maxjobs, || None);
         let mut pollfds = Vec::with_capacity(maxjobs * 2 + 1);
@@ -101,10 +101,7 @@ impl JobRunner {
                 if timeout == -1
                     || fby_timeout < Duration::from_millis(timeout.try_into().unwrap_or(0))
                 {
-                    timeout = fby_timeout
-                        .as_millis()
-                        .try_into()
-                        .unwrap_or(c_int::max_value());
+                    timeout = fby_timeout.as_millis().try_into().unwrap_or(c_int::MAX);
                 }
             }
             poll(&mut self.pollfds, timeout).ok();

src/main.rs

@@ -2,10 +2,12 @@
 //!   * The `httpserver` listens for incoming hooks, checks that they're valid, and adds them to a
 //!     `Queue`.
 //!   * The `jobrunner` pops elements from the `Queue` and runs them in parallel.
+//!
 //! These two components run as two different threads: the `httpserver` writes a solitary byte to
 //! an "event pipe" to wake up the `jobrunner` when the queue has new elements. We also wake up the
 //! `jobrunner` on SIGHUP and SIGCHLD.
 
+#![allow(clippy::too_many_arguments)]
 #![allow(clippy::type_complexity)]
 
 mod config;