fix: handle empty thumbnail strings and correct video thumb check

- treat "" same as NULL for thumb parameter in core send routines
  (audio, document, animation, video, video_note) to avoid curl
  CURLE_READ_ERROR (26) when uploading with no thumbnail.
- add comments documenting optional thumb behavior.
- fix typo in send_video: was comparing thumb[0] != '0', now proper '\0'.
- update tests/helpers to exercise media sending paths.

Signed-off-by: Elmurod Talipov <elmurod.talipov@gmail.com>

Author: smartnode

CMakeLists.txt

@@ -21,7 +21,6 @@ SET(SRCS
     src/telebot-games.c
 )
 
-ADD_DEFINITIONS("-DDEBUG=0")
 INCLUDE_DIRECTORIES(${CMAKE_CURRENT_SOURCE_DIR}/include)
 SET(DEPENDENTS "libcurl json-c")
 INCLUDE(FindPkgConfig)
@@ -30,7 +29,16 @@ pkg_check_modules(PKGS REQUIRED ${DEPENDENTS})
 FOREACH(flag ${PKGS_CFLAGS})
     SET(EXTRA_LIB_CFLAGS "${EXTRA_LIB_CFLAGS} ${flag}")
 ENDFOREACH(flag)
-SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_LIB_CFLAGS} -Werror -Wall -Wno-unused-function -O2" )
+SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} ${EXTRA_LIB_CFLAGS} -Werror -Wall -Wno-unused-function" )
+
+#Debug option
+IF(DEBUG)
+    MESSAGE("Build debug version")
+    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -g")
+    ADD_DEFINITIONS("-DDEBUG")
+ELSE(DEBUG)
+    SET(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -O2")
+ENDIF(DEBUG)
 
 # libtelebot
 ADD_LIBRARY(${PROJECT_NAME} SHARED ${SRCS})

README.md

@@ -28,11 +28,25 @@ To build the library run following commands:
 
 ```sh
 cd [your repository]
-mkdir -p Build && cd Build
-cmake ../
+mkdir -p build && cd build
+cmake ..
 make
 ```
 
+For debug build
+```sh
+mkdir -p build && cd build
+cmake .. -DDEBUG=1
+make
+```
+
+## Testing
+
+Place Telegam Bot API Token in .toke file in the root folder of the repository, and run as below
+```sh
+./build/test/testbot
+```
+
 <details>
 <summary>Sample</summary>
 

include/telebot-private.h

@@ -664,7 +664,7 @@ telebot_core_send_audio(telebot_core_handler_t core_h, long long int chat_id, co
         count++;
     }
 
-    if (thumb != NULL)
+    if (thumb != NULL && thumb[0] != '\0')
     {
         mimes[count].name = "thumb";
         mimes[count].type = TELEBOT_MIME_TYPE_FILE;
@@ -715,7 +715,7 @@ telebot_core_send_document(telebot_core_handler_t core_h, long long int chat_id,
     mimes[count].data.s = document;
     count++;
 
-    if (thumb != NULL)
+    if (thumb != NULL && thumb[0] != '\0')
     {
         mimes[count].name = "thumb";
         mimes[count].type = TELEBOT_MIME_TYPE_FILE;
@@ -806,7 +806,7 @@ telebot_core_send_video(telebot_core_handler_t core_h, long long int chat_id, co
         count++;
     }
 
-    if (thumb != NULL)
+    if (thumb != NULL && thumb[0] != '\0')
     {
         mimes[count].name = "thumb";
         mimes[count].type = TELEBOT_MIME_TYPE_FILE;
@@ -902,7 +902,7 @@ telebot_core_send_animation(telebot_core_handler_t core_h, long long int chat_id
         count++;
     }
 
-    if (thumb != NULL)
+    if (thumb != NULL && thumb[0] != '0')
     {
         mimes[count].name = "thumb";
         mimes[count].type = TELEBOT_MIME_TYPE_FILE;
@@ -1051,7 +1051,7 @@ telebot_core_send_video_note(telebot_core_handler_t core_h, long long int chat_i
         count++;
     }
 
-    if (thumb != NULL)
+    if (thumb != NULL && thumb[0] != '\0')
     {
         mimes[count].name = "thumb";
         mimes[count].type = TELEBOT_MIME_TYPE_FILE;

src/telebot-core.c

@@ -649,16 +649,6 @@ telebot_error_e telebot_parser_get_chat(struct json_object *obj, telebot_chat_t
     if (json_object_object_get_ex(obj, "invite_link", &invite_link))
         chat->invite_link = TELEBOT_SAFE_STRDUP(json_object_get_string(invite_link));
 
-    struct json_object *pinned_message = NULL;
-    if (json_object_object_get_ex(obj, "pinned_message", &pinned_message))
-    {
-        chat->pinned_message = calloc(1, sizeof(telebot_message_t));
-        if (telebot_parser_get_message(pinned_message, chat->pinned_message) != TELEBOT_ERROR_NONE)
-        {
-            ERR("Failed to get <pinned_message> from chat object");
-            TELEBOT_SAFE_FREE(chat->pinned_message);
-        }
-    }
 
     struct json_object *permissions = NULL;
     if (json_object_object_get_ex(obj, "permissions", &permissions))

src/telebot-parser.c

@@ -37,18 +37,23 @@ static const char *telebot_update_type_str[TELEBOT_UPDATE_TYPE_MAX] = {
     "edited_message",
     "channel_post",
     "edited_channel_post",
+    "business_connection",
+    "business_message",
+    "edited_business_message",
+    "deleted_business_messages",
+    "message_reaction",
+    "message_reaction_count",
     "inline_query",
     "chosen_inline_result",
     "callback_query",
     "shipping_query",
     "pre_checkout_query",
+    "purchased_paid_media",
     "poll",
     "poll_answer",
     "my_chat_member",
     "chat_member",
     "chat_join_request",
-    "message_reaction",
-    "message_reaction_count",
     "chat_boost",
     "removed_chat_boost"};
 
@@ -1945,6 +1950,9 @@ static void telebot_put_chat_permissions(telebot_chat_permissions_t *permissions
 
 static void telebot_put_chat_location(telebot_chat_location_t *chat_location)
 {
+    if (chat_location == NULL)
+        return;
+
     TELEBOT_SAFE_FREE(chat_location->address);
     telebot_put_location(chat_location->location);
 }

src/telebot.c

@@ -9,12 +9,12 @@
 #define SIZE_OF_ARRAY(array) (sizeof(array) / sizeof(array[0]))
 
 /* Local sample media paths */
-#define SAMPLE_PHOTO      "samples/logo.png"
-#define SAMPLE_AUDIO      "samples/audio.mp3"
-#define SAMPLE_VIDEO      "samples/video.mp4"
-#define SAMPLE_DOC        "samples/document.md"
-#define SAMPLE_ANIMATION  "samples/animation.gif"
-#define SAMPLE_VOICE      "samples/voice.wav"
+#define SAMPLE_PHOTO     "test/samples/logo.png"
+#define SAMPLE_AUDIO     "test/samples/audio.mp3"
+#define SAMPLE_VIDEO     "test/samples/video.mp4"
+#define SAMPLE_DOC       "test/samples/document.md"
+#define SAMPLE_ANIMATION "test/samples/animation.gif"
+#define SAMPLE_VOICE     "test/samples/voice.wav"
 
 void setup_commands(telebot_handler_t handle)
 {
@@ -70,7 +70,7 @@ void handle_message(telebot_handler_t handle, telebot_message_t *message)
                                "{\"text\":\"Document\",\"callback_data\":\"media_doc\"}],"
                                "[{\"text\":\"Animation\",\"callback_data\":\"media_animation\"},"
                                "{\"text\":\"Voice\",\"callback_data\":\"media_voice\"}]]}";
-        ret = telebot_send_message(handle, message->chat->id, "Select media to send (from local files):", "", false, false, 0, keyboard);
+        ret = telebot_send_message(handle, message->chat->id, "Select media to send:", "", false, false, 0, keyboard);
     }
     else if (strstr(message->text, "/keyboard"))
     {
@@ -149,29 +149,39 @@ void handle_callback_query(telebot_handler_t handle, telebot_callback_query_t *q
     telebot_error_e ret = TELEBOT_ERROR_NONE;
     long long int chat_id = query->message->chat->id;
 
+    int duration = 0;
+    int width = 0;
+    int height = 0;
+    const char *thumb = NULL;
+    bool disable_notification = false;
+    int reply_to_message_id = 0;
+    const char *reply_markup = NULL;
+    const char *parse_mode = "";
+    bool is_file = true;
+
     if (strcmp(query->data, "media_photo") == 0)
     {
-        ret = telebot_send_photo(handle, chat_id, SAMPLE_PHOTO, true, "Test Photo from local file", "", false, 0, "");
+        ret = telebot_send_photo(handle, chat_id, SAMPLE_PHOTO, is_file, "Test Photo", parse_mode, disable_notification, reply_to_message_id, reply_markup);
     }
     else if (strcmp(query->data, "media_audio") == 0)
     {
-        ret = telebot_send_audio(handle, chat_id, SAMPLE_AUDIO, true, "Test Audio from local file", "", 0, "Artist", "Title", "", false, 0, "");
+        ret = telebot_send_audio(handle, chat_id, SAMPLE_AUDIO, is_file, "Test Audio", parse_mode, duration, "Artist", "Title", parse_mode, disable_notification, reply_to_message_id, reply_markup);
     }
     else if (strcmp(query->data, "media_video") == 0)
     {
-        ret = telebot_send_video(handle, chat_id, SAMPLE_VIDEO, true, 0, 0, 0, "", "Test Video from local file", "", false, false, 0, "");
+        ret = telebot_send_video(handle, chat_id, SAMPLE_VIDEO, is_file, duration, width, height, thumb, "Test Video", parse_mode, disable_notification, false, reply_to_message_id, reply_markup);
     }
     else if (strcmp(query->data, "media_doc") == 0)
     {
-        ret = telebot_send_document(handle, chat_id, SAMPLE_DOC, true, "", "Test Document from local file", "", false, 0, "");
+        ret = telebot_send_document(handle, chat_id, SAMPLE_DOC, is_file, thumb, "Test Document", parse_mode, disable_notification, reply_to_message_id, reply_markup);
     }
     else if (strcmp(query->data, "media_animation") == 0)
     {
-        ret = telebot_send_animation(handle, chat_id, SAMPLE_ANIMATION, true, 0, 0, 0, "", "Test Animation from local file", "", false, 0, "");
+        ret = telebot_send_animation(handle, chat_id, SAMPLE_ANIMATION, is_file, duration, width, height, thumb, "Test Animation", parse_mode, disable_notification, reply_to_message_id, reply_markup);
     }
     else if (strcmp(query->data, "media_voice") == 0)
     {
-        ret = telebot_send_voice(handle, chat_id, SAMPLE_VOICE, true, "Test Voice from local file", "", 0, false, 0, "");
+        ret = telebot_send_voice(handle, chat_id, SAMPLE_VOICE, is_file, "Test Voice", parse_mode, duration, disable_notification, reply_to_message_id, reply_markup);
     }
 
     /* Acknowledge callback query */