From 047821b1d50c21aecb5bf6479b7a217652b6a47d Mon Sep 17 00:00:00 2001 From: shadowdevcode Date: Thu, 26 Mar 2026 01:45:22 +0530 Subject: [PATCH] Remove build IDs from user UI --- src/App.tsx | 11 ++--------- test/unit/run.ts | 37 +++++++++++++++++++++++++++++++++++++ 2 files changed, 39 insertions(+), 9 deletions(-) diff --git a/src/App.tsx b/src/App.tsx index 48d7ab5..0d83b14 100644 --- a/src/App.tsx +++ b/src/App.tsx @@ -62,10 +62,6 @@ function resolveAppBuildId(): string { return 'dev-local'; } -function appendBuildIdToDiagnosticMessage(message: string, buildId: string): string { - return `${message} [build:${buildId}]`; -} - export default function App() { const [user, setUser] = useState(null); const [isAuthReady, setIsAuthReady] = useState(false); @@ -321,7 +317,7 @@ export default function App() { membershipProbeResult, }); - setUnknownQueueWarning(appendBuildIdToDiagnosticMessage(classification.userMessage, appBuildId)); + setUnknownQueueWarning(classification.userMessage); hasLoadedUnknownQueue = true; markInitialViewReady(); }; @@ -363,7 +359,7 @@ export default function App() { unknownQueueUnsub(); unknownQueueUnsub = null; } - setUnknownQueueWarning(appendBuildIdToDiagnosticMessage('Review queue order is temporarily unavailable.', appBuildId)); + setUnknownQueueWarning('Review queue order is temporarily unavailable.'); subscribeUnknownQueueFallback(); return; } @@ -674,9 +670,6 @@ export default function App() {
-
- Build {appBuildId} -
{isOwner ? : } {isOwner ? appCopy.ownerRole : appCopy.cookRole} diff --git a/test/unit/run.ts b/test/unit/run.ts index 0c44723..7b4a6a6 100644 --- a/test/unit/run.ts +++ b/test/unit/run.ts @@ -429,6 +429,43 @@ function testUnknownQueueErrorParsingAndMessaging(): void { userMessage: 'Review queue is temporarily unavailable.', }, ); + + const userFacingMessages = [ + getUnknownQueueLoadErrorMessage(permissionDenied, 'owner'), + getUnknownQueueLoadErrorMessage(permissionDenied, 'non-member'), + getUnknownQueueLoadErrorMessage(failedPrecondition, 'owner'), + getUnknownQueueLoadErrorMessage(unknownError, null), + classifyUnknownQueueLoadFailure({ + error: permissionDenied, + membershipProbeResult: 'owner', + plainReadProbeResult: 'permission-denied', + }).userMessage, + classifyUnknownQueueLoadFailure({ + error: permissionDenied, + membershipProbeResult: 'owner', + plainReadProbeResult: 'succeeded', + }).userMessage, + classifyUnknownQueueLoadFailure({ + error: permissionDenied, + membershipProbeResult: 'non-member', + plainReadProbeResult: 'not-run', + }).userMessage, + classifyUnknownQueueLoadFailure({ + error: failedPrecondition, + membershipProbeResult: 'owner', + plainReadProbeResult: 'not-run', + }).userMessage, + classifyUnknownQueueLoadFailure({ + error: unknownError, + membershipProbeResult: null, + plainReadProbeResult: 'failed', + }).userMessage, + ]; + + for (const message of userFacingMessages) { + assert.equal(message.includes('[build:'), false); + assert.equal(message.includes('Build '), false); + } } function testUnknownQueueFallbackSortOrder(): void {