From 3e3c803ea981fbf811587ec242bcc5279aa4b8fa Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Thu, 2 Apr 2026 16:43:02 +0200 Subject: [PATCH 01/11] Created netlify configuration Signed-off-by: fantonangeli --- netlify.toml | 6 ++++++ 1 file changed, 6 insertions(+) create mode 100644 netlify.toml diff --git a/netlify.toml b/netlify.toml new file mode 100644 index 0000000..002cf56 --- /dev/null +++ b/netlify.toml @@ -0,0 +1,6 @@ +[build] + command = "pnpm install --frozen-lockfile && pnpm build:storybook" + publish = "packages/serverless-workflow-diagram-editor/dist-storybook" + + # Ignore publishing if @serverlessworkflow/diagram-editor and its dependencies have no changes + ignore = "! pnpm -F '...[origin/main]' exec pnpm pkg get name | grep -q '\"@serverlessworkflow/diagram-editor\"'" From 57041d83d950e3f3f3bd67cbffbe113ff5c57443 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Thu, 2 Apr 2026 17:11:51 +0200 Subject: [PATCH 02/11] Fixed build command Signed-off-by: fantonangeli --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index 002cf56..d11e185 100644 --- a/netlify.toml +++ b/netlify.toml @@ -1,5 +1,5 @@ [build] - command = "pnpm install --frozen-lockfile && pnpm build:storybook" + command = "pnpm install --frozen-lockfile && pnpm -F @serverlessworkflow/diagram-editor... build:dev && pnpm -F @serverlessworkflow/diagram-editor build:storybook" publish = "packages/serverless-workflow-diagram-editor/dist-storybook" # Ignore publishing if @serverlessworkflow/diagram-editor and its dependencies have no changes From 249aeac5df60883cd75ed5e379ba1b1e335d3db0 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Thu, 2 Apr 2026 17:38:59 +0200 Subject: [PATCH 03/11] Moved change detection to build Signed-off-by: fantonangeli --- netlify.toml | 27 +++++++++++++++++++++++---- 1 file changed, 23 insertions(+), 4 deletions(-) diff --git a/netlify.toml b/netlify.toml index d11e185..52281de 100644 --- a/netlify.toml +++ b/netlify.toml @@ -1,6 +1,25 @@ +# +# Copyright 2021-Present The Serverless Workflow Specification Authors +# +# Licensed under the Apache License, Version 2.0 (the "License"); +# you may not use this file except in compliance with the License. +# You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +# + [build] - command = "pnpm install --frozen-lockfile && pnpm -F @serverlessworkflow/diagram-editor... build:dev && pnpm -F @serverlessworkflow/diagram-editor build:storybook" + command = """ + pnpm install --frozen-lockfile && + pnpm -F '...[origin/main]' exec pnpm pkg get name | grep -q '\"@serverlessworkflow/diagram-editor\"' || + exit 0 + pnpm -F @serverlessworkflow/diagram-editor... build:dev && + pnpm -F @serverlessworkflow/diagram-editor build:storybook + """ publish = "packages/serverless-workflow-diagram-editor/dist-storybook" - - # Ignore publishing if @serverlessworkflow/diagram-editor and its dependencies have no changes - ignore = "! pnpm -F '...[origin/main]' exec pnpm pkg get name | grep -q '\"@serverlessworkflow/diagram-editor\"'" From 19586226dc6a4d4e4790a63fcfe6e14dd577fd9e Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Fri, 3 Apr 2026 15:47:15 +0200 Subject: [PATCH 04/11] Rewrite netlify config Signed-off-by: fantonangeli --- README.md | 10 ++++++---- netlify.toml | 14 +++++++++----- 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index faebffa..fe39849 100644 --- a/README.md +++ b/README.md @@ -1,12 +1,12 @@ # editor + CNCF Serverless Workflow Specification Visual Editor ## Prerequisites To build and run the editor locally, you will need: -- **Node.js 22** (current LTS version; see https://nodejs.org/) + +- **Node.js 24** (current LTS version; see https://nodejs.org/) - **pnpm 10.31.0** ## Building the Project diff --git a/netlify.toml b/netlify.toml index 52281de..4dd72f2 100644 --- a/netlify.toml +++ b/netlify.toml @@ -14,12 +14,16 @@ # limitations under the License. # +[build.environment] + NODE_VERSION = "24" + [build] command = """ - pnpm install --frozen-lockfile && - pnpm -F '...[origin/main]' exec pnpm pkg get name | grep -q '\"@serverlessworkflow/diagram-editor\"' || - exit 0 - pnpm -F @serverlessworkflow/diagram-editor... build:dev && - pnpm -F @serverlessworkflow/diagram-editor build:storybook + set -e + PREVIEW_PACKAGE_NAME='@serverlessworkflow/diagram-editor' + pnpm -F '...[origin/main]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" || { echo "Skip build: No changes detected"; exit 0; } + echo "Building ${PREVIEW_PACKAGE_NAME}####################################################################################################" + pnpm -F "${PREVIEW_PACKAGE_NAME}..." build:dev + pnpm -F "$PREVIEW_PACKAGE_NAME" build:storybook """ publish = "packages/serverless-workflow-diagram-editor/dist-storybook" From 4f815e6513c89318e35e51ebd09ccbf0cb833d90 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Fri, 3 Apr 2026 15:48:58 +0200 Subject: [PATCH 05/11] Improved log markers Signed-off-by: fantonangeli --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index 4dd72f2..ae982cc 100644 --- a/netlify.toml +++ b/netlify.toml @@ -22,7 +22,7 @@ set -e PREVIEW_PACKAGE_NAME='@serverlessworkflow/diagram-editor' pnpm -F '...[origin/main]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" || { echo "Skip build: No changes detected"; exit 0; } - echo "Building ${PREVIEW_PACKAGE_NAME}####################################################################################################" + echo "Building ${PREVIEW_PACKAGE_NAME}##################################################" pnpm -F "${PREVIEW_PACKAGE_NAME}..." build:dev pnpm -F "$PREVIEW_PACKAGE_NAME" build:storybook """ From 9bad0c263883c806daa22960492fca76b07e05d2 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Tue, 7 Apr 2026 18:22:10 +0200 Subject: [PATCH 06/11] Refactored netlify config Signed-off-by: fantonangeli --- netlify.toml | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/netlify.toml b/netlify.toml index ae982cc..e2d3d78 100644 --- a/netlify.toml +++ b/netlify.toml @@ -16,14 +16,18 @@ [build.environment] NODE_VERSION = "24" + PNPM_VERSION = "10.31.0" + PREVIEW_PACKAGE_NAME = "@serverlessworkflow/diagram-editor" [build] command = """ set -e - PREVIEW_PACKAGE_NAME='@serverlessworkflow/diagram-editor' - pnpm -F '...[origin/main]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" || { echo "Skip build: No changes detected"; exit 0; } - echo "Building ${PREVIEW_PACKAGE_NAME}##################################################" pnpm -F "${PREVIEW_PACKAGE_NAME}..." build:dev pnpm -F "$PREVIEW_PACKAGE_NAME" build:storybook """ publish = "packages/serverless-workflow-diagram-editor/dist-storybook" + ignore = """ + set -e + pnpm i -g "pnpm@$PNPM_VERSION" + ! pnpm -F '...[origin/issue-30-feat-Add-GitHub-Action-to-publish-Storybook-preview-for-every-PR-via-netlify]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" + """ From 8d610e92d3c9c4b80720a121c3945f2044d70d68 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Tue, 7 Apr 2026 18:28:37 +0200 Subject: [PATCH 07/11] typo Signed-off-by: fantonangeli --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index e2d3d78..5f8027f 100644 --- a/netlify.toml +++ b/netlify.toml @@ -28,6 +28,6 @@ publish = "packages/serverless-workflow-diagram-editor/dist-storybook" ignore = """ set -e - pnpm i -g "pnpm@$PNPM_VERSION" + npm i -g "pnpm@$PNPM_VERSION" ! pnpm -F '...[origin/issue-30-feat-Add-GitHub-Action-to-publish-Storybook-preview-for-every-PR-via-netlify]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" """ From 448a6092f2bf4ce734a975dae754fd6e209972e0 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Tue, 7 Apr 2026 18:42:24 +0200 Subject: [PATCH 08/11] Changed test branch ref Signed-off-by: fantonangeli --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index 5f8027f..6a24a1f 100644 --- a/netlify.toml +++ b/netlify.toml @@ -29,5 +29,5 @@ ignore = """ set -e npm i -g "pnpm@$PNPM_VERSION" - ! pnpm -F '...[origin/issue-30-feat-Add-GitHub-Action-to-publish-Storybook-preview-for-every-PR-via-netlify]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" + ! pnpm -F '...[origin/main]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" """ From 204b11e38c02b2141a1d1ac321065abee278c4f0 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Wed, 8 Apr 2026 09:45:20 +0200 Subject: [PATCH 09/11] Add git fetch main Signed-off-by: fantonangeli --- netlify.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/netlify.toml b/netlify.toml index 6a24a1f..d99917e 100644 --- a/netlify.toml +++ b/netlify.toml @@ -28,6 +28,7 @@ publish = "packages/serverless-workflow-diagram-editor/dist-storybook" ignore = """ set -e + git fetch --no-tags --depth=1 origin main:refs/remotes/origin/main npm i -g "pnpm@$PNPM_VERSION" ! pnpm -F '...[origin/main]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" """ From 427ba7796326c016d1e46819a1356d52e48ee048 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Wed, 8 Apr 2026 10:20:23 +0200 Subject: [PATCH 10/11] Fixes comment: https://github.com/serverlessworkflow/editor/pull/58#discussion_r3049971634 Signed-off-by: fantonangeli --- netlify.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/netlify.toml b/netlify.toml index d99917e..83da046 100644 --- a/netlify.toml +++ b/netlify.toml @@ -27,7 +27,7 @@ """ publish = "packages/serverless-workflow-diagram-editor/dist-storybook" ignore = """ - set -e + set -e -o pipefail git fetch --no-tags --depth=1 origin main:refs/remotes/origin/main npm i -g "pnpm@$PNPM_VERSION" ! pnpm -F '...[origin/main]' -rc exec 'echo "$PNPM_PACKAGE_NAME"' | grep -Fqx "$PREVIEW_PACKAGE_NAME" From 87e6382b0b9799530ba292933814e314d14a6f89 Mon Sep 17 00:00:00 2001 From: fantonangeli Date: Wed, 8 Apr 2026 12:45:58 +0200 Subject: [PATCH 11/11] Reverted README change Signed-off-by: fantonangeli --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index fe39849..970b2fa 100644 --- a/README.md +++ b/README.md @@ -22,7 +22,7 @@ CNCF Serverless Workflow Specification Visual Editor To build and run the editor locally, you will need: -- **Node.js 24** (current LTS version; see https://nodejs.org/) +- **Node.js 22** (current LTS version; see https://nodejs.org/) - **pnpm 10.31.0** ## Building the Project