Port away from Plasma::Dialog

[davidedmundson]

This was deprecated years ago, with PlasmaWindow (and various subclasses) being the replacement.

If anything is missing, please let me know and I'll fix it upstream.

It's relatively important as anyone with a debug build will get an assert when the window appears with no valid size. This is mostly a bug in Dialog.

[rxappdev]

Ahh thank you for letting me know. Had no idea.

Is there any good place to find the APIs for PlasmaWindow and subclass or is the source code the only place to look?
https://github.com/KDE/plasma-framework/tree/master/src/plasmaquick

[rxappdev]

So I started looking into it today. But I can't get transparent window background to work with PlasmaWindow.

import org.kde.plasma.core as PlasmaCore
PlasmaCore.Window {
    backgroundHints: PlasmaCore.Window.StandardBackground
    color: "transparent"
...
}

Issue is the backgroundHints can only be:

    enum BackgroundHints {
        StandardBackground = 0,
        SolidBackground = 1,
    };

For a Dialog you can specify:
backgroundHints: PlasmaCore.Types.NoBackground

Do I have to migrate on current plasma versions?

Or for future plasma only? Like Plasma 6.7?

[davidedmundson]

If you don't need a Background, what is Plasma::Dialog providing that isn't available in just QtQuick.Window ?

[rxappdev]

Haha good timing, yeah, that's exactly what I did:
27147fa

The advantage of Plasma::Dialog and PlasmaWindow was they could be displayed inside an Item.
But after switching to QtQuick.Window I had to make the root element a QtQuick.Window as well for it to work.

Anyway, the patch I uploaded is just a workaround, maybe one day in the future I get some spare time to refactor and make it work properly. But I hope this will work until that day.

[rxappdev]

Oh and the original reason I used a Plasma::Dialog was because I have never coded in Qt before or for KWin, and I looked at a few different tilers and saw they used Plasma::Dialog.

I thought that was how you are supposed to implement things in KWin/Plasma. I probably wrote that code day one, and didn't touch it since.

New APIs, new platform. So followed what was already established.

https://github.com/51n7/kTile/blob/57863c86e6f4097a2e52bb780932858e67baddd3/package/contents/ui/main.qml#L16

https://github.com/gerritdevriese/kzones/blob/a8417d9e492ae6b69150de66ba1cdc114beaadcb/src/contents/ui/main.qml#L9