Configure Devise responder for Turbo compatibility (#1444)

* Configure Devise responder for Turbo compatibility

Devise 5 supports Turbo-aware status codes natively via responder
config. Set error_status to :unprocessable_entity and redirect_status
to :see_other so Turbo can handle Devise form responses correctly,
and remove the data-turbo=false workarounds from login, confirmation,
and welcome forms.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* flash error message

* fix flash messages

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Co-authored-by: Justin Miller <16829344+jmilljr24@users.noreply.github.com>

Author: 3 people

app/controllers/confirmations_controller.rb

@@ -21,17 +21,19 @@ def show
     end
   end
 
+
   # POST /users/confirmation (resend)
   def create
     self.resource = resource_class.send_confirmation_instructions(resource_params)
 
-    if resource.errors.empty?
-      redirect_to new_user_session_path,
-                  notice: "If your email exists in our system, you will receive confirmation instructions shortly."
+    if resource.errors.empty? || email_not_found?
+      flash[:notice] = "If your email exists in our system, you will receive confirmation instructions shortly."
+      redirect_to new_user_session_path
     elsif resource.confirmed_at.present?
-      redirect_to new_user_session_path,
-                  notice: "Your email is already confirmed. Please sign in."
+      flash[:notice] = "Your email is already confirmed. Please sign in."
+      redirect_to new_user_session_path
     else
+      flash.now[:alert] = resource.errors.full_messages.join(", ")
       respond_with(resource)
     end
   end
@@ -47,4 +49,10 @@ def after_confirmation_success(resource)
       redirect_to new_user_session_path, notice: "Your email has been confirmed. Please sign in."
     end
   end
+
+  private
+
+  def email_not_found?
+    resource.errors.any? { |e| e.attribute == :email && e.type == :not_found }
+  end
 end

app/views/devise/confirmations/new.html.erb

@@ -24,8 +24,7 @@
 
       <div class="action-buttons mt-8 flex justify-center gap-3">
         <%= f.submit "Resend confirmation instructions",
-                     class: "btn btn-primary",
-                     data: { turbo: false} %>
+                     class: "btn btn-primary" %>
       </div>
     <% end %>
 

app/views/devise/sessions/new.html.erb

@@ -7,7 +7,7 @@
       Log in to our Portal
     </h2>
 
-    <%= simple_form_for(resource, url: session_path(resource_name), data: { turbo: false }) do |f| %>
+    <%= simple_form_for(resource, url: session_path(resource_name)) do |f| %>
       <% if resource.errors.any? %>
         <%= render 'shared/errors', resource: resource %>
       <% end %>

app/views/welcome/show.html.erb

@@ -13,7 +13,7 @@
     </div>
 
     <%= simple_form_for(@user, url: user_welcome_update_path(@user.welcome_instructions_token),
-                        scope: :user, html: { class: "space-y-4" }, data: { turbo_method: :patch, turbo: false }) do |f| %>
+                        scope: :user, html: { class: "space-y-4" }) do |f| %>
       <% if @user.errors.any? %>
         <%= render 'shared/errors', resource: @user %>
       <% end %>

config/initializers/devise.rb

@@ -13,6 +13,10 @@
   config.mailer_sender = ENV.fetch("REPLY_TO_EMAIL", "programs@awbw.org")
   config.sign_in_after_reset_password = true
 
+  # Use Turbo-compatible HTTP status codes
+  config.responder.error_status = :unprocessable_entity
+  config.responder.redirect_status = :see_other
+
   # Configure the class responsible to send e-mails.
   # config.mailer = 'Devise::Mailer'
   config.mailer = "DeviseMailer"