Add one-time field hiding, flexbox layout, and cocoon insertion fix

- Add `one_time` boolean to form_fields for cross-form answer hiding
- Two-tier answer hiding: one-time checks all forms, regular checks within event
- Switch field rows to flexbox with wrap for responsive layout
- Make section header names editable text fields
- New cocoon fields now append to bottom of form field list
- Add ONE_TIME_GROUPS to FormBuilderService for professional/background sections

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

Author: maebeale

app/controllers/events/public_registrations_controller.rb

@@ -142,25 +142,47 @@ def visible_form_fields
         end
 
         if @form.hide_answered_form_questions?
-          existing_submission = @form.form_submissions.find_by(person: person)
-          if existing_submission
-            answered_field_ids = existing_submission.form_answers
-                                                   .joins(:form_field)
-                                                   .where(form_fields: { visibility: :answers_on_file })
-                                                   .where.not(text: [ nil, "" ])
-                                                   .pluck(:form_field_id)
-            if answered_field_ids.any?
-              scope = scope.where.not(id: answered_field_ids)
-
-              # Hide section headers when all their non-header fields are answered
-              answered_groups = @form.form_fields.where(id: answered_field_ids)
-                                    .pluck(:field_group).uniq.compact
-              answered_groups.each do |group|
-                group_field_ids = @form.form_fields.where(field_group: group, visibility: :answers_on_file)
-                                      .where.not(answer_type: :group_header).ids
-                if group_field_ids.any? && (group_field_ids - answered_field_ids).empty?
-                  scope = scope.where.not(field_group: group, answer_type: :group_header, visibility: :answers_on_file)
-                end
+          answered_field_ids = []
+
+          # One-time fields: hide if answered on ANY form submission for this person
+          one_time_field_ids = @form.form_fields.where(visibility: :answers_on_file, one_time: true)
+                                   .where.not(answer_type: :group_header).ids
+          if one_time_field_ids.any?
+            answered_one_time = FormAnswer.joins(:form_submission)
+                                         .where(form_submissions: { person_id: person.id })
+                                         .where(form_field_id: one_time_field_ids)
+                                         .where.not(text: [ nil, "" ])
+                                         .pluck(:form_field_id)
+            answered_field_ids.concat(answered_one_time)
+          end
+
+          # Regular fields: hide if answered on forms within this event
+          event_form_ids = @event.forms.ids
+          event_submissions = FormSubmission.where(person: person, form_id: event_form_ids)
+          if event_submissions.exists?
+            regular_field_ids = @form.form_fields.where(visibility: :answers_on_file, one_time: false)
+                                     .where.not(answer_type: :group_header).ids
+            if regular_field_ids.any?
+              answered_regular = FormAnswer.where(form_submission: event_submissions)
+                                          .where(form_field_id: regular_field_ids)
+                                          .where.not(text: [ nil, "" ])
+                                          .pluck(:form_field_id)
+              answered_field_ids.concat(answered_regular)
+            end
+          end
+
+          answered_field_ids.uniq!
+          if answered_field_ids.any?
+            scope = scope.where.not(id: answered_field_ids)
+
+            # Hide section headers when all their non-header fields are answered
+            answered_groups = @form.form_fields.where(id: answered_field_ids)
+                                  .pluck(:field_group).uniq.compact
+            answered_groups.each do |group|
+              group_field_ids = @form.form_fields.where(field_group: group, visibility: :answers_on_file)
+                                    .where.not(answer_type: :group_header).ids
+              if group_field_ids.any? && (group_field_ids - answered_field_ids).empty?
+                scope = scope.where.not(field_group: group, answer_type: :group_header, visibility: :answers_on_file)
               end
             end
           end

app/controllers/forms_controller.rb

@@ -119,7 +119,7 @@ def form_params
       :name, :hide_answered_person_questions, :hide_answered_form_questions,
       form_fields_attributes: [
         :id, :question, :answer_type, :is_required, :instructional_hint,
-        :field_key, :field_group, :position, :visibility, :_destroy
+        :field_key, :field_group, :position, :visibility, :one_time, :_destroy
       ]
     )
   end

app/services/form_builder_service.rb

@@ -110,6 +110,9 @@ def self.update_sections!(form, new_sections)
     "post_event_feedback" => :answers_on_file
   }.freeze
 
+  # Groups where answers carry across all events (ask once ever)
+  ONE_TIME_GROUPS = %w[professional background].freeze
+
   def add_header(form, position, title, group:)
     position += 1
     form.form_fields.create!(
@@ -120,7 +123,8 @@ def add_header(form, position, title, group:)
       is_required: false,
       field_key: nil,
       field_group: group,
-      visibility: GROUP_VISIBILITY.fetch(group, :always_ask)
+      visibility: GROUP_VISIBILITY.fetch(group, :always_ask),
+      one_time: ONE_TIME_GROUPS.include?(group)
     )
     position
   end
@@ -137,7 +141,8 @@ def add_field(form, position, question, answer_type, key:, group:, required: tru
       instructional_hint: hint,
       field_key: key,
       field_group: group,
-      visibility: GROUP_VISIBILITY.fetch(group, :always_ask)
+      visibility: GROUP_VISIBILITY.fetch(group, :always_ask),
+      one_time: ONE_TIME_GROUPS.include?(group)
     )
 
     if options.present?

app/views/forms/_form_field_fields.html.erb

@@ -32,49 +32,44 @@
             {},
             class: "text-xs rounded-full border px-2 py-0.5 cursor-pointer",
             data: { controller: "chip-select", chip_select_styles_value: visibility_styles, action: "change->chip-select#update" } %>
-      <span class="text-lg font-semibold text-gray-800"><%= field.question %></span>
-      <%= f.hidden_field :question %>
+      <%= f.text_field :question, class: "flex-1 text-lg font-semibold text-gray-800 rounded border-gray-300 shadow-sm px-2 py-1" %>
       <div class="ml-auto">
         <%= link_to_remove_association "Remove", f,
               class: "text-sm text-gray-400 hover:text-red-600 underline" %>
       </div>
     </div>
   <% else %>
-    <div class="flex-1 grid grid-cols-12 gap-3 items-center">
-      <div class="col-span-5 flex items-center gap-2">
-        <%= f.select :visibility, visibility_options,
-              {},
-              class: "text-xs rounded-full border px-2 py-0.5 shrink-0 cursor-pointer",
-              data: { controller: "chip-select", chip_select_styles_value: visibility_styles, action: "change->chip-select#update" } %>
-        <%= f.text_field :question, class: "w-full rounded border-gray-300 shadow-sm px-2 py-1 text-sm" %>
-      </div>
-      <div class="col-span-3">
-        <%
-          type_order = %w[free_form_input_one_line free_form_input_paragraph multiple_choice_radio multiple_choice_checkbox no_user_input group_header]
-          type_labels = {
-            "group_header" => "Section header",
-            "free_form_input_one_line" => "One line",
-            "free_form_input_paragraph" => "Paragraph",
-            "multiple_choice_radio" => "Multiple choice radio",
-            "multiple_choice_checkbox" => "Multiple choice checkbox",
-            "no_user_input" => "Informational-only"
-          }
-          type_options = type_order.map { |t| [ type_labels[t] || t.titleize.gsub("_", " "), t ] }
-        %>
-        <%= f.select :answer_type, type_options,
-              {},
-              class: "w-full rounded border-gray-300 shadow-sm px-2 py-1 text-sm" %>
-      </div>
-      <div class="col-span-2">
-        <label class="flex items-center gap-1 text-sm text-gray-600">
-          <%= f.check_box :is_required, class: "rounded border-gray-300 text-blue-600" %>
-          Required
-        </label>
-      </div>
-      <div class="col-span-2 text-right">
-        <%= link_to_remove_association "Remove", f,
-              class: "text-sm text-gray-400 hover:text-red-600 underline" %>
-      </div>
+    <div class="flex-1 flex flex-wrap items-center gap-2">
+      <%= f.select :visibility, visibility_options,
+            {},
+            class: "text-xs rounded-full border px-2 py-0.5 shrink-0 cursor-pointer",
+            data: { controller: "chip-select", chip_select_styles_value: visibility_styles, action: "change->chip-select#update" } %>
+      <%= f.text_field :question, class: "min-w-0 flex-[3_1_10rem] rounded border-gray-300 shadow-sm px-2 py-1 text-sm" %>
+      <%
+        type_order = %w[free_form_input_one_line free_form_input_paragraph multiple_choice_radio multiple_choice_checkbox no_user_input group_header]
+        type_labels = {
+          "group_header" => "Section header",
+          "free_form_input_one_line" => "One line",
+          "free_form_input_paragraph" => "Paragraph",
+          "multiple_choice_radio" => "Multiple choice radio",
+          "multiple_choice_checkbox" => "Multiple choice checkbox",
+          "no_user_input" => "Informational-only"
+        }
+        type_options = type_order.map { |t| [ type_labels[t] || t.titleize.gsub("_", " "), t ] }
+      %>
+      <%= f.select :answer_type, type_options,
+            {},
+            class: "flex-[2_1_11rem] rounded border-gray-300 shadow-sm px-2 py-1 text-sm" %>
+      <label class="flex items-center gap-1 text-sm text-gray-600 shrink-0">
+        <%= f.check_box :is_required, class: "rounded border-gray-300 text-blue-600" %>
+        Required
+      </label>
+      <label class="flex items-center gap-1 text-sm text-gray-600 shrink-0" title="Hide if already answered on any form (not just this event)">
+        <%= f.check_box :one_time, class: "rounded border-gray-300 text-amber-600" %>
+        One-time
+      </label>
+      <%= link_to_remove_association "Remove", f,
+            class: "text-sm text-gray-400 hover:text-red-600 underline shrink-0 ml-auto" %>
     </div>
   <% end %>
 </div>

app/views/forms/edit.html.erb

@@ -61,7 +61,7 @@
           </div>
           <div class="flex items-center gap-1.5">
             <span class="text-xs px-1.5 py-0.5 rounded-full bg-amber-100 text-amber-700">Answers on file</span>
-            <span class="text-xs text-gray-500">Hidden when info is already known</span>
+            <span class="text-xs text-gray-500">Hidden when answered on this event's forms; if "One-time", hidden when answered on any form</span>
           </div>
         </div>
       </div>
@@ -74,6 +74,8 @@
 
       <div class="px-6 py-3 border-t border-gray-100">
         <%= link_to_add_association "+ Add field", f, :form_fields,
+              data: { association_insertion_node: "[data-controller='form-fields-sortable']",
+                      association_insertion_method: "append" },
               class: "text-sm text-blue-600 hover:text-blue-800 font-medium" %>
       </div>
     </div>

db/migrate/20260309140000_add_one_time_to_form_fields.rb

@@ -0,0 +1,5 @@
+class AddOneTimeToFormFields < ActiveRecord::Migration[8.0]
+  def change
+    add_column :form_fields, :one_time, :boolean, default: false, null: false
+  end
+end

db/schema.rb

@@ -10,7 +10,7 @@
 #
 # It's strongly recommended that you check this file into your version control system.
 
-ActiveRecord::Schema[8.1].define(version: 2026_03_09_120000) do
+ActiveRecord::Schema[8.1].define(version: 2026_03_09_140000) do
   create_table "action_text_mentions", charset: "utf8mb4", collation: "utf8mb4_unicode_ci", force: :cascade do |t|
     t.bigint "action_text_rich_text_id", null: false
     t.datetime "created_at", null: false
@@ -530,6 +530,7 @@
     t.integer "form_id", null: false
     t.text "instructional_hint"
     t.boolean "is_required", default: true
+    t.boolean "one_time", default: false, null: false
     t.integer "parent_id"
     t.integer "position"
     t.string "question", null: false
@@ -628,6 +629,9 @@
     t.text "email_body_html"
     t.text "email_body_text"
     t.text "email_subject"
+    t.datetime "error_at"
+    t.string "error_class"
+    t.text "error_message"
     t.string "kind", null: false
     t.integer "noticeable_id"
     t.string "noticeable_type"
@@ -835,7 +839,7 @@
     t.string "type"
     t.datetime "updated_at", precision: nil, null: false
     t.integer "windows_type_id", null: false
-    t.integer "workshop_id", null: false
+    t.integer "workshop_id"
     t.string "workshop_name"
     t.index ["created_by_id"], name: "index_reports_on_created_by_id"
     t.index ["organization_id"], name: "index_reports_on_organization_id"