From 2364a9805f1161f24b787867953c14310d1434fe Mon Sep 17 00:00:00 2001 From: CY Chen Date: Tue, 10 Mar 2026 20:03:03 +0000 Subject: [PATCH] Remove ament_cmake_ros dependency The dependent ament_cmake_ros package transitively pulls in RMW-layer packages which is unnecessarily heavy to class_loader that is supposed to be an independent plugin loading library. This commit removes the ament_cmake_ros dependency and replaces with a plain ament_cmake with an explicit SHARED library type to keep the dependency minimal. Signed-off-by: CY Chen --- CMakeLists.txt | 5 ++--- package.xml | 1 - 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/CMakeLists.txt b/CMakeLists.txt index f670c39..0eafb86 100644 --- a/CMakeLists.txt +++ b/CMakeLists.txt @@ -14,9 +14,8 @@ endif() set(CLASS_LOADER_IGNORE_AMENT FALSE CACHE BOOL "Do not use ament when building this package.") if(NOT CLASS_LOADER_IGNORE_AMENT) - find_package(ament_cmake) - find_package(ament_cmake_ros REQUIRED) - set(explicit_library_type "") + find_package(ament_cmake REQUIRED) + set(explicit_library_type "SHARED") else() set(explicit_library_type "SHARED") endif() diff --git a/package.xml b/package.xml index af76e20..84f03db 100644 --- a/package.xml +++ b/package.xml @@ -23,7 +23,6 @@ libconsole-bridge-dev ament_cmake - ament_cmake_ros console_bridge_vendor libconsole-bridge-dev