SVG does not show

[AziocNEU]

Code of Conduct

• I agree to follow this project's Code of Conduct

Is there an existing issue for this?

• I have searched the existing issues

GLPI Version

11

Plugin version

1.9.0

Bug description

When I open the reports no matter which one I select the report name and data are displayed correctly, but the related chart is not shown.
It only displays the chart as a PNG image, but not as an SVG.

Relevant log output

Page URL

No response

Steps To reproduce

No response

Your GLPI setup information

No response

Anything else?

No response

[TxX8N8LN]

Same problem here with GLPI 11.0.1 and mreporting 1.9.0

[zekuraz]

Same problem here with GLPI 11.0.1 and mreporting 1.9.0

I have this error in console log SyntaxError: expected expression, got '&'

[stonebuzz]

hi @AziocNEU  @TxX8N8LN @zekuraz

can you try this -> glpi.INFO: *** Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated at common.class.php line 1021

Best regards

[AziocNEU]

hi @AziocNEU  @TxX8N8LN @zekuraz

can you try this -> glpi.INFO: *** Deprecated: htmlspecialchars(): Passing null to parameter #1 ($string) of type string is deprecated at common.class.php line 1021

Best regards

Where do you enter this ?

[stonebuzz]

sorry bad copy / past

can you try this -> #306

[zekuraz]

@stonebuzz i replace graph.class.php & with your fix and it's work for camembert , line and stacked bars graph

BUT, for Number of open tickets by category and type AND Number of open tickets by category and status, i have this error in the console

SyntaxError: missing ] after element list
    <anonymous> https://server.test.net/glpi/DSI/plugins/mreporting/lib/protovis/protovis.js?v=e59435c3e9be0c0ad69a58da407b1b8f6a63833b:365

I also notice that it's messing icon near the title

[stonebuzz]

Maybe a bad copy / paste ?

[zekuraz]

@stonebuzz I copied the files and did the same thing.

[stonebuzz]

I can't reproduce for now
Can you just apply this patch (en clear glpi cache)

diff --git a/inc/common.class.php b/inc/common.class.php
index e13e478e..3e5d7d24 100644
--- a/inc/common.class.php
+++ b/inc/common.class.php
@@ -1018,7 +1018,7 @@ public static function showGraphDatas(
                 echo "<tr class='tab_bg_1'>";
                 echo '<td>' . htmlspecialchars($label2) . '</td>';
                 if ($simpledatas) { //simple array
-                    echo "<td class='center'>" . htmlspecialchars($cols) . ' ' . htmlspecialchars($unit) . '</td>';
+                    echo "<td class='center'>" . htmlspecialchars($cols) . ' ' . htmlspecialchars($unit ?? '') . '</td>';
                 } else { //multiple array
                     foreach ($cols as $date => $nb) {
                         if (!is_array($nb)) {
diff --git a/inc/graph.class.php b/inc/graph.class.php
index 54a84e7a..fd23158d 100644
--- a/inc/graph.class.php
+++ b/inc/graph.class.php
@@ -105,7 +105,10 @@ public function initGraph($options)
 
         echo "<div class='graph' id='graph_content" . $randname . "'>";
 
-        $colors = htmlspecialchars("'" . implode("', '", PluginMreportingConfig::getColors()) . "'");
+
+        $colorsArray = PluginMreportingConfig::getColors();
+        $escapedColors = array_map(fn($color) => htmlspecialchars($color, ENT_QUOTES, 'UTF-8'), $colorsArray);
+        $colors = "'" . implode("', '", $escapedColors) . "'";
         echo "<script type='text/javascript+protovis'>
          showGraph$randname = function() {
             colors = pv.colors($colors);";
@@ -299,7 +302,7 @@ public function showHbar($params, $dashboard = false, $width = false)
 JAVASCRIPT;
 
         if ($show_graph) {
-            echo htmlspecialchars($JS);
+            echo $JS;
         }
 
         $opt['randname'] = $randname;
@@ -496,7 +499,7 @@ public function showPie($params, $dashboard = false, $width = false)
 JAVASCRIPT;
 
         if ($show_graph) {
-            echo htmlspecialchars($JS);
+            echo $JS;
         }
 
         $opt['randname'] = $randname;
@@ -776,7 +779,7 @@ function getLevelNbNode(node) {
 JAVASCRIPT;
 
         if ($show_graph) {
-            echo htmlspecialchars($JS);
+            echo $JS;
         }
 
         $opt['randname'] = $randname;
@@ -1008,7 +1011,7 @@ public function showHgbar($params, $dashboard = false, $width = false)
 JAVASCRIPT;
 
         if ($show_graph) {
-            echo htmlspecialchars($JS);
+            echo $JS;
         }
 
         $opt['randname'] = $randname;
@@ -1244,7 +1247,7 @@ public function showVstackbar($params, $dashboard = false, $width = false)
 JAVASCRIPT;
 
         if ($show_graph) {
-            echo htmlspecialchars($JS);
+            echo $JS;
         }
 
         $opt['randname'] = $randname;
@@ -1485,7 +1488,7 @@ public function showArea($params, $dashboard = false, $width = false)
 JAVASCRIPT;
 
         if ($show_graph) {
-            echo htmlspecialchars($JS);
+            echo $JS;
         }
 
         $opt['randname'] = $randname;
@@ -1765,7 +1768,7 @@ public function showGarea($params, $dashboard = false, $width = false)
 JAVASCRIPT;
 
         if ($show_graph) {
-            echo htmlspecialchars($JS);
+            echo $JS;
         }
 
         $opt['randname'] = $randname;

[TxX8N8LN]

@stonebuzz i replace graph.class.php & with your fix and it's work for camembert , line and stacked bars graph

BUT, for Number of open tickets by category and type AND Number of open tickets by category and status, i have this error in the console

SyntaxError: missing ] after element list
    <anonymous> https://server.test.net/glpi/DSI/plugins/mreporting/lib/protovis/protovis.js?v=e59435c3e9be0c0ad69a58da407b1b8f6a63833b:365

I also notice that it's messing icon near the title

Same return for me

[stonebuzz]

Which option (status/category) did you select on these two reports?
Could you please share some screenshots?

Kind regards,