[TECHNICAL] Resource leaks in fragment bindings

[joragua]

Currently, not all existing fragments are properly clearing their view bindings when the view is destroyed. This can lead to memory/resource leaks, especially in cases where the fragment lifecycle outlives its view lifecycle.

1. Identify fragments where bindings are not being cleared
2. Update those fragment using the following approach:

override fun onDestroyView() {
    super.onDestroyView()
    _binding = null
}

⚙️ Resources

• https://developer.android.com/topic/libraries/view-binding
• https://proandroiddev.com/avoiding-memory-leaks-when-using-data-binding-and-view-binding-3b91d571c150

Important

Don't forget to follow all comments described in the issue: branch name, defined approach...

TASKS

• Research (if needed)
• Create branch technical/binding_resource_leaks
• Development tasks
  • Set to null all bindings in onDestroyView() method
• Code review and apply changes requested
• Design test plan
• QA
• Merge branch technical/binding_resource_leaks into master

[corevibe555]

@joragua I would love to work on this.

Task 1. Research:
I found 10 fragments have _binding but never set it to null in onDestroyView(), causing memory leaks when the view is destroyed but the fragment instance survives.

Fragments That Need Fixing:

-----------------------------------
SpaceMembersFragment
SpacesListFragment
SetSpaceIconDialogFragment
CreateSpaceDialogFragment
AddMemberFragment
RemoveFilesDialogFragment
MainEmptyListFragment
CreateShortcutDialogFragment
FileDetailsFragment
1SharesFragment
----------------------

Each fragment needs an onDestroyView() override added:

override fun onDestroyView() {
super.onDestroyView()
_binding = null
}

[corevibe555]

Comment task follow up:
Branch name: technical/binding_resource_leaks
Set to null all bindings in onDestroyView() method: Done
Design Test plan:
Manual testing done, reached the fragments via manual testing:
SpaceMembersFragment Spaces → select a space → Members
SpacesListFragment Spaces tab
SetSpaceIconDialogFragment Spaces → edit space → set icon
CreateSpaceDialogFragment Spaces → create new space
AddMemberFragment Spaces → Members → Add member
RemoveFilesDialogFragment Select file(s) → Delete
MainEmptyListFragment Open an empty folder
CreateShortcutDialogFragment Create shortcut action
FileDetailsFragment Tap a file → file details
SharesFragment File details → Shares tab