ci: pass --define 'with_rustup 1' to all yum-builddep invocations#121
Merged
Conversation
Ensures yum-builddep respects the with_rustup conditional so Rust toolchain is consistently provided via rustup instead of yum, matching the rpmbuild flag already used in all targets.
|
@imlk0 ，您好，您的请求已接收，请耐心等待结果。 |
|
@imlk0 ，您好，未检测到有镜像需要构建，如需重新检测请评论 /start 。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--define 'with_rustup 1'to allyum-builddepcalls inMakefile,.github/workflows/test.yml, and.github/workflows/clippy.ymlyum-builddepwas invoked without this flag, causing Rust toolchain to be installed via yum despiterpmbuildalready using--define 'with_rustup 1'to select rustup. This inconsistency led to redundant system Rust packages being pulled in.