fix linting and static check

Signed-off-by: paul bochtler <65470117+datapumpernickel@users.noreply.github.com>

Author: datapumpernickel

lib/Service/SubmissionService.php

@@ -367,11 +367,10 @@ function (array $carry, Answer $answer) use ($questionPerQuestionId, $gridRowsPe
 						$carry[$questionId] = ['columns' => $columns];
 					} elseif ($questionType === Constants::ANSWER_TYPE_RANKING) {
 						$rankedIds = json_decode($answer->getText(), true);
-						// Build map: optionId -> rank position (1-based)
-						$rankByOptionId = array_flip($rankedIds);
 						$columns = [];
 						foreach ($rankingOptionsPerQuestionId[$questionId] as $optionId) {
-							$columns[] = isset($rankByOptionId[$optionId]) ? $rankByOptionId[$optionId] + 1 : '';
+							$position = array_search($optionId, $rankedIds);
+							$columns[] = $position !== false ? $position + 1 : '';
 						}
 						$carry[$questionId] = ['columns' => $columns];
 					} else {

src/components/Questions/QuestionRanking.vue

@@ -157,6 +157,7 @@ export default {
 			get() {
 				return this.sortOptionsOfType(this.options, OptionType.Choice)
 			},
+
 			set(value) {
 				this.updateOptionsOrder(value, OptionType.Choice)
 			},

src/components/Results/ResultsSummary.vue

@@ -13,33 +13,42 @@
 		</p>
 
 		<!-- Ranking questions: Borda count with average rank -->
-		<div
-			v-if="question.type === 'ranking'"
-			class="question-summary__statistic">
+		<div v-if="question.type === 'ranking'" class="question-summary__statistic">
 			<p class="question-summary__ranking-description">
-				{{ t('forms', 'Ranked by Borda count: each 1st place receives {n} points, 2nd place {n1} points, and so on. Higher score means more preferred.', { n: question.options.length, n1: question.options.length - 1 }) }}
+				{{
+					t(
+						'forms',
+						'Ranked by Borda count: each 1st place receives {n} points, 2nd place {n1} points, and so on. Higher score means more preferred.',
+						{
+							n: question.options.length,
+							n1: question.options.length - 1,
+						},
+					)
+				}}
 			</p>
 			<ol>
-			<li v-for="option in rankingStats" :key="option.id">
-				<label>
-					<span class="question-summary__statistic-score">
-						{{ option.bordaTotal }}
-					</span>
-					<span class="question-summary__statistic-percentage">
-						({{ t('forms', 'avg. rank {average}', { average: option.avgRank }) }}):
-					</span>
-					<span
-						:class="{
-							'question-summary__statistic-text--best': option.best,
-						}">
-						{{ option.text }}
-					</span>
-				</label>
-				<meter
-					min="0"
-					:max="maxBordaScore"
-					:value="option.bordaTotal" />
-			</li>
+				<li v-for="option in rankingStats" :key="option.id">
+					<label>
+						<span class="question-summary__statistic-score">
+							{{ option.bordaTotal }}
+						</span>
+						<span class="question-summary__statistic-percentage">
+							({{
+								t('forms', 'avg. rank {average}', {
+									average: option.avgRank,
+								})
+							}}):
+						</span>
+						<span
+							:class="{
+								'question-summary__statistic-text--best':
+									option.best,
+							}">
+							{{ option.text }}
+						</span>
+					</label>
+					<meter min="0" :max="maxBordaScore" :value="option.bordaTotal" />
+				</li>
 			</ol>
 		</div>
 
@@ -362,10 +371,7 @@ export default {
 			const result = Object.values(stats)
 				.map((s) => ({
 					...s,
-					avgRank:
-						s.count > 0
-							? (s.rankSum / s.count).toFixed(1)
-							: '-',
+					avgRank: s.count > 0 ? (s.rankSum / s.count).toFixed(1) : '-',
 				}))
 				.sort((a, b) => b.bordaTotal - a.bordaTotal)