refactor: remove command with only deprectated subcommands

As all subcommands are deprecated we will simply remove this command.

Author: christeredvartsen

internal/aiven/aiven_services/kafka.go

@@ -1,21 +1,11 @@
 package aiven_services
 
 import (
-	"fmt"
-	"strings"
-
 	aiven_nais_io_v1 "github.com/nais/liberator/pkg/apis/aiven.nais.io/v1"
 )
 
 type KafkaPool string
 
-func KafkaPoolFromString(pool string) (KafkaPool, error) {
-	if !strings.Contains(pool, "-") {
-		return "", fmt.Errorf("invalid pool: %v", pool)
-	}
-	return KafkaPool(pool), nil
-}
-
 func (p KafkaPool) String() string {
 	return string(p)
 }

internal/aiven/aiven_services/opensearch.go

@@ -2,37 +2,14 @@ package aiven_services
 
 import (
 	"fmt"
-	"strings"
 
 	aiven_nais_io_v1 "github.com/nais/liberator/pkg/apis/aiven.nais.io/v1"
 )
 
 type OpenSearchAccess int64
 
-const (
-	Read OpenSearchAccess = iota
-	Write
-	ReadWrite
-	Admin
-)
-
 var OpenSearchAccesses = []string{"read", "write", "readwrite", "admin"}
 
-func OpenSearchAccessFromString(access string) (OpenSearchAccess, error) {
-	switch strings.ToLower(access) {
-	case OpenSearchAccesses[0]:
-		return Read, nil
-	case OpenSearchAccesses[1]:
-		return Write, nil
-	case OpenSearchAccesses[2]:
-		return ReadWrite, nil
-	case OpenSearchAccesses[3]:
-		return Admin, nil
-	default:
-		return -1, fmt.Errorf("unknown access: %v", access)
-	}
-}
-
 func (p OpenSearchAccess) String() string {
 	return OpenSearchAccesses[p]
 }

internal/aiven/command/aiven.go

@@ -19,7 +19,6 @@ func Aiven(parentFlags *flags.GlobalFlags) *naistrix.Command {
 		Description: "Commands for creating, retrieving, and granting access to Aiven-managed services such as Kafka and OpenSearch.",
 		StickyFlags: aivenFlags,
 		SubCommands: []*naistrix.Command{
-			create(aivenFlags),
 			get(aivenFlags),
 			tidy(aivenFlags),
 			grantAccess(aivenFlags),

internal/aiven/command/create.go

@@ -5,12 +5,10 @@ import (
 	"errors"
 	"fmt"
 	"os"
-	"strings"
 
 	"github.com/nais/cli/internal/aiven/aiven_config"
 	"github.com/nais/cli/internal/aiven/aiven_services"
 	"github.com/nais/cli/internal/k8s"
-	"github.com/nais/liberator/pkg/namegen"
 	"github.com/nais/naistrix"
 	v1 "k8s.io/api/core/v1"
 	ctrl "sigs.k8s.io/controller-runtime/pkg/client"
@@ -128,10 +126,3 @@ func createDefaultDestination() (string, error) {
 
 	return newPath, nil
 }
-
-func CreateSecretName(username, namespace string) (string, error) {
-	return namegen.ShortName(
-		fmt.Sprintf("%s-%s", username, strings.ReplaceAll(namespace, ".", "-")),
-		64,
-	)
-}