Skip to content

Commit c4dc8cb

Browse files
committed
BLAS change for Apple Silicon
Revert to the "accelerate" BLAS for Apple Silicon, regardless of macOS version, as performance issues have been identified with the "newaccelerate" BLAS under the Vecchia approximation.
1 parent 0147230 commit c4dc8cb

2 files changed

Lines changed: 7 additions & 6 deletions

File tree

NEWS.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,7 @@
55
- Resolved compatibility issues when importing emulator objects saved from older releases.
66
- Fixed a bug in `gp()` and `dgp()` affecting MAP estimation when `prior = "inv_ga"`.
77
- Added support for MAP estimation with no prior in `gp()` and `dgp()` by setting `prior = NULL`.
8+
- Reverted to the `accelerate` BLAS on Apple Silicon (for all macOS versions) due to performance issues observed with the `newaccelerate` BLAS using the Vecchia approximation.
89

910
# dgpsi 2.6.0
1011
- Prediction speed with `predict()` enhanced for small testing data sets by reducing overhead caused by the multi-threading implementation.

R/initi_py.R

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -213,13 +213,13 @@ install_dgpsi <- function(env_name, py_ver, conda_path, dgpsi_ver, reinsatll = F
213213
macos_version <- system("sw_vers -productVersion", intern = TRUE)
214214
version_nums <- as.numeric(strsplit(macos_version, "\\.")[[1]])
215215
current_version <- version_nums[1] + version_nums[2] / 10
216-
if (current_version>=13.3){
217-
if (!reinsatll) reticulate::conda_create(envname = env_name, packages = c(dgpsi_ver, '"libblas=*=*newaccelerate"'),
216+
#if (current_version>=13.3){
217+
# if (!reinsatll) reticulate::conda_create(envname = env_name, packages = c(dgpsi_ver, '"libblas=*=*newaccelerate"'),
218+
# python_version = py_ver, conda = conda_path, forge = TRUE, additional_create_args = c('--strict-channel-priority'))
219+
#} else {
220+
if (!reinsatll) reticulate::conda_create(envname = env_name, packages = c(dgpsi_ver, '"libblas=*=*_accelerate"'),
218221
python_version = py_ver, conda = conda_path, forge = TRUE, additional_create_args = c('--strict-channel-priority'))
219-
} else {
220-
if (!reinsatll) reticulate::conda_create(envname = env_name, packages = c(dgpsi_ver, '"libblas=*=*accelerate"'),
221-
python_version = py_ver, conda = conda_path, forge = TRUE, additional_create_args = c('--strict-channel-priority'))
222-
}
222+
#}
223223
} else if ( isTRUE(grepl("Intel",benchmarkme::get_cpu()$model_name)) ){
224224
if (Sys.info()[["sysname"]] %in% c("Windows", "Linux")) dgpsi_ver <- c(dgpsi_ver, 'intel-cmplr-lib-rt')
225225
if (!reinsatll) reticulate::conda_create(envname = env_name, packages = c(dgpsi_ver, '"libblas=*=*mkl"', 'mkl>=2022'),

0 commit comments

Comments
 (0)