-
Notifications
You must be signed in to change notification settings - Fork 741
Expand file tree
/
Copy pathstateManager.test.ts
More file actions
308 lines (267 loc) · 11.3 KB
/
stateManager.test.ts
File metadata and controls
308 lines (267 loc) · 11.3 KB
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
/*---------------------------------------------------------------------------------------------
* Copyright (c) Microsoft Corporation. All rights reserved.
* Licensed under the MIT License. See License.txt in the project root for license information.
*--------------------------------------------------------------------------------------------*/
import { default as assert } from 'assert';
import * as vscode from 'vscode';
import { StateManager } from '../../issues/stateManager';
import { CurrentIssue } from '../../issues/currentIssue';
import { USE_BRANCH_FOR_ISSUES, ISSUES_SETTINGS_NAMESPACE } from '../../common/settingKeys';
// Mock classes for testing
class MockFolderRepositoryManager {
constructor(public repository: { rootUri: vscode.Uri }) { }
}
class MockSingleRepoState {
currentIssue?: MockCurrentIssue;
constructor(public folderManager: MockFolderRepositoryManager) { }
}
class MockCurrentIssue {
stopWorkingCalled = false;
stopWorkingCheckoutFlag = false;
issue = { number: 123 };
async stopWorking(checkoutDefaultBranch: boolean) {
this.stopWorkingCalled = true;
this.stopWorkingCheckoutFlag = checkoutDefaultBranch;
}
}
describe('StateManager branch behavior with useBranchForIssues setting', function () {
let stateManager: StateManager;
let mockContext: vscode.ExtensionContext;
beforeEach(() => {
mockContext = {
workspaceState: {
get: () => undefined,
update: () => Promise.resolve(),
},
subscriptions: [],
} as any;
stateManager = new StateManager(undefined as any, undefined as any, mockContext);
(stateManager as any)._singleRepoStates = new Map();
});
it('should not checkout default branch when useBranchForIssues is off', async function () {
// Mock workspace configuration to return 'off'
const originalGetConfiguration = vscode.workspace.getConfiguration;
vscode.workspace.getConfiguration = (section?: string) => {
if (section === ISSUES_SETTINGS_NAMESPACE) {
return {
get: (key: string) => {
if (key === USE_BRANCH_FOR_ISSUES) {
return 'off';
}
return undefined;
},
} as any;
}
return originalGetConfiguration(section);
};
try {
// Set up test state
const mockUri = vscode.Uri.parse('file:///test');
const mockFolderManager = new MockFolderRepositoryManager({ rootUri: mockUri });
const mockState = new MockSingleRepoState(mockFolderManager);
const mockCurrentIssue = new MockCurrentIssue();
mockState.currentIssue = mockCurrentIssue;
(stateManager as any)._singleRepoStates.set(mockUri.path, mockState);
// Call setCurrentIssue with checkoutDefaultBranch = true
await stateManager.setCurrentIssue(mockState as any, undefined, true, true);
// Verify that stopWorking was called with false (not the original true)
assert.strictEqual(mockCurrentIssue.stopWorkingCalled, true, 'stopWorking should have been called');
assert.strictEqual(mockCurrentIssue.stopWorkingCheckoutFlag, false, 'stopWorking should have been called with checkoutDefaultBranch=false when useBranchForIssues is off');
} finally {
// Restore original configuration
vscode.workspace.getConfiguration = originalGetConfiguration;
}
});
it('should checkout default branch when useBranchForIssues is not off', async function () {
// Mock workspace configuration to return 'on'
const originalGetConfiguration = vscode.workspace.getConfiguration;
vscode.workspace.getConfiguration = (section?: string) => {
if (section === ISSUES_SETTINGS_NAMESPACE) {
return {
get: (key: string) => {
if (key === USE_BRANCH_FOR_ISSUES) {
return 'on';
}
return undefined;
},
} as any;
}
return originalGetConfiguration(section);
};
try {
// Set up test state
const mockUri = vscode.Uri.parse('file:///test');
const mockFolderManager = new MockFolderRepositoryManager({ rootUri: mockUri });
const mockState = new MockSingleRepoState(mockFolderManager);
const mockCurrentIssue = new MockCurrentIssue();
mockState.currentIssue = mockCurrentIssue;
(stateManager as any)._singleRepoStates.set(mockUri.path, mockState);
// Call setCurrentIssue with checkoutDefaultBranch = true
await stateManager.setCurrentIssue(mockState as any, undefined, true, true);
// Verify that stopWorking was called with true (preserving the original value)
assert.strictEqual(mockCurrentIssue.stopWorkingCalled, true, 'stopWorking should have been called');
assert.strictEqual(mockCurrentIssue.stopWorkingCheckoutFlag, true, 'stopWorking should have been called with checkoutDefaultBranch=true when useBranchForIssues is on');
} finally {
// Restore original configuration
vscode.workspace.getConfiguration = originalGetConfiguration;
}
});
it('should trim whitespace from query strings', async function () {
const mockUri = vscode.Uri.parse('file:///test');
const mockFolderManager = {
repository: { rootUri: mockUri, state: { HEAD: { commit: 'abc123' }, remotes: [] } },
getIssues: async (query: string) => {
// Verify that the query doesn't have trailing whitespace
assert.strictEqual(query, query.trim(), 'Query should be trimmed');
assert.strictEqual(query.endsWith(' '), false, 'Query should not end with whitespace');
return { items: [], hasMorePages: false, hasUnsearchedRepositories: false, totalCount: 0 };
},
getMaxIssue: async () => 0,
};
// Mock workspace configuration with query that has trailing space
const originalGetConfiguration = vscode.workspace.getConfiguration;
vscode.workspace.getConfiguration = (section?: string) => {
if (section === ISSUES_SETTINGS_NAMESPACE) {
return {
get: (key: string, defaultValue?: any) => {
if (key === 'queries') {
return [{ label: 'Test', query: 'is:open assignee:@me repo:owner/repo ', groupBy: [] }];
}
return defaultValue;
},
} as any;
}
return originalGetConfiguration(section);
};
try {
// Initialize the state manager with a query that has trailing space
const stateManager = new StateManager(undefined as any, {
folderManagers: [mockFolderManager],
credentialStore: { isAnyAuthenticated: () => true, getCurrentUser: async () => ({ login: 'testuser' }) },
} as any, mockContext);
// Manually trigger the setIssueData flow
await (stateManager as any).setIssueData(mockFolderManager);
// If we get here without assertion failures in getIssues, the test passed
} finally {
vscode.workspace.getConfiguration = originalGetConfiguration;
}
});
it('should fire onDidChangeIssueData even when getIssues throws', async function () {
const mockUri = vscode.Uri.parse('file:///test');
const mockFolderManager = {
repository: { rootUri: mockUri, state: { HEAD: { commit: 'abc123' }, remotes: [] } },
getIssues: async () => {
throw new Error('Network error');
},
getMaxIssue: async () => 0,
};
const originalGetConfiguration = vscode.workspace.getConfiguration;
vscode.workspace.getConfiguration = (section?: string) => {
if (section === ISSUES_SETTINGS_NAMESPACE) {
return {
get: (key: string, defaultValue?: any) => {
if (key === 'queries') {
return [{ label: 'Test', query: 'is:open assignee:@me repo:owner/repo', groupBy: [] }];
}
return defaultValue;
},
} as any;
}
return originalGetConfiguration(section);
};
try {
const sm = new StateManager(undefined as any, {
folderManagers: [mockFolderManager],
credentialStore: { isAnyAuthenticated: () => true, getCurrentUser: async () => ({ login: 'testuser' }) },
} as any, mockContext);
let changeEventCount = 0;
sm.onDidChangeIssueData(() => changeEventCount++);
await (sm as any).setIssueData(mockFolderManager);
// The event should have fired even though getIssues threw
assert.ok(changeEventCount > 0, 'onDidChangeIssueData should fire even when getIssues fails');
// The promise in the collection should resolve to undefined issues (not reject)
const collection = sm.getIssueCollection(mockUri);
const queryResult = await collection.get('Test');
assert.strictEqual(queryResult?.issues, undefined, 'Issues should be undefined when getIssues fails');
} finally {
vscode.workspace.getConfiguration = originalGetConfiguration;
}
});
it('should fire onDidChangeIssueData after setIssueData completes', async function () {
const mockUri = vscode.Uri.parse('file:///test');
const mockFolderManager = {
repository: { rootUri: mockUri, state: { HEAD: { commit: 'abc123' }, remotes: [] } },
getIssues: async () => {
return { items: [], hasMorePages: false, hasUnsearchedRepositories: false, totalCount: 0 };
},
getMaxIssue: async () => 0,
};
const originalGetConfiguration = vscode.workspace.getConfiguration;
vscode.workspace.getConfiguration = (section?: string) => {
if (section === ISSUES_SETTINGS_NAMESPACE) {
return {
get: (key: string, defaultValue?: any) => {
if (key === 'queries') {
return [{ label: 'Test', query: 'is:open assignee:@me repo:owner/repo', groupBy: [] }];
}
return defaultValue;
},
} as any;
}
return originalGetConfiguration(section);
};
try {
const sm = new StateManager(undefined as any, {
folderManagers: [mockFolderManager],
credentialStore: { isAnyAuthenticated: () => true, getCurrentUser: async () => ({ login: 'testuser' }) },
} as any, mockContext);
let changeEventCount = 0;
sm.onDidChangeIssueData(() => changeEventCount++);
await (sm as any).setIssueData(mockFolderManager);
// The event should fire at least twice: once from setIssues (per-query) and once from setIssueData (final)
assert.strictEqual(changeEventCount, 2, `onDidChangeIssueData should fire exactly twice for a single query, but fired ${changeEventCount} times`);
} finally {
vscode.workspace.getConfiguration = originalGetConfiguration;
}
});
it('should not reject promises in issueCollection when getIssues throws', async function () {
const mockUri = vscode.Uri.parse('file:///test');
const mockFolderManager = {
repository: { rootUri: mockUri, state: { HEAD: { commit: 'abc123' }, remotes: [] } },
getIssues: async () => {
throw new Error('API error');
},
getMaxIssue: async () => 0,
};
const originalGetConfiguration = vscode.workspace.getConfiguration;
vscode.workspace.getConfiguration = (section?: string) => {
if (section === ISSUES_SETTINGS_NAMESPACE) {
return {
get: (key: string, defaultValue?: any) => {
if (key === 'queries') {
return [{ label: 'Test', query: 'is:open repo:owner/repo', groupBy: [] }];
}
return defaultValue;
},
} as any;
}
return originalGetConfiguration(section);
};
try {
const sm = new StateManager(undefined as any, {
folderManagers: [mockFolderManager],
credentialStore: { isAnyAuthenticated: () => true, getCurrentUser: async () => ({ login: 'testuser' }) },
} as any, mockContext);
await (sm as any).setIssueData(mockFolderManager);
// Verify that the promises in issueCollection resolve (not reject)
const collection = sm.getIssueCollection(mockUri);
for (const [, promise] of collection) {
const result = await promise;
assert.ok(result !== undefined, 'Promise should resolve, not reject');
assert.strictEqual(result.issues, undefined, 'Issues should be undefined on error');
}
} finally {
vscode.workspace.getConfiguration = originalGetConfiguration;
}
});
});