Merge pull request #2335 from microsoft/connor4312/revert-bad-tas

connor4312 · web-flow · commit 024ac071bb31 · 2026-03-23T14:54:03.000-07:00
Revert "chore: update tas-client for proper disposal (#2332)"
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -80,7 +80,7 @@
     "signale": "^1.4.0",
     "source-map-support": "^0.5.21",
     "to-absolute-glob": "^3.0.0",
-    "vscode-tas-client": "^0.1.86",
+    "vscode-tas-client": "^0.1.84",
     "ws": "^8.17.1"
   },
   "devDependencies": {
diff --git a/src/telemetry/vscodeExperimentationService.ts b/src/telemetry/vscodeExperimentationService.ts
@@ -52,7 +52,10 @@ export class VSCodeExperimentationService implements IJsDebugExpService, IDispos
   }
 
   dispose(): void {
-    this.service?.dispose();
+    // See microsoft/tas-client#74
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    const polling = (this.service as any)?.pollingService;
+    polling?.StopPolling();
   }
 
   /**

Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,10 @@ export class VSCodeExperimentationService implements IJsDebugExpService, IDispos`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`dispose(): void {`
`55`		`- this.service?.dispose();`
	`55`	`+ // See microsoft/tas-client#74`
	`56`	`+ // eslint-disable-next-line @typescript-eslint/no-explicit-any`
	`57`	`+ const polling = (this.service as any)?.pollingService;`
	`58`	`+ polling?.StopPolling();`
`56`	`59`	`}`
`57`	`60`
`58`	`61`	`/**`