Skip to content

Commit 55e157a

Browse files
authored
Use --all-targets for the no-default-features CI run. (#874)
Slightly more coverage. This basically makes sure that tests still compile in isolation that the workspace level tests mask with feature unification.
1 parent 0ced23d commit 55e157a

2 files changed

Lines changed: 3 additions & 2 deletions

File tree

.github/workflows/ci.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ jobs:
157157
for crate in "${crates[@]}"; do
158158
cargo clippy --locked --package "$crate" \
159159
--no-default-features \
160+
--all-targets \
160161
--profile ci \
161162
--no-deps \
162163
--config "$RUST_CONFIG" \

diskann-benchmark-core/src/lib.rs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -60,10 +60,10 @@ pub mod streaming;
6060
/// If error message change, the expected results can generally be regenerated by running
6161
/// the test suite with the environment variable
6262
/// ```text
63-
/// DISKANN_BENCHMARK_TEST=true
63+
/// DISKANN_BENCHMARK_TEST=overwrite
6464
/// ```
6565
/// set.
66-
#[cfg(test)]
66+
#[cfg(all(test, feature = "bigann"))]
6767
mod ux {
6868
const ENV_VAR: &str = "DISKANN_BENCHMARK_TEST";
6969

0 commit comments

Comments
 (0)