Skip to content

Commit b178e05

Browse files
bugjoshclaude
authored andcommitted
wifi-scripts: fix ucode erp_domain and fils_cache_id values
The ucode path generates different erp_domain and fils_cache_id values than the legacy shell path due to three mismatches: 1. erp_domain md5 input missing trailing newline (echo adds \n) 2. erp_domain output truncated to 4 chars instead of 8 (shell uses head -c 8) 3. fils_cache_id md5 input missing trailing newline 4. erp_domain missing fallback to mobility_domain Same bug pattern as mobility_domain fixed in commit b1dc273. Fixes: #21768 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> Signed-off-by: Joshua Klinesmith <joshuaklinesmith@gmail.com> Link: openwrt/openwrt#22677 Signed-off-by: Hauke Mehrtens <hauke@hauke-m.de>
1 parent dc597ee commit b178e05

1 file changed

Lines changed: 3 additions & 2 deletions

File tree

  • package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi

package/network/config/wifi-scripts/files-ucode/usr/share/ucode/wifi/ap.uc

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -159,10 +159,11 @@ function iface_auth_type(config) {
159159
config.vlan_possible = 1;
160160

161161
if (config.fils) {
162-
set_default(config, 'erp_domain', substr(md5(config.ssid), 0, 4));
162+
set_default(config, 'erp_domain', config.mobility_domain);
163+
set_default(config, 'erp_domain', substr(md5(config.ssid + '\n'), 0, 8));
163164
set_default(config, 'fils_realm', config.erp_domain);
164165
set_default(config, 'erp_send_reauth_start', 1);
165-
set_default(config, 'fils_cache_id', substr(md5(config.fils_realm), 0, 4));
166+
set_default(config, 'fils_cache_id', substr(md5(config.fils_realm + '\n'), 0, 4));
166167
}
167168

168169
if (!config.eap_server) {

0 commit comments

Comments
 (0)