feat: prevent infinite looping when a failing relay processes failures#5
Merged
Conversation
krogrammer
changed the title
krogrammer
force-pushed
the
failure-loop
branch
2 times, most recently
from
037069f to
29c61eb
Compare
ccrowell-kr
approved these changes
May 11, 2026
|
🎉 This PR is included in version 1.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a Relay interested in Failures is broken and throws exceptions during processing, StandardTelemeter will record a Failure event that will eventually come back through the pipeline to that broken Relay, leading to an infinite loop of Failure events being processed and recorded.
This prevents that situation by having StandardTelemeter apply a RelayFailure facet to the failure events recorded when a Relay fails. Relays will not be allowed to process any RelayFailure that they are a cause of.
This PR also contains an update to the pre-commit hook. Now it will run the Kotlinter Gradle task, instead of relying on a locally installed Ktlint (where the version may not match).