Apply php-cs-fixer and add Events to phpunit exclusions

Author: binaryfire

phpunit.xml.dist

@@ -13,6 +13,7 @@
     <testsuites>
         <testsuite name="Hypervel Packages Test Suite">
             <directory suffix="Test.php">./tests</directory>
+            <exclude>./tests/Events</exclude>
             <exclude>./tests/Prompts</exclude>
             <exclude>./tests/Sentry</exclude>
             <exclude>./tests/Horizon</exclude>

src/bus/src/Queueable.php

@@ -38,9 +38,9 @@ trait Queueable
     /**
      * The job deduplicator callback the job should use to generate the deduplication ID.
      *
-     * @var \Laravel\SerializableClosure\SerializableClosure|null
+     * @var null|\Laravel\SerializableClosure\SerializableClosure
      */
-    public $deduplicator = null;
+    public $deduplicator;
 
     /**
      * The number of seconds before the job should be made available.

src/contracts/src/Events/ShouldDispatchAfterCommit.php

@@ -6,5 +6,4 @@
 
 interface ShouldDispatchAfterCommit
 {
-    //
 }

src/contracts/src/Events/ShouldHandleEventsAfterCommit.php

@@ -6,5 +6,4 @@
 
 interface ShouldHandleEventsAfterCommit
 {
-    //
 }

src/events/src/CallQueuedListener.php

@@ -96,9 +96,9 @@ class CallQueuedListener implements ShouldQueue
     /**
      * Create a new job instance.
      *
-     * @param  class-string  $class
-     * @param  string  $method
-     * @param  array  $data
+     * @param class-string $class
+     * @param string $method
+     * @param array $data
      */
     public function __construct($class, $method, $data)
     {
@@ -115,7 +115,8 @@ public function handle(Container $container): void
         $this->prepareData();
 
         $handler = $this->setJobInstanceIfNecessary(
-            $this->job, $container->make($this->class)
+            $this->job,
+            $container->make($this->class)
         );
 
         $handler->{$this->method}(...array_values($this->data));

src/events/src/Dispatcher.php

@@ -40,7 +40,7 @@ class Dispatcher implements DispatcherContract
     /**
      * The registered event listeners.
      *
-     * @var array<string, array<callable|array|class-string|null>>
+     * @var array<string, array<null|array|callable|class-string>>
      */
     protected array $listeners = [];
 
@@ -61,16 +61,16 @@ class Dispatcher implements DispatcherContract
     /**
      * The queue resolver instance.
      *
-     * @var (callable(): mixed)|null
+     * @var null|(callable(): mixed)
      */
-    protected $queueResolver = null;
+    protected $queueResolver;
 
     /**
      * The database transaction manager resolver instance.
      *
-     * @var (callable(): mixed)|null
+     * @var null|(callable(): mixed)
      */
-    protected $transactionManagerResolver = null;
+    protected $transactionManagerResolver;
 
     /**
      * The currently deferred events.
@@ -85,7 +85,7 @@ class Dispatcher implements DispatcherContract
     /**
      * The specific events to defer (null means defer all events).
      *
-     * @var string[]|null
+     * @var null|string[]
      */
     protected ?array $eventsToDefer = null;
 
@@ -148,9 +148,9 @@ protected function setupWildcardListen(string $event, Closure|string|array $list
      */
     public function hasListeners(string $eventName): bool
     {
-        return isset($this->listeners[$eventName]) ||
-               isset($this->wildcards[$eventName]) ||
-               $this->hasWildcardListeners($eventName);
+        return isset($this->listeners[$eventName])
+               || isset($this->wildcards[$eventName])
+               || $this->hasWildcardListeners($eventName);
     }
 
     /**
@@ -251,9 +251,9 @@ public function dispatch(string|object $event, mixed $payload = [], bool $halt =
         // If the event is not intended to be dispatched unless the current database
         // transaction is successful, we'll register a callback which will handle
         // dispatching this event on the next successful DB transaction commit.
-        if ($isEventObject &&
-            $parsedPayload[0] instanceof ShouldDispatchAfterCommit &&
-            ! is_null($transactions = $this->resolveTransactionManager())) {
+        if ($isEventObject
+            && $parsedPayload[0] instanceof ShouldDispatchAfterCommit
+            && ! is_null($transactions = $this->resolveTransactionManager())) {
             $transactions->addCallback(
                 fn () => $this->invokeListeners($parsedEvent, $parsedPayload, $halt)
             );
@@ -317,9 +317,9 @@ protected function parseEventAndPayload(mixed $event, mixed $payload): array
      */
     protected function shouldBroadcast(array $payload): bool
     {
-        return isset($payload[0]) &&
-               $payload[0] instanceof ShouldBroadcast &&
-               $this->broadcastWhen($payload[0]);
+        return isset($payload[0])
+               && $payload[0] instanceof ShouldBroadcast
+               && $this->broadcastWhen($payload[0]);
     }
 
     /**
@@ -516,9 +516,9 @@ protected function createQueuedHandlerCallable(string $class, string $method): C
      */
     protected function handlerShouldBeDispatchedAfterDatabaseTransactions(mixed $listener): bool
     {
-        return (($listener->afterCommit ?? null) ||
-                $listener instanceof ShouldHandleEventsAfterCommit) &&
-                $this->resolveTransactionManager();
+        return (($listener->afterCommit ?? null)
+                || $listener instanceof ShouldHandleEventsAfterCommit)
+                && $this->resolveTransactionManager();
     }
 
     /**
@@ -531,7 +531,7 @@ protected function createCallbackForListenerRunningAfterCommits(mixed $listener,
 
             $this->resolveTransactionManager()->addCallback(
                 function () use ($listener, $method, $payload) {
-                    $listener->$method(...$payload);
+                    $listener->{$method}(...$payload);
                 }
             );
         };
@@ -600,7 +600,8 @@ protected function createListenerAndJob(string $class, string $method, array $ar
         $listener = (new ReflectionClass($class))->newInstanceWithoutConstructor();
 
         return [$listener, $this->propagateListenerOptions(
-            $listener, new CallQueuedListener($class, $method, $arguments)
+            $listener,
+            new CallQueuedListener($class, $method, $arguments)
         )];
     }
 
@@ -627,7 +628,8 @@ protected function propagateListenerOptions(mixed $listener, CallQueuedListener
             $job->deleteWhenMissingModels = $listener->deleteWhenMissingModels ?? false;
             $job->tries = method_exists($listener, 'tries') ? $listener->tries(...$data) : ($listener->tries ?? null);
             $job->messageGroup = method_exists($listener, 'messageGroup') ? $listener->messageGroup(...$data) : ($listener->messageGroup ?? null);
-            $job->withDeduplicator(method_exists($listener, 'deduplicator')
+            $job->withDeduplicator(
+                method_exists($listener, 'deduplicator')
                 ? $listener->deduplicator(...$data)
                 : (method_exists($listener, 'deduplicationId') ? $listener->deduplicationId(...) : null)
             );
@@ -713,7 +715,7 @@ public function setTransactionManagerResolver(callable $resolver): static
      * @template TResult
      *
      * @param callable(): TResult $callback
-     * @param string[]|null $events
+     * @param null|string[] $events
      * @return TResult
      */
     public function defer(callable $callback, ?array $events = null): mixed
@@ -731,7 +733,7 @@ public function defer(callable $callback, ?array $events = null): mixed
 
             $this->deferringEvents = false;
 
-            /** @phpstan-ignore foreach.emptyArray (callback may add deferred events) */
+            /* @phpstan-ignore foreach.emptyArray (callback may add deferred events) */
             foreach ($this->deferredEvents as $args) {
                 $this->dispatch(...$args);
             }

src/events/src/NullDispatcher.php

@@ -30,15 +30,13 @@ public function __construct(DispatcherContract $dispatcher)
      */
     public function dispatch(string|object $event, mixed $payload = [], bool $halt = false): void
     {
-        //
     }
 
     /**
      * Don't register an event and payload to be fired later.
      */
     public function push(string $event, array $payload = []): void
     {
-        //
     }
 
     /**

src/queue/src/QueueRoutes.php

@@ -9,7 +9,7 @@ class QueueRoutes
     /**
      * The mapping of class names to their default routes.
      *
-     * @var array<class-string, string|array{string|null, string|null}>
+     * @var array<class-string, array{null|string, null|string}|string>
      */
     protected array $routes = [];
 
@@ -48,7 +48,7 @@ public function getQueue(object $queueable): ?string
     /**
      * Get the route for a given queueable instance.
      *
-     * @return string|array{string|null, string|null}|null
+     * @return null|array{null|string, null|string}|string
      */
     public function getRoute(object $queueable): string|array|null
     {
@@ -75,7 +75,7 @@ class_uses_recursive($queueable)
     /**
      * Register the queue route for the given class.
      *
-     * @param array<class-string, string|array{string|null, string|null}>|class-string $class
+     * @param array<class-string, array{null|string, null|string}|string>|class-string $class
      */
     public function set(array|string $class, ?string $queue = null, ?string $connection = null): void
     {
@@ -89,7 +89,7 @@ public function set(array|string $class, ?string $queue = null, ?string $connect
     /**
      * Get all registered queue routes.
      *
-     * @return array<class-string, string|array{string|null, string|null}>
+     * @return array<class-string, array{null|string, null|string}|string>
      */
     public function all(): array
     {

tests/Integration/Database/Laravel/EloquentAggregateTest.php

@@ -92,6 +92,10 @@ public function testNumericAggregate()
     }
 }
 
+/**
+ * @internal
+ * @coversNothing
+ */
 class UserAggregateTest extends Model
 {
     protected ?string $table = 'users';