Ambiguous check of running instances

[js-timbirkett]

eks-rolling-update/eksrollup/lib/aws.py

Lines 112 to 126 in 70306ef

	if len(actual_instances) != desired_capacity:
	logger.info('Asg {} does not have enough running instances to proceed'.format(asg_name))
	logger.info('Actual instances: {} Desired instances: {}'.format(
	len(actual_instances),
	desired_capacity)
	)
	is_scaled = False
	else:
	logger.info('Asg {} scaled OK'.format(asg_name))
	logger.info('Actual instances: {} Desired instances: {}'.format(
	len(actual_instances),
	desired_capacity)
	)
	is_scaled = True
	return is_scaled

Causes a failure to run when you have more running instances than desired:

00:04:19.030  2022-01-25 16:24:43,568 INFO     Checking asg golf-dev-mgmt-worker-node-0-20191108085402700900000002 instance count...
00:04:19.030  2022-01-25 16:24:43,701 INFO     Asg golf-dev-mgmt-worker-node-0-20191108085402700900000002 does not have enough running instances to proceed
00:04:19.030  2022-01-25 16:24:43,701 INFO     Actual instances: 7 Desired instances: 6

[crosbymichael1]

Im curious how did you get in the scenario where you have more instances than desired? The change is easy enough to make but Im concerned if saying throw an error only if actual instances is less than desired capacity because 1 maybe the scaling is not working properly and 2 maybe there is left over cordoned instances that have not yet been removing being considered.

Also the description of the function does say matches

"""
Checks that the number of EC2 instances in an ASG matches desired capacity
"""