feat: better handling of server installation path

The plugin should not assume its folder is writable. Instead, try to
search for a writable folder by checking the data folder and the runtime
paths. Also allows the user to give the path to the server's executable
intead of always compiling it. All of this makes the plugin friendlier
to restricted/read-only environments, like nix.

Author: acristoffers

doc/gitlab.nvim.txt

@@ -27,7 +27,6 @@ Table of Contents                              *gitlab.nvim.table-of-contents*
   - Troubleshooting                              |gitlab.nvim.troubleshooting|
   - Api                                                      |gitlab.nvim.api|
 
-
 OVERVIEW                                                *gitlab.nvim.overview*
 
 This Neovim plugin is designed to make it easy to review Gitlab MRs from within
@@ -41,12 +40,10 @@ the editor. This means you can do things like:
 - View and manage pipeline Jobs
 - Upload files, jump to the browser, and a lot more!
 
-
 REQUIREMENTS                                        *gitlab.nvim.requirements*
 
 - Go >= v1.19
 
-
 QUICK START                                          *gitlab.nvim.quick-start*
 
 1. Install Go
@@ -137,14 +134,16 @@ Here an example how to use a custom `auth_provider`:
     }
 <
 
-
 CONFIGURING THE PLUGIN                    *gitlab.nvim.configuring-the-plugin*
 
 Here is the default setup function. All of these values are optional, and if
 you call this function with no values the defaults will be used:
 >lua
     require("gitlab").setup({
-      port = nil, -- The port of the Go server, which runs in the background, if omitted or `nil` the port will be chosen automatically
+      server = {
+        binary = nil, -- The path to the server binary. If omitted or nil, the server will be built
+        port = nil, -- The port of the Go server, which runs in the background. If omitted or `nil` the port will be chosen automatically
+      },
       log_path = vim.fn.stdpath("cache") .. "/gitlab.nvim.log", -- Log path for the Go server
       config_path = nil, -- Custom path for `.gitlab.nvim` file, please read the "Connecting to Gitlab" section
       debug = {
@@ -381,7 +380,6 @@ First, check out the branch that you want to review locally:
 Then open Neovim. To begin, try running the `summary` command or the `review`
 command.
 
-
 THE SUMMARY VIEW                                *gitlab.nvim.the-summary-view*
 
 The `summary` action will open the MR title and description:
@@ -396,7 +394,6 @@ separate pane underneath the description. This can be disabled, and these
 fields can be reordered or removed. Please see the `settings.info` section of
 the configuration.
 
-
 REVIEWING AN MR                                  *gitlab.nvim.reviewing-an-mr*
 
 The `review` action will open a diff of the changes. You can leave comments
@@ -498,7 +495,6 @@ You can add or remove labels from the current MR.
 These labels will be visible in the summary panel, as long as you provide the
 "fields" string in your setup function under the `setting.info.fields` block.
 
-
 SIGNS AND DIAGNOSTICS                      *gitlab.nvim.signs-and-diagnostics*
 
 By default when reviewing files, you will see diagnostics for comments that
@@ -532,7 +528,6 @@ You may skip resolved discussions by toggling `discussion_signs.skip_resolved_di
 in your setup function to `true`. By default, discussions from this plugin
 are shown at the INFO severity level (see :h vim.diagnostic.severity).
 
-
 EMOJIS                                                    *gitlab.nvim.emojis*
 
 You can add or remove emojis from a note or comment in the discussion tree.
@@ -541,7 +536,6 @@ To see who has reacted with an emoji, hover over the emoji. A popup will
 appear with anyone who has responded with that emoji. You can only delete
 emojis that you have responded with.
 
-
 UPLOADING FILES                                  *gitlab.nvim.uploading-files*
 
 To attach a file to an MR description, reply, comment, and so forth use the
@@ -554,7 +548,6 @@ current line.
 
 Use the `keymaps.popup.perform_action` to send the changes to Gitlab.
 
-
 MR APPROVALS                                        *gitlab.nvim.mr-approvals*
 
 You can approve or revoke approval for an MR with the `approve` and `revoke`
@@ -574,7 +567,6 @@ this command to work.
 <
 See |gitlab.nvim.merge| for more help on this function.
 
-
 CREATING AN MR                                    *gitlab.nvim.creating-an-mr*
 
 To create an MR for the current branch, make sure you have the branch checked
@@ -598,7 +590,6 @@ To re-trigger failed jobs in the pipeline manually, use the
 new Neovim buffer, use your `keymaps.popup.perform_linewise_action`
 keybinding.
 
-
 REVIEWERS AND ASSIGNEES                  *gitlab.nvim.reviewers-and-assignees*
 
 The `add_reviewer` and `delete_reviewer` actions, as well as the `add_assignee`
@@ -678,7 +669,7 @@ by a |motion|.
 Either the operator or the motion can be preceded by a count, so that `3sj` is
 equivalent to `s3j`, and they both create a comment for the current line and
 three more lines downwards. Similarly, both `2s`|ap| and `s2`|ap| create a suggestion
-for two "outer" paragraphs. 
+for two "outer" paragraphs.
 
 The operators force |linewise| visual selection, so they work correctly even
 if the motion itself works |characterwise| (e.g., |i(| for selecting the inner

flake.lock

@@ -0,0 +1,34 @@
+{
+  inputs = {
+    nixpkgs.url = "github:NixOS/nixpkgs/nixos-25.11";
+    flake-utils.url = "github:numtide/flake-utils";
+  };
+
+  outputs = { self, flake-utils, nixpkgs }:
+    flake-utils.lib.eachDefaultSystem (system:
+      let
+        pkgs = import nixpkgs { inherit system; config.allowUnfree = true; };
+        gitlab-nvim-server = pkgs.buildGoModule {
+          pname = "gitlab.nvim-server";
+          version = "git";
+          src = ./.;
+          vendorHash = "sha256-OLAKTdzqynBDHqWV5RzIpfc3xZDm6uYyLD4rxbh0DMg=";
+          postInstall = ''
+            cp -r ${./cmd/config} $out/bin/config
+            mv $out/bin/cmd $out/bin/gitlab.nvim
+          '';
+        };
+        gitlab-nvim = pkgs.vimUtils.buildVimPlugin {
+          name = "gitlab.nvim";
+          src = ./.;
+          doCheck = false;
+        };
+      in
+      rec {
+        formatter = pkgs.nixpkgs-fmt;
+        packages.gitlab-nvim-server = gitlab-nvim-server;
+        packages.gitlab-nvim = gitlab-nvim;
+        packages.default = packages.gitlab-nvim;
+      }
+    );
+}

flake.nix

@@ -44,8 +44,8 @@ local function setup(args)
     return
   end
 
-  server.build() -- Builds the Go binary if it doesn't exist
   state.merge_settings(args) -- Merges user settings with default settings
+  server.build() -- Builds the Go binary if it doesn't exist
   state.set_global_keymaps() -- Sets keymaps that are not bound to a specific buffer
   require("gitlab.colors") -- Sets colors
   reviewer.init()

lua/gitlab/init.lua

@@ -6,7 +6,7 @@ local M = {}
 
 M.run_job = function(endpoint, method, body, callback)
   local state = require("gitlab.state")
-  local args = { "-s", "-X", (method or "POST"), string.format("localhost:%s", state.settings.port) .. endpoint }
+  local args = { "-s", "-X", (method or "POST"), string.format("localhost:%s", state.settings.server.port) .. endpoint }
 
   if body ~= nil then
     local encoded_body = vim.json.encode(body)

lua/gitlab/job.lua

@@ -30,7 +30,7 @@ end
 
 -- Starts the Go server and call the callback provided
 M.start = function(callback)
-  local port = tonumber(state.settings.port) or 0
+  local port = tonumber(state.settings.server.port) or 0
   local parsed_port = nil
   local callback_called = false
 
@@ -51,7 +51,7 @@ M.start = function(callback)
     settings = settings:gsub('"', '\\"')
   end
 
-  local command = string.format('"%s" "%s"', state.settings.bin, settings)
+  local command = string.format('"%s" "%s"', state.settings.server.binary, settings)
 
   local job_id = vim.fn.jobstart(command, {
     on_stdout = function(_, data)
@@ -61,7 +61,7 @@ M.start = function(callback)
           port = line:match("Server started on port:%s+(%d+)")
           if port ~= nil then
             parsed_port = port
-            state.settings.port = port
+            state.settings.server.port = port
             break
           end
         end
@@ -105,26 +105,54 @@ end
 -- Builds the Go binary with the current Git tag.
 M.build = function(override)
   local file_path = u.current_file_path()
-  local parent_dir = vim.fn.fnamemodify(file_path, ":h:h:h:h")
+  state.settings.root_path = vim.fn.fnamemodify(file_path, ":h:h:h:h")
+
+  -- If the user provided a path to the server, don't build it.
+  if state.settings.server.binary ~= nil then
+    local binary_exists = vim.loop.fs_stat(state.settings.server.binary)
+    if binary_exists == nil then
+      u.notify(string.format("The user-provided server path (%s) does not exist.", state.settings.server.binary), vim.log.levels.ERROR)
+    end
+    return
+  end
+
+  -- If the user did not provide a path, we build it and place it in either the data path, or the
+  -- first writable path we find in the runtime.
+  local datapath = vim.fn.stdpath('data')
+  local runtimepath = vim.api.nvim_list_runtime_paths()
+  table.insert(runtimepath, 1, datapath)
+
+  local bin_folder
+  for _, path in ipairs(runtimepath) do
+    local ok, err = vim.loop.fs_access(path, 'w')
+    if err == nil and ok ~= nil and ok then
+      bin_folder = path .. u.path_separator .. "gitlab.nvim" .. u.path_separator .. "bin"
+      if vim.fn.mkdir(bin_folder, "p") == 1 then
+        state.settings.server.binary = bin_folder .. u.path_separator .. "server"
+        break
+      end
+    end
+  end
 
-  local bin_name = u.is_windows() and "bin.exe" or "bin"
-  state.settings.root_path = parent_dir
-  state.settings.bin = parent_dir .. u.path_separator .. "cmd" .. u.path_separator .. bin_name
+  if state.settings.server.binary == nil then
+    u.notify("Could not find a writable folder in the runtime path to save the server to.", vim.log.levels.ERROR)
+    return
+  end
 
   if not override then
-    local binary_exists = vim.loop.fs_stat(state.settings.bin)
+    local binary_exists = vim.loop.fs_stat(state.settings.server.binary)
     if binary_exists ~= nil then
       return
     end
   end
 
-  local version_output = vim.system({ "git", "describe", "--tags", "--always" }, { cwd = parent_dir }):wait()
+  local version_output = vim.system({ "git", "describe", "--tags", "--always" }, { cwd = state.settings.root_path }):wait()
   local version = version_output.code == 0 and vim.trim(version_output.stdout) or "unknown"
 
   local ldflags = string.format("-X main.Version=%s", version)
   local res = vim
     .system(
-      { "go", "build", "-ldflags", ldflags, "-o", bin_name },
+      { "go", "build", "-buildvcs=false", "-ldflags", ldflags, "-o", state.settings.server.binary },
       { cwd = state.settings.root_path .. u.path_separator .. "cmd" }
     )
     :wait()
@@ -133,6 +161,12 @@ M.build = function(override)
     u.notify(string.format("Failed to install with status code %d:\n%s", res.code, res.stderr), vim.log.levels.ERROR)
     return false
   end
+
+  local Path = require("plenary.path")
+  local src = Path:new(state.settings.root_path .. u.path_separator .. "cmd" .. u.path_separator .. "config" )
+  local dest = Path:new(bin_folder .. u.path_separator .. "config")
+  src:copy({ destination = dest, recursive = true, override = true })
+
   u.notify("Installed successfully!", vim.log.levels.INFO)
   return true
 end
@@ -185,7 +219,7 @@ M.get_version = function(callback)
   local version_output = vim.system({ "git", "describe", "--tags", "--always" }, { cwd = parent_dir }):wait()
   local plugin_version = version_output.code == 0 and vim.trim(version_output.stdout) or "unknown"
 
-  local args = { "-s", "-X", "GET", string.format("localhost:%s/version", state.settings.port) }
+  local args = { "-s", "-X", "GET", string.format("localhost:%s/version", state.settings.server.port) }
 
   -- We call the "/version" endpoint here instead of through the regular jobs pattern because earlier versions of the plugin
   -- may not have it. We handle a 404 as an "unknown" version error.

lua/gitlab/server.lua

@@ -45,7 +45,10 @@ end
 M.settings = {
   auth_provider = M.default_auth_provider,
   file_separator = u.path_separator,
-  port = nil, -- choose random port
+  server = {
+    binary = nil, -- path to the server binary. if nil, it will be compiled, otherwise the existing binary at this path will be used
+    port = nil, -- choose random port
+  },
   debug = {
     request = false,
     response = false,