chore(env): remove stale GPU_CARD/GPU_RENDER defaults from .env.example#40
Merged
Conversation
These variables are no longer referenced after PR #38 changed docker-compose.arc.yml to use whole-/dev/dri pass-through: devices: - /dev/dri:/dev/dri The previous ${GPU_CARD:-/dev/dri/card1} pattern is gone. Keeping the example entries was misleading — new users would set them expecting them to take effect. Removes: - # ── Intel Arc GPU device nodes (only needed with docker-compose.arc.yml) ────── - # Run scripts/check-arc-gpu.sh to find the correct device paths for your system. - # These values are ignored when using the CPU or NVIDIA compose overlay. - GPU_CARD=/dev/dri/card1 - GPU_RENDER=/dev/dri/renderD128 Related: PR #38 (whole-dir mount), PR #39 (native Vulkan path). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These variables are no longer referenced after PR #38 changed docker-compose.arc.yml to use whole-/dev/dri pass-through:
The previous ${GPU_CARD:-/dev/dri/card1} pattern is gone. Keeping the example entries was misleading — new users would set them expecting them to take effect.
Removes:
── Intel Arc GPU device nodes (only needed with docker-compose.arc.yml) ──────
Run scripts/check-arc-gpu.sh to find the correct device paths for your system.
These values are ignored when using the CPU or NVIDIA compose overlay.
Related: PR #38 (whole-dir mount), PR #39 (native Vulkan path).
Summary
Type of change
Related issues
Testing
docker compose configpasses with no errorsshellcheckChecklist
.env.exampleis up to date (if env vars were added/removed)