Skip to content

Commit 5b7fc47

Browse files
committed
Fix formatting and clippy warnings
1 parent 7481405 commit 5b7fc47

3 files changed

Lines changed: 29 additions & 24 deletions

File tree

diffenator3-lib/src/render/colorpainter.rs

Lines changed: 16 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -238,8 +238,10 @@ impl<'a> ColorPainter for SkiaPainter<'a> {
238238
to_spread(extend),
239239
self.transform,
240240
) {
241-
let mut paint = Paint::default();
242-
paint.shader = shader;
241+
let paint = Paint {
242+
shader,
243+
..Paint::default()
244+
};
243245
tmp.fill_path(
244246
&path,
245247
&paint,
@@ -273,8 +275,10 @@ impl<'a> ColorPainter for SkiaPainter<'a> {
273275
to_spread(extend),
274276
self.transform,
275277
) {
276-
let mut paint = Paint::default();
277-
paint.shader = shader;
278+
let paint = Paint {
279+
shader,
280+
..Paint::default()
281+
};
278282
tmp.fill_path(
279283
&path,
280284
&paint,
@@ -306,8 +310,10 @@ impl<'a> ColorPainter for SkiaPainter<'a> {
306310
to_spread(extend),
307311
self.transform,
308312
) {
309-
let mut paint = Paint::default();
310-
paint.shader = shader;
313+
let paint = Paint {
314+
shader,
315+
..Paint::default()
316+
};
311317
tmp.fill_path(
312318
&path,
313319
&paint,
@@ -393,8 +399,10 @@ impl<'a> ColorPainter for SkiaPainter<'a> {
393399
CompositeMode::Plus => tiny_skia::BlendMode::Plus,
394400
_ => tiny_skia::BlendMode::SourceOver,
395401
};
396-
let mut paint = PixmapPaint::default();
397-
paint.blend_mode = blend;
402+
let paint = PixmapPaint {
403+
blend_mode: blend,
404+
..PixmapPaint::default()
405+
};
398406
let pm = self.current_pixmap();
399407
pm.draw_pixmap(0, 0, layer.as_ref(), &paint, TsTransform::identity(), None);
400408
}

diffenator3-lib/src/render/colorrenderer.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -129,8 +129,7 @@ impl<'a> ColorRenderer<'a> {
129129
let (bearing_x, bearing_y, tile_w, tile_h) = self.glyph_tile_bounds(glyph_id);
130130

131131
let outlines = self.font.outline_glyphs();
132-
let mut painter =
133-
SkiaPainter::new(tile_w, tile_h, &self.palette, outlines, self.location);
132+
let mut painter = SkiaPainter::new(tile_w, tile_h, &self.palette, outlines, self.location);
134133

135134
// Transform: maps font-unit origin (0,0) to pixel (-bearing_x, bearing_y)
136135
// within the tile, with Y-flip (font Y-up → pixel Y-down).

diffenator3-lib/src/render/mod.rs

Lines changed: 12 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,12 @@ pub(crate) fn diff_many_words(
150150
.is_none_or(|scp| word.chars().all(|c| scp.contains(&(c as u32))))
151151
})
152152
.map(|word| {
153-
let renderer_a = tl_a
154-
.get_or(|| RefCell::new(ColorRenderer::new(font_a, font_size, direction, script)));
155-
let renderer_b = tl_b
156-
.get_or(|| RefCell::new(ColorRenderer::new(font_b, font_size, direction, script)));
153+
let renderer_a = tl_a.get_or(|| {
154+
RefCell::new(ColorRenderer::new(font_a, font_size, direction, script))
155+
});
156+
let renderer_b = tl_b.get_or(|| {
157+
RefCell::new(ColorRenderer::new(font_b, font_size, direction, script))
158+
});
157159

158160
let (buffer_a, img_a) = renderer_a.borrow_mut().render_string(word)?;
159161
if buffer_a
@@ -191,10 +193,10 @@ pub(crate) fn diff_many_words(
191193
.is_none_or(|scp| word.chars().all(|c| scp.contains(&(c as u32))))
192194
})
193195
.map(|word| {
194-
let renderer_a =
195-
tl_a.get_or(|| RefCell::new(Renderer::new(font_a, font_size, direction, script)));
196-
let renderer_b =
197-
tl_b.get_or(|| RefCell::new(Renderer::new(font_b, font_size, direction, script)));
196+
let renderer_a = tl_a
197+
.get_or(|| RefCell::new(Renderer::new(font_a, font_size, direction, script)));
198+
let renderer_b = tl_b
199+
.get_or(|| RefCell::new(Renderer::new(font_b, font_size, direction, script)));
198200

199201
let (buffer_a, commands_a) =
200202
renderer_a.borrow_mut().string_to_positioned_glyphs(word)?;
@@ -303,9 +305,7 @@ pub(crate) fn diff_many_words(
303305
continue;
304306
}
305307
}
306-
let Some((buffer_a, commands_a)) =
307-
renderer_a.string_to_positioned_glyphs(&word)
308-
else {
308+
let Some((buffer_a, commands_a)) = renderer_a.string_to_positioned_glyphs(&word) else {
309309
continue;
310310
};
311311
if buffer_a.split('|').all(|glyph| seen_glyphs.contains(glyph)) {
@@ -314,9 +314,7 @@ pub(crate) fn diff_many_words(
314314
for glyph in buffer_a.split('|') {
315315
seen_glyphs.insert(glyph.to_string());
316316
}
317-
let Some((buffer_b, commands_b)) =
318-
renderer_b.string_to_positioned_glyphs(&word)
319-
else {
317+
let Some((buffer_b, commands_b)) = renderer_b.string_to_positioned_glyphs(&word) else {
320318
continue;
321319
};
322320
if commands_a == commands_b {

0 commit comments

Comments
 (0)