From 48e95e8a0d32277449c269b41fba6419acb21418 Mon Sep 17 00:00:00 2001
From: Guenter Sandner <www.gms@gmx.at>
Date: Sat, 28 Mar 2026 09:08:07 +0100
Subject: [PATCH] fix exception handling

This fixes the contradictory configuration where compiler flags enabled
C++ exceptions but NAPI_DISABLE_CPP_EXCEPTIONS=1 told node-addon-api to
disable them. Now C++ exceptions are properly enabled throughout the
stack.
---
 binding.gyp     | 11 +++--------
 docs/DEVELOP.md |  6 +++++-
 2 files changed, 8 insertions(+), 9 deletions(-)

diff --git a/binding.gyp b/binding.gyp
index a8fccd0c..0f7e2d5b 100644
--- a/binding.gyp
+++ b/binding.gyp
@@ -8,15 +8,10 @@
   "targets": [
     {
       "target_name": "<(module_name)",
-      "cflags!": [ "-fno-exceptions" ],
-      "cflags_cc!": [ "-fno-exceptions" ],
-      "xcode_settings": { "GCC_ENABLE_CPP_EXCEPTIONS": "YES",
+      "xcode_settings": {
         "CLANG_CXX_LIBRARY": "libc++",
         "MACOSX_DEPLOYMENT_TARGET": "10.7",
       },
-      "msvs_settings": {
-        "VCCLCompilerTool": { "ExceptionHandling": 1 },
-      },
       "include_dirs": [
         "<!@(node -p \"require('node-addon-api').include\")"],
       "conditions": [
@@ -40,7 +35,7 @@
         },
         {
             "dependencies": [
-              "<!(node -p \"require('node-addon-api').gyp\")",
+              "<!(node -p \"require('node-addon-api').targets\"):node_addon_api_except",
               "deps/sqlite3.gyp:sqlite3"
             ]
         }
@@ -52,7 +47,7 @@
         "src/node_sqlite3.cc",
         "src/statement.cc"
       ],
-      "defines": [ "NAPI_VERSION=<(napi_build_version)", "NAPI_DISABLE_CPP_EXCEPTIONS=1" ]
+      "defines": [ "NAPI_VERSION=<(napi_build_version)" ]
     }
   ]
 }
diff --git a/docs/DEVELOP.md b/docs/DEVELOP.md
index b9ea2fbf..491f0e04 100644
--- a/docs/DEVELOP.md
+++ b/docs/DEVELOP.md
@@ -26,7 +26,11 @@ This project uses [npm version](https://docs.npmjs.com/cli/v10/commands/npm-vers
    - Upload them as release assets
    - Publish the package to npm
 
-3. ** Create GitHub Release from tag
+3. ** Edit the generated Pre-release
+  - select "Generate release notes"
+  - uncheck "Set as pre-release"
+  - check "Set as latest release" if it is
+  - click "Update Releasse
 
 ### Version format