Fail to update scroll listener in 1.9.0, due to wrong deduplication implementation

[WangLeto]

react-scroll/modules/mixins/passive-event-listeners.js

Lines 13 to 15 in 526bab0

	if (!attachedListeners.has(eventName)) attachedListeners.set(eventName, new Set());
	const listeners = attachedListeners.get(eventName);
	if (listeners.has(listenerName)) return;

Version 1.9.0 added a deduplication mechanism for event listeners, but did not remove the corresponding records. This causes the component to fail to update the event listener when it is remounted and the container is specified.

[fisshy]

oh, good find, could you make a PR fixing it? :)

[WangLeto]

@fisshy Hi, I've submitted a PR.

By the way I noticed it seems the scrollSpyContainer hasn't never been removed. A possible solution is to check and remove unused containers by isConnected during the execution of scrollSpy.mount. :)
refer: https://developer.mozilla.org/en-US/docs/Web/API/Node/isConnected

[mseidel819]

I think the PR related to this issue has created some other side effects:
activeClass property not woking on scrolling.

The active class seemed flaky at first, but after clicking around on my app, the active nav styles stopped updating altogether. Maybe a listener is not getting re-added when its supposed to?