Implements RFC 496 Incorrectly

[ef4]

ember-cli-htmlbars configures:

import { precompileTemplate } from '@ember/template-compilation'

to mean both createTemplateFactory and the wire format compilation. But that contradicts the RFC, which says that precompileTemplate is supposed to only produce the wire format.

The thing that's being implemented here is really compile, not precompile. compile is the one that automatically includes both steps.

The RFC muddies these waters by implying that compile would be for runtime compilation vs build-time compilation, but even if that is a true distinction we want to maintain, then we still need something that means "both steps, but at build time".

I would argue that precompile already means that in practice because of how it's implemented, and we could amend the RFC to make that clear.

[ef4]

The question is, is there a use case for the low-level, wire-format-only feature that the RFC describes for precompile. I would argue there is not. The only public API for what you can do with wire format templates is pass them to createTemplateFactory, so why would you need to make a wire format template that's not wrapped in it?