From 2d3a37a4049a5d878804b3cb283bb546f5b60ef0 Mon Sep 17 00:00:00 2001
From: CryptoKage2306 <26vivek06@gmail.com>
Date: Wed, 14 Aug 2024 00:27:55 +0530
Subject: [PATCH] refactor: best practices

---
 .../trade-shield-contract/src/entry_point/instantiate.rs     | 2 +-
 contracts/trade-shield-contract/src/entry_point/migrate.rs   | 2 +-
 contracts/trade-shield-contract/src/helper.rs                | 5 +----
 rust-toolchain.toml                                          | 4 ++++
 4 files changed, 7 insertions(+), 6 deletions(-)
 create mode 100644 rust-toolchain.toml

diff --git a/contracts/trade-shield-contract/src/entry_point/instantiate.rs b/contracts/trade-shield-contract/src/entry_point/instantiate.rs
index 5fda6b2b..bcc56569 100644
--- a/contracts/trade-shield-contract/src/entry_point/instantiate.rs
+++ b/contracts/trade-shield-contract/src/entry_point/instantiate.rs
@@ -12,7 +12,7 @@ pub fn instantiate(
     deps: DepsMut<ElysQuery>,
     _env: Env,
     _info: MessageInfo,
-    msg: InstantiateMsg,
+    _msg: InstantiateMsg,
 ) -> StdResult<Response<ElysMsg>> {
     set_contract_version(deps.storage, CONTRACT_NAME, CONTRACT_VERSION)?;
     MAX_REPLY_ID.save(deps.storage, &0)?;
diff --git a/contracts/trade-shield-contract/src/entry_point/migrate.rs b/contracts/trade-shield-contract/src/entry_point/migrate.rs
index 918e44e4..4d74f46d 100644
--- a/contracts/trade-shield-contract/src/entry_point/migrate.rs
+++ b/contracts/trade-shield-contract/src/entry_point/migrate.rs
@@ -16,7 +16,7 @@ use semver::Version;
 pub fn migrate(
     deps: DepsMut<ElysQuery>,
     _env: Env,
-    msg: MigrateMsg,
+    _msg: MigrateMsg,
 ) -> StdResult<Response<ElysMsg>> {
     let admin = "elys16xffmfa6k45j340cx5zyp66lqvuw62a0neaa7w".to_string();
     PARAMS_ADMIN.save(deps.storage, &admin)?;
diff --git a/contracts/trade-shield-contract/src/helper.rs b/contracts/trade-shield-contract/src/helper.rs
index 558bc5c0..a3503dd0 100644
--- a/contracts/trade-shield-contract/src/helper.rs
+++ b/contracts/trade-shield-contract/src/helper.rs
@@ -48,10 +48,7 @@ pub fn get_discount(
     }
 
     let val = Uint128::from_str(&discount_str)?;
-    let discount_str = match Decimal::from_atomics(val, 2) {
-        Ok(resp) => resp,
-        Err(_) => Decimal::zero(),
-    };
+    let discount_str = Decimal::from_atomics(val, 2).unwrap_or_default();
     Ok(discount_str)
 }
 
diff --git a/rust-toolchain.toml b/rust-toolchain.toml
new file mode 100644
index 00000000..cdd293b8
--- /dev/null
+++ b/rust-toolchain.toml
@@ -0,0 +1,4 @@
+[toolchain]
+channel = "1.79.0"  # or "nightly", "beta", or a specific version like "1.56.0"
+components = ["rustfmt", "clippy"]  # optional, specify additional components
+targets = ["wasm32-unknown-unknown"]  # optional, specify additional targets
\ No newline at end of file