Skip to content

Commit dcf5492

Browse files
authored
Merge pull request #15 from unv-unv/renderer
NodeJSMutableModuleExtension refactoring
2 parents 7204749 + 13cb397 commit dcf5492

1 file changed

Lines changed: 37 additions & 43 deletions

File tree

nodejs-impl/src/main/java/consulo/nodejs/impl/module/extension/NodeJSMutableModuleExtension.java

Lines changed: 37 additions & 43 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@
1313
* See the License for the specific language governing permissions and
1414
* limitations under the License.
1515
*/
16-
1716
package consulo.nodejs.impl.module.extension;
1817

1918
import consulo.content.bundle.Sdk;
@@ -22,6 +21,7 @@
2221
import consulo.javascript.language.StandardJavaScriptVersions;
2322
import consulo.javascript.module.extension.JavaScriptMutableModuleExtension;
2423
import consulo.language.version.LanguageVersion;
24+
import consulo.localize.LocalizeValue;
2525
import consulo.module.content.layer.ModuleRootLayer;
2626
import consulo.module.extension.MutableModuleInheritableNamedPointer;
2727
import consulo.module.ui.extension.ModuleExtensionBundleBoxBuilder;
@@ -34,61 +34,55 @@
3434

3535
import jakarta.annotation.Nonnull;
3636
import jakarta.annotation.Nullable;
37+
3738
import java.util.List;
3839

3940
/**
4041
* @author VISTALL
41-
* @since 14.03.14
42+
* @since 2014-03-14
4243
*/
43-
public class NodeJSMutableModuleExtension extends NodeJSModuleExtension implements JavaScriptMutableModuleExtension<NodeJSModuleExtension>
44-
{
45-
public NodeJSMutableModuleExtension(@Nonnull String id, @Nonnull ModuleRootLayer rootModel)
46-
{
47-
super(id, rootModel);
48-
}
44+
public class NodeJSMutableModuleExtension extends NodeJSModuleExtension implements JavaScriptMutableModuleExtension<NodeJSModuleExtension> {
45+
public NodeJSMutableModuleExtension(@Nonnull String id, @Nonnull ModuleRootLayer rootModel) {
46+
super(id, rootModel);
47+
}
4948

50-
@Nonnull
51-
@Override
52-
public MutableModuleInheritableNamedPointer<Sdk> getInheritableSdk()
53-
{
54-
return (MutableModuleInheritableNamedPointer<Sdk>) super.getInheritableSdk();
55-
}
49+
@Nonnull
50+
@Override
51+
public MutableModuleInheritableNamedPointer<Sdk> getInheritableSdk() {
52+
return (MutableModuleInheritableNamedPointer<Sdk>) super.getInheritableSdk();
53+
}
5654

55+
@Nullable
56+
@Override
5757
@RequiredUIAccess
58-
@Nullable
59-
@Override
60-
public Component createConfigurationComponent(@Nonnull Disposable disposable, @Nonnull Runnable runnable)
61-
{
62-
VerticalLayout layout = VerticalLayout.create();
63-
layout.add(ModuleExtensionBundleBoxBuilder.createAndDefine(this, disposable, runnable).build());
58+
public Component createConfigurationComponent(@Nonnull Disposable disposable, @Nonnull Runnable runnable) {
59+
VerticalLayout layout = VerticalLayout.create();
60+
layout.add(ModuleExtensionBundleBoxBuilder.createAndDefine(this, disposable, runnable).build());
6461

65-
List<JavaScriptLanguageVersion> validLanguageVersions = StandardJavaScriptVersions.getInstance().getValidLanguageVersions();
62+
List<JavaScriptLanguageVersion> validLanguageVersions = StandardJavaScriptVersions.getInstance().getValidLanguageVersions();
6663

67-
ComboBox<JavaScriptLanguageVersion> langVersionBox = ComboBox.create(validLanguageVersions);
68-
langVersionBox.addValueListener(e -> setLanguageVersion(e.getValue()));
69-
langVersionBox.setValue((JavaScriptLanguageVersion) getLanguageVersion());
70-
langVersionBox.setRender((presentation, i, version) -> presentation.append(version.getPresentableName()));
64+
ComboBox<JavaScriptLanguageVersion> langVersionBox = ComboBox.create(validLanguageVersions);
65+
langVersionBox.addValueListener(e -> setLanguageVersion(e.getValue()));
66+
langVersionBox.setValue((JavaScriptLanguageVersion) getLanguageVersion());
67+
langVersionBox.setTextRenderer(version -> LocalizeValue.of(version.getPresentableName()));
7168

72-
layout.add(LabeledComponents.leftFilled("Language Version", langVersionBox));
69+
layout.add(LabeledComponents.leftFilled("Language Version", langVersionBox));
7370

74-
return layout;
75-
}
71+
return layout;
72+
}
7673

77-
@Override
78-
public void setEnabled(boolean b)
79-
{
80-
myIsEnabled = b;
81-
}
74+
@Override
75+
public void setEnabled(boolean b) {
76+
myIsEnabled = b;
77+
}
8278

83-
@Override
84-
public boolean isModified(@Nonnull NodeJSModuleExtension nodeJSModuleExtension)
85-
{
86-
return isModifiedImpl(nodeJSModuleExtension) || myLanguageVersion != nodeJSModuleExtension.getLanguageVersion();
87-
}
79+
@Override
80+
public boolean isModified(@Nonnull NodeJSModuleExtension nodeJSModuleExtension) {
81+
return isModifiedImpl(nodeJSModuleExtension) || myLanguageVersion != nodeJSModuleExtension.getLanguageVersion();
82+
}
8883

89-
@Override
90-
public void setLanguageVersion(@Nonnull LanguageVersion languageVersion)
91-
{
92-
myLanguageVersion = languageVersion;
93-
}
84+
@Override
85+
public void setLanguageVersion(@Nonnull LanguageVersion languageVersion) {
86+
myLanguageVersion = languageVersion;
87+
}
9488
}

0 commit comments

Comments
 (0)