del_client_interface (and others) send duplicate ubus messages to wpad

[russdill]

DAWN/src/utils/ubus.c

Line 1255 in 3b220fb

ubus_invoke(ctx, id, "del_client", b.head, NULL, NULL, timeout * 1000);

A common pattern in utils/ubus.c is:

    list_for_each_entry(sub, &hostapd_sock_list, list)
    {   
        if (sub->subscribed) {
            int timeout = 1;
            ubus_invoke(ctx, id, "del_client", b.head, NULL, NULL, timeout * 1000);
        }
    }

It seems to be a copy/paste from:

    list_for_each_entry(sub, &hostapd_sock_list, list)
    {
        if (sub->subscribed) {
            int timeout = 1;
            ubus_invoke(ctx, sub->id, "del_client", b.head, NULL, NULL, timeout * 1000);
        }
    }

Its likely that it just needs to be changed to:

        int timeout = 1;
        ubus_invoke(ctx, id, "del_client", b.head, NULL, NULL, timeout * 1000);

[edrikk]

@PolynomialDivision this also makes sense to me. Basically it's a one shot deal to remove from your own AP.
Does it make sense? If yes, can the change to not loop be implemented?

[PolynomialDivision]

Yes this is correct. Of course this should be implemented. If you want go for it, I can also do it in the next days.