chore: lint fixes

Author: KartikJha

internal/cli/quickstart_detect.go

@@ -76,8 +76,7 @@ func DetectProject(dir string) DetectionResult {
 	if data, ok := readFileContent(dir, "pubspec.yaml"); ok {
 		if strings.Contains(data, "sdk: flutter") {
 			result.Detected = true
-			// android/ or ios/ present means a native project regardless of web/ directory.
-			// flutter create (default) has included web/ since Flutter 2.10, so web/ alone
+			// Flutter create (default) has included web/ since Flutter 2.10, so web/ alone
 			// is not a reliable signal for web-only intent.
 			if dirExists(dir, "android") || dirExists(dir, "ios") {
 				result.Framework = "flutter"
@@ -161,8 +160,7 @@ func DetectProject(dir string) DetectionResult {
 		return result
 	}
 
-	// ── 10. Expo: app.json with top-level "expo" key, or legacy expo.json ────.
-	// create-expo-app has generated app.json (not expo.json) since SDK 46 (2022).
+	// Create-expo-app has generated app.json (not expo.json) since SDK 46 (2022).
 	// Check app.json first; fall back to expo.json for legacy projects.
 	if isExpoProject(dir) || fileExists(dir, "expo.json") {
 		result.Framework = "expo"
@@ -320,16 +318,15 @@ func detectJavaFramework(content string) (framework string, port int) {
 		strings.Contains(lower, "jakarta.ee") ||
 		strings.Contains(lower, "javax.servlet") ||
 		strings.Contains(lower, "jakarta.servlet") ||
-		// jakarta.platform:jakarta.jakartaee-api is the standard BOM for Jakarta EE 9+.
+		// Jakarta.platform:jakarta.jakartaee-api is the standard BOM for Jakarta EE 9+.
 		strings.Contains(lower, "jakarta.platform"):
 		return "java-ee", 0
 	default:
 		return "vanilla-java", 0
 	}
 }
 
-// isExpoProject returns true if app.json contains a top-level "expo" key.
-// create-expo-app has generated app.json (not expo.json) since SDK 46 in 2022.
+// Create-expo-app has generated app.json (not expo.json) since SDK 46 in 2022.
 func isExpoProject(dir string) bool {
 	data, err := os.ReadFile(filepath.Join(dir, "app.json"))
 	if err != nil {
@@ -349,13 +346,6 @@ func dirExists(dir, name string) bool {
 	return err == nil && info.IsDir()
 }
 
-// isFlutterWeb returns true if the project has web platform support enabled.
-// Kept for backwards compatibility; DetectProject uses dirExists for android/ios instead.
-func isFlutterWeb(dir string) bool {
-	_, err := os.Stat(filepath.Join(dir, "web", "index.html"))
-	return err == nil
-}
-
 // fileExists returns true if the named file exists in dir.
 func fileExists(dir, name string) bool {
 	_, err := os.Stat(filepath.Join(dir, name))

internal/cli/quickstart_detect_test.go

@@ -469,7 +469,7 @@ func TestDetectProject_Laravel(t *testing.T) {
 func TestDetectProject_Flutter(t *testing.T) {
 	dir := t.TempDir()
 	writeTestFile(t, dir, "pubspec.yaml", "name: my_flutter_app\nflutter:\n  sdk: flutter\n")
-	// android/ present -> native (reliable signal for native intent).
+	// Android/ present -> native (reliable signal for native intent).
 	mkTestDir(t, dir, "android")
 
 	got := DetectProject(dir)

internal/cli/quickstarts.go

@@ -709,7 +709,7 @@ func setupQuickstartCmdExperimental(cli *cli) *cobra.Command {
 				return fmt.Errorf("authentication required: %w", err)
 			}
 
-			// linkedAppClientID tracks which app client ID to link to the API
+			// LinkedAppClientID tracks which app client ID to link to the API
 			// (either a newly created app or one selected from the tenant).
 			var linkedAppClientID string
 
@@ -747,12 +747,13 @@ func setupQuickstartCmdExperimental(cli *cli) *cobra.Command {
 				typeFromFlag := cmd.Flags().Changed("type")
 				frameworkFromFlag := cmd.Flags().Changed("framework")
 
-				if typeFromFlag && frameworkFromFlag {
+				switch {
+				case typeFromFlag && frameworkFromFlag:
 					// User explicitly specified type and framework via flags; skip detection UI.
 					if inputs.Name == "" {
 						inputs.Name = detection.AppName
 					}
-				} else if detection.Detected {
+				case detection.Detected:
 					if len(detection.AmbiguousCandidates) > 1 {
 						// Multiple package.json deps matched — show partial summary and ask user to disambiguate.
 						cli.renderer.Infof("Detected in current directory")
@@ -815,7 +816,7 @@ func setupQuickstartCmdExperimental(cli *cli) *cobra.Command {
 							}
 						}
 					}
-				} else {
+				default:
 					// No detection signal found — notify the user and pre-fill name from directory.
 					cli.renderer.Warnf("Auto detection Failed: Unable to auto detect application")
 					if inputs.Name == "" {
@@ -916,8 +917,7 @@ func setupQuickstartCmdExperimental(cli *cli) *cobra.Command {
 					}
 				}
 
-				// Prompt for token lifetime if not provided via flag.
-				// inputs.TokenLifetime already has "86400" from flag default; only prompt interactively.
+				// Inputs.TokenLifetime already has "86400" from flag default; only prompt interactively.
 				if !cmd.Flags().Changed("token-lifetime") && canPrompt(cmd) {
 					defaultLifetime := "86400"
 					q := prompt.TextInput("token-lifetime", "Access token lifetime (seconds)", "How long access tokens remain valid (default: 86400 = 24 hours)", defaultLifetime, true)
@@ -951,7 +951,8 @@ func setupQuickstartCmdExperimental(cli *cli) *cobra.Command {
 							named = append(named, name)
 							appIDByName[name] = c.GetClientID()
 						}
-						appOptions = append(named, "Skip")
+						named = append(named, "Skip")
+						appOptions = named
 					}
 
 					var selectedAppName string