fix test

Author: lohnim

tests/commands/onboarding.test.ts

@@ -7,16 +7,16 @@ describe("onboarding flow", () => {
   });
 
   it("returns false when browser login fails", async () => {
+    vi.doMock("../../src/lib/terminal-ui.js", () => ({
+      promptText: vi.fn().mockResolvedValue(""),
+    }));
     vi.doMock("../../src/lib/auth.js", () => ({
       performBrowserLogin: vi.fn().mockRejectedValue(new Error("login failed")),
       AUTH_PORT: 16424,
       getLoginUrl: vi.fn().mockReturnValue("https://auth.alchemy.com/login"),
     }));
     vi.doMock("../../src/lib/update-check.js", () => ({
-      getUpdateNoticeLines: vi.fn().mockReturnValue([
-        "  Update available 0.2.0 -> 9.9.9",
-        "  Run npm i -g @alchemy/cli@latest to update",
-      ]),
+      getUpdateNoticeLines: vi.fn().mockReturnValue([]),
     }));
     vi.doMock("../../src/lib/config.js", () => ({
       load: vi.fn().mockReturnValue({}),
@@ -40,48 +40,26 @@ describe("onboarding flow", () => {
 
   it("returns true when browser login succeeds", async () => {
     const save = vi.fn();
+    vi.doMock("../../src/lib/terminal-ui.js", () => ({
+      promptText: vi.fn().mockResolvedValue(""),
+    }));
     vi.doMock("../../src/lib/auth.js", () => ({
       performBrowserLogin: vi.fn().mockResolvedValue({
         token: "test_token",
         expiresAt: "2099-01-01T00:00:00Z",
       }),
       AUTH_PORT: 16424,
       getLoginUrl: vi.fn().mockReturnValue("https://auth.alchemy.com/login"),
-    vi.doMock("../../src/lib/terminal-ui.js", () => ({
-      promptSelect: vi.fn().mockResolvedValue("api-key"),
-      promptText: vi.fn().mockResolvedValue("api_test"),
-    }));
-    vi.doMock("../../src/lib/update-check.js", () => ({
-      getUpdateNoticeLines: vi.fn().mockReturnValue([
-        "  Update available 0.2.0 -> 9.9.9",
-        "  Run npm i -g @alchemy/cli@latest to update",
-      ]),
-    }));
-    vi.doMock("../../src/lib/config.js", () => ({
-      load,
-      save,
-    }));
-    vi.doMock("../../src/lib/ui.js", () => ({
-      brand: (s: string) => s,
-      bold: (s: string) => s,
-      brandedHelp: () => "",
-      dim: (s: string) => s,
-      green: (s: string) => s,
-      maskIf: (s: string) => s,
-      printKeyValueBox: vi.fn(),
     }));
     vi.doMock("../../src/commands/auth.js", () => ({
       selectAppAfterAuth: vi.fn(),
     }));
     vi.doMock("../../src/lib/update-check.js", () => ({
-      getUpdateNoticeLines: vi.fn().mockReturnValue([
-        "  Update available 0.2.0 -> 9.9.9",
-        "  Run npm i -g @alchemy/cli@latest to update",
-      ]),
+      getUpdateNoticeLines: vi.fn().mockReturnValue([]),
     }));
     vi.doMock("../../src/lib/config.js", () => ({
       load: vi.fn().mockReturnValue({}),
-      save: vi.fn(),
+      save,
     }));
     vi.doMock("../../src/lib/ui.js", () => ({
       brand: (s: string) => s,
@@ -92,33 +70,23 @@ describe("onboarding flow", () => {
       maskIf: (s: string) => s,
       printKeyValueBox: vi.fn(),
     }));
-    vi.doMock("../../src/lib/admin-client.js", () => ({
-      AdminClient: vi.fn(),
-    }));
-    vi.doMock("../../src/commands/config.js", () => ({
-      selectOrCreateApp: vi.fn(),
-    }));
-    vi.doMock("../../src/commands/wallet.js", () => ({
-      generateAndPersistWallet: vi.fn(),
-      importAndPersistWallet: vi.fn(),
-    }));
 
+    vi.spyOn(console, "log").mockImplementation(() => {});
     const { runOnboarding } = await import("../../src/commands/onboarding.js");
     const completed = await runOnboarding({} as never);
-    expect(completed).toBe(false);
+    expect(completed).toBe(true);
+    expect(save).toHaveBeenCalledWith({
+      auth_token: "test_token",
+      auth_token_expires_at: "2099-01-01T00:00:00Z",
+    });
   });
 
-  it("prints next steps when selected path remains incomplete", async () => {
-    const logSpy = vi.spyOn(console, "log").mockImplementation(() => {});
+  it("returns false when user cancels the prompt", async () => {
     vi.doMock("../../src/lib/terminal-ui.js", () => ({
-      promptSelect: vi.fn().mockResolvedValue("api-key"),
-      promptText: vi.fn().mockResolvedValue(""),
+      promptText: vi.fn().mockResolvedValue(null),
     }));
     vi.doMock("../../src/lib/update-check.js", () => ({
-      getUpdateNoticeLines: vi.fn().mockReturnValue([
-        "  Update available 0.2.0 -> 9.9.9",
-        "  Run npm i -g @alchemy/cli@latest to update",
-      ]),
+      getUpdateNoticeLines: vi.fn().mockReturnValue([]),
     }));
     vi.doMock("../../src/lib/config.js", () => ({
       load: vi.fn().mockReturnValue({}),
@@ -137,15 +105,14 @@ describe("onboarding flow", () => {
     vi.spyOn(console, "log").mockImplementation(() => {});
     const { runOnboarding } = await import("../../src/commands/onboarding.js");
     const completed = await runOnboarding({} as never);
-    expect(completed).toBe(true);
-    expect(save).toHaveBeenCalledWith({
-      auth_token: "test_token",
-      auth_token_expires_at: "2099-01-01T00:00:00Z",
-    });
+    expect(completed).toBe(false);
   });
 
   it("prints the update notice on the onboarding screen when provided", async () => {
     const logSpy = vi.spyOn(console, "log").mockImplementation(() => {});
+    vi.doMock("../../src/lib/terminal-ui.js", () => ({
+      promptText: vi.fn().mockResolvedValue(""),
+    }));
     vi.doMock("../../src/lib/auth.js", () => ({
       performBrowserLogin: vi.fn().mockRejectedValue(new Error("login failed")),
       AUTH_PORT: 16424,