Skip to content

Commit 30311f2

Browse files
Alexander Shturmmeta-codesync[bot]
authored andcommitted
Inline trivial multi-line list args — util
Summary: Inline list arguments that were unnecessarily spread across 3 lines into a single line. Before: ``` func(arg1, arg2, [ content ]) ``` After (fits on one line): ``` func(arg1, arg2, [content]) ``` After (too long for one line — one argument per line): ``` func( arg1, arg2, [content] ) ``` A short list like `[Options]` or `[Reason, Code]` reads better inline than spanning 3 lines. Collapsing it reduces vertical noise and makes call signatures scannable at a glance. For longer calls, breaking to one-arg-per-line keeps each argument visually distinct instead of cramming everything before the list onto one line. Reviewed By: thepulkitagarwal Differential Revision: D97638719 fbshipit-source-id: 3368223c258c1ed83c7942c6d51a8b90b539bd08
1 parent 35be719 commit 30311f2

4 files changed

Lines changed: 4 additions & 12 deletions

File tree

src/wa_assert.erl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -94,9 +94,7 @@ format_generic_error(Reason0, [{_M, _F, _Args, Info} | _]) ->
9494
#{expression := Expression, pins := Pins} = Cause,
9595
Intermediates = maps:get(intermediates, Cause, []),
9696
Reason = io_lib:format(
97-
"~n~nThe following expression failed:~n~n~s~ts~n ~p", [
98-
Expression, format_where(Pins, Intermediates), Reason0
99-
]
97+
"~n~nThe following expression failed:~n~n~s~ts~n ~p", [Expression, format_where(Pins, Intermediates), Reason0]
10098
),
10199
#{general => "Assert", reason => Reason}.
102100

src/wa_assert_parse_trans.erl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,9 +226,7 @@ desugar_short_circuit(Expr, Line, StartN) ->
226226
end,
227227
CaseExpr = erl_syntax:case_expr(LhsResultVar, [
228228
erl_syntax:clause([EvalPat], none, RhsEvalBody),
229-
erl_syntax:clause([SkipVal], none, [
230-
erl_syntax:tuple([SkipVal, erl_syntax:list([])])
231-
])
229+
erl_syntax:clause([SkipVal], none, [erl_syntax:tuple([SkipVal, erl_syntax:list([])])])
232230
]),
233231
CaseBinding = erl_syntax:match_expr(
234232
erl_syntax:tuple([BoolResultVar, RhsEntriesVar]),

src/wa_blame.erl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -92,9 +92,7 @@ get_records(Module) ->
9292
File when is_list(File) ->
9393
case erl_prim_loader:get_file(File) of
9494
{ok, Beam, File} ->
95-
{ok, {_Mod, [{abstract_code, {_Version, Forms}}]}} = beam_lib:chunks(Beam, [
96-
abstract_code
97-
]),
95+
{ok, {_Mod, [{abstract_code, {_Version, Forms}}]}} = beam_lib:chunks(Beam, [abstract_code]),
9896
[Record || {attribute, _, record, _} = Record <- Forms];
9997
_ ->
10098
[]

src/wa_diff.erl

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -104,9 +104,7 @@ records(Module) ->
104104
File when is_list(File) ->
105105
case erl_prim_loader:get_file(File) of
106106
{ok, Beam, File} ->
107-
{ok, {_Mod, [{abstract_code, {_Version, Forms}}]}} = beam_lib:chunks(Beam, [
108-
abstract_code
109-
]),
107+
{ok, {_Mod, [{abstract_code, {_Version, Forms}}]}} = beam_lib:chunks(Beam, [abstract_code]),
110108
Defs = [D || {attribute, _, record, D} <- Forms],
111109
lists:foldl(fun parse_def/2, #{}, Defs);
112110
_ ->

0 commit comments

Comments
 (0)