allBaseMaps on MobileMenu

[irbian]

These days I had lots of problem compiling our fork via frontend-maven-plugin on windows, problems I can't explain, I´ll share some of the issues in case they help the project

For example, this property, that only appeared here https://github.com/TerriaJS/terriajs/blob/main/lib/ReactViews/Mobile/MobileMenu.jsx#L28 broke the compilation. We simply remove it. Is used for something I can't see? Why your CI don't break with this?

[zoran995]

From what I can see, allBaseMaps has not been used for quite some time, but I'm unsure why it would cause compilation errors, as it only sets the default prop value. What kind of error does it throw?

[irbian]

Funny thing; I restore the error now to show you and no longer fails. In the meantime I had to fix my yarn.lock, it was wrongly merged

Thanks for checking, I´ll let you know if it repeats

[irbian]

I got it again, as a console error

Warning: Failed prop type: The prop `allBaseMaps` is marked as required in `MobileMenu`, but its value is `undefined`.
    at MobileMenu (webpack-internal:///./node_modules/terriajs/lib/ReactViews/Mobile/MobileMenu.jsx:133:5)
    at I18nextWithTranslation (webpack-internal:///./node_modules/react-i18next/dist/es/withTranslation.js:28:31)
    at div
    at MobileHeader (webpack-internal:///./node_modules/terriajs/lib/ReactViews/Mobile/MobileHeader.jsx:118:5)
    at withViewState
    at eval (webpack-internal:///./node_modules/styled-components/dist/styled-components.browser.esm.js:30:25928)
    at I18nextWithTranslation (webpack-internal:///./node_modules/react-i18next/dist/es/withTranslation.js:28:31)
    at MediaQuery (webpack-internal:///./node_modules/react-responsive/dist/esm/index.js:210:23)
    at Small (webpack-internal:///./node_modules/terriajs/lib/ReactViews/Generic/Responsive.tsx:35:21)
    at div
    at div
    at P (webpack-internal:///./node_modules/styled-components/dist/styled-components.browser.esm.js:30:19658)
    at div
    at P (webpack-internal:///./node_modules/styled-components/dist/styled-components.browser.esm.js:30:19658)
    at div
    at Le (webpack-internal:///./node_modules/styled-components/dist/styled-components.browser.esm.js:30:17336)
    at ViewStateProvider (webpack-internal:///./node_modules/terriajs/lib/ReactViews/Context/ViewStateContext.tsx:77:24)
    at ContextProviders (webpack-internal:///./node_modules/terriajs/lib/ReactViews/Context/ContextProviders.tsx:13:22)
    at eval (webpack-internal:///./node_modules/mobx-react-lite/es/observer.js:53:73)
    at Suspense
    at WithFallback
    at TerriaUserInterface (webpack-internal:///./lib/Views/UserInterface.jsx:22:21)
    at Suspense
    at eval (webpack-internal:///./node_modules/mobx-react-lite/es/observer.js:53:73)