Skip to content

Improve default negative conditions #14

@Azyrod

Description

@Azyrod

Checklist

  • I am requesting a new feature or a functional improvement.
  • I am not requesting an update or backport.
  • This feature does not exist on the latest version.
  • This feature has not already been requested.

Feature Description

I would like for the default configuration of the mod to contain more Condition Keys for the Negative type.
I can configure them manually, but I need to research what every condition is about, and I'm sure most players won't bother to change it, and will run into unintended behaviors.

I would also really like if the mod could detect when the user manually joins a server and not trigger reconnect attempts on that first connection attempt. If something goes wrong at that moment, the user is in front of the screen and doesn't need/want the auto-reconnect feature to get in the way of them fixing the issue. (you can easily reproduce this by attempting to connect to a server with an ip like : not.a.real.ip)

Use Case

The mod already comes with a way to disable reconnecting on specific error keys, but by default its only the multiplayer.disconnect.banned. However there is a lot more reasons where you don't want to reconect by default.

For instance :

  • disconnect.unknownHost -> this happens if you mistype the hostname of a server. It doesn't make sense to auto-retry it since it'd only happen on the first login attempt anyways (or on a DNS failure, but that probably wouldn't recover quickly)
  • multiplayer.disconnect.kicked -> Usually getting kicked while AFK means you are lagging the server. Auto-reconnecting on this means that the Operators of the server have no choice but to ban you to get you off the server
  • ...ip_banned -> For the same reason you already defaulted .banned
  • ...invalidSession -> You can't reset your session automatically, once its expired, its expired, you have to restart the game/launcher.
  • ... and probably a bunch more I didn't even think about

Here's a quick list I put together (not sure about the loginFailed ones tbh, I just assumed they are not retriable) :

Image

Minecraft Version (if not latest)

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions