Skip to content

Commit 05076f6

Browse files
authored
Merge pull request #16 from TappNetwork/fix-migration-filenames
Fix: Use migration stubs and avoid duplicate migrations on republish
2 parents b3d80b7 + ca1456b commit 05076f6

6 files changed

Lines changed: 11 additions & 11 deletions

database/migrations/2024_01_01_000003_create_library_item_favorites_table.php renamed to database/migrations/create_library_item_favorites_table.php.stub

File renamed without changes.

database/migrations/2024_01_01_000001_create_library_item_permissions_table.php renamed to database/migrations/create_library_item_permissions_table.php.stub

File renamed without changes.

database/migrations/2024_01_01_000002_create_library_item_tags_table.php renamed to database/migrations/create_library_item_tags_table.php.stub

File renamed without changes.

database/migrations/2024_01_01_000000_create_library_items_table.php renamed to database/migrations/create_library_items_table.php.stub

File renamed without changes.

src/FilamentLibraryServiceProvider.php

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -170,10 +170,10 @@ protected function getScriptData(): array
170170
protected function getMigrations(): array
171171
{
172172
return [
173-
'2024_01_01_000000_create_library_items_table',
174-
'2024_01_01_000001_create_library_item_permissions_table',
175-
'2024_01_01_000002_create_library_item_tags_table',
176-
'2024_01_01_000003_create_library_item_favorites_table',
173+
'create_library_items_table',
174+
'create_library_item_permissions_table',
175+
'create_library_item_tags_table',
176+
'create_library_item_favorites_table',
177177
];
178178
}
179179
}

tests/TestCase.php

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,13 @@ protected function setUp(): void
3636
Factory::guessFactoryNamesUsing(
3737
fn (string $modelName) => 'Tapp\\FilamentLibrary\\Database\\Factories\\' . class_basename($modelName) . 'Factory'
3838
);
39+
40+
// Publish and run package migrations (stubs get timestamped when published)
41+
$this->artisan('vendor:publish', [
42+
'--tag' => 'filament-library-migrations',
43+
'--force' => true,
44+
]);
45+
$this->artisan('migrate');
3946
}
4047

4148
protected function getPackageProviders($app)
@@ -69,12 +76,5 @@ public function getEnvironmentSetUp($app)
6976
$table->string('email')->unique();
7077
$table->timestamps();
7178
});
72-
73-
// Run the library migrations
74-
$migration = include __DIR__ . '/../database/migrations/2024_01_01_000000_create_library_items_table.php';
75-
$migration->up();
76-
77-
$migration = include __DIR__ . '/../database/migrations/2024_01_01_000001_create_library_item_permissions_table.php';
78-
$migration->up();
7979
}
8080
}

0 commit comments

Comments
 (0)