InvMenu inventory may be opened twice

[DaisukeDaisuke]

I don't know why this happens, but my InvMenu sometimes opens twice
It might even be an injection error

This can be annoying for users as it distracts them

• I take great care to avoid source code conflicts

m14.mp4

<?php

declare(strict_types=1);

namespace core\job;

use muqsit\invmenu\InvMenu;
use muqsit\invmenu\transaction\InvMenuTransaction;
use muqsit\invmenu\transaction\InvMenuTransactionResult;
use pocketmine\block\VanillaBlocks;
use pocketmine\player\Player;

class JobSelectorWizard{
	/**
	 * @param \Closure(Job): void $onComplete
	 */
	public static function mainWizard(Player $player, \Closure $onComplete) : void{
		$jobs = JobRegistry::getAll();
		$menu = InvMenu::create(InvMenu::TYPE_DOUBLE_CHEST);
		$inventory = $menu->getInventory();

		for($i = 0; $i < $inventory->getSize(); $i++){
			$inventory->setItem($i, VanillaBlocks::IRON_BARS()->asItem()->setCount(1));
		}

		foreach($jobs as $key => $job){
			$inventory->setItem($key, $job->getDisplayItem($player));
		}

		//EnchantmentIdMap::
		$menu->setListener(function(InvMenuTransaction $transaction) use ($onComplete) : InvMenuTransactionResult{
			$player = $transaction->getPlayer();
			$itemClicked = $transaction->getItemClicked();
			$itemClickedWith = $transaction->getItemClickedWith();
			$action = $transaction->getAction();
			$invTransaction = $transaction->getTransaction();
			$source = $transaction->getAction()->getSourceItem(); //hopper
			$target = $transaction->getAction()->getTargetItem(); //player inventory
			$slot = $action->getSlot();
			$jobs = JobRegistry::getAll();

			$job = $jobs[$slot] ?? null;
			if($job !== null){
				$player->removeCurrentWindow();
				($onComplete)($job);
				unset($onComplete);
			}

			return $transaction->discard();
		});
		$menu->send($player);
	}
}

Thank you for reading

[Muqsit]

I could be wrong, but this probably arises from a slight change in how InvMenu::send() queues requests from v4.7 onwards.

When you add var_dump(__METHOD__); to the method, does it print more than once?

[DaisukeDaisuke]

Thanks for your quick reply!
Yes, your guess was correct!
Submitting the menu multiple times causes a bug!

It's a pain to check $player->getCurrentWindow() every time, so I'd like to find a workaround. Any ideas?
Note: This is more likely to happen on 120hz displays

[00:09:15.905] [Server thread/INFO]: <> a
string(38) "core\job\JobSelectorWizard::mainWizard"
string(38) "core\job\JobSelectorWizard::mainWizard"
string(38) "core\job\JobSelectorWizard::mainWizard"

$window = $player->getCurrentWindow();
var_dump($window === null ? null: $window::class);

string(38) "core\job\JobSelectorWizard::mainWizard"
NULL
string(38) "core\job\JobSelectorWizard::mainWizard"
NULL
string(38) "core\job\JobSelectorWizard::mainWizard"
string(41) "muqsit\invmenu\inventory\InvMenuInventory"
string(38) "core\job\JobSelectorWizard::mainWizard"
NULL
string(38) "core\job\JobSelectorWizard::mainWizard"

As a response from our side, I think we can deal with this by implementing a cooldown

		if(!CooldownManager::get($player->getName())->onuse("Recovery Compass", 1)){
			return;
		}