Skip to content

Commit 5846f99

Browse files
committed
fix(ffe): enable No_Config_Loaded test for Go
1 parent 04f2264 commit 5846f99

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

tests/ffe/test_flag_eval_metrics.py

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -542,12 +542,12 @@ def test_ffe_eval_reason_disabled(self):
542542
# Error Code | Test
543543
# -----------------------|---------------------------------------------
544544
# FLAG_NOT_FOUND | Test_FFE_Eval_Config_Exists_Flag_Missing
545-
# TYPE_MISMATCH | Test_FFE_Eval_Metric_Type_Mismatch
546-
# PARSE_ERROR | Test_FFE_Eval_Metric_Parse_Error
545+
# TYPE_MISMATCH | Test_FFE_Eval_Metric_Type_Mismatch, Test_FFE_Eval_Metric_Numeric_To_Integer
546+
# PARSE_ERROR | (not tested - no cross-SDK consistent scenario)
547547
# GENERAL | (not tested - catch-all error code)
548548
# TARGETING_KEY_MISSING | Test_FFE_Eval_Targeting_Key_Optional (verifies it's NOT returned; JS excluded)
549549
# INVALID_CONTEXT | Test_FFE_Eval_Invalid_Context_Nested_Attribute (Python only)
550-
# PROVIDER_NOT_READY | Test_FFE_Eval_No_Config_Loaded (TODO: Go returns GENERAL)
550+
# PROVIDER_NOT_READY | Test_FFE_Eval_No_Config_Loaded
551551
# PROVIDER_FATAL | (not tested - requires fatal provider error)
552552
#
553553
# INVALID_CONTEXT behavioral differences:
@@ -714,19 +714,12 @@ def test_ffe_eval_metric_numeric_to_integer(self):
714714

715715
@scenarios.feature_flagging_and_experimentation
716716
@features.feature_flags_eval_metrics
717-
@irrelevant(
718-
context.library == "golang", reason="TODO: Go returns GENERAL instead of PROVIDER_NOT_READY for no config loaded"
719-
)
720717
class Test_FFE_Eval_No_Config_Loaded:
721718
"""Test that evaluating a flag when no configuration is loaded produces error metrics.
722719
723-
This is a cross-tracer consistency test. When no FFE configuration has been loaded,
724-
tracers should return:
720+
When no FFE configuration has been loaded, tracers should return:
725721
- feature_flag.result.reason = "error"
726722
- error.type = "provider_not_ready"
727-
728-
This aligns with Ruby, Java, .NET, JS, and Python which all return PROVIDER_NOT_READY.
729-
Go currently returns GENERAL (TODO: fix to align with other SDKs).
730723
"""
731724

732725
def setup_ffe_eval_no_config_loaded(self):

0 commit comments

Comments
 (0)