Fix: Include FIPS-updates repo in security source list#348
Conversation
There was a problem hiding this comment.
Pull request overview
This pull request updates the APT custom-sources filtering logic so that Ubuntu Pro FIPS “fips-updates” repositories are retained when generating a “Security”-only sources list, preventing security patch operations from inadvertently pulling non-FIPS packages from the standard *-security repos.
Changes:
- Broadened the security-only filtering for one-line (
*.list) sources to also include lines containingfips-updates. - Broadened the security-only filtering for DEB822/“deb882” (
*.sources) stanzas to also include stanzas containingfips-updates. - Updated unit tests and mock source data to cover the added FIPS-updates inclusion and its interaction with max-publish-date snapshot rewriting.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/core/src/package_managers/AptitudePackageManager.py | Extends “Security” source filtering to retain fips-updates entries for both one-line and DEB822-style parsing. |
| src/core/tests/Test_AptitudePackageManagerCustomSources.py | Updates test expectations and mock source inputs to validate inclusion of fips-updates in generated security source lists/stanzas. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 105 105
Lines 18218 18218
=======================================
Hits 17096 17096
Misses 1122 1122
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Refer to the old PR : #338 for more Information.
Created PR because the original PR was lacking essentials checks : Suspicion is that since it was created from fork it didn't run essential checks marking it as unable to merge.
Proof Test:
Failing
Created PR from my fork : #349
Success

For successful PR : https://github.com/Azure/LinuxPatchExtension/actions/runs/26258749218/job/77287296261?pr=348
Plausible reason: It is failing to get the Codecov secret Token when run from fork : CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}