Skip to content

Fix: Include FIPS-updates repo in security source list#348

Open
yashnap wants to merge 1 commit into
masterfrom
fips_updates_security_filter
Open

Fix: Include FIPS-updates repo in security source list#348
yashnap wants to merge 1 commit into
masterfrom
fips_updates_security_filter

Conversation

@yashnap
Copy link
Copy Markdown
Contributor

@yashnap yashnap commented May 21, 2026

Refer to the old PR : #338 for more Information.
Created PR because the original PR was lacking essentials checks : Suspicion is that since it was created from fork it didn't run essential checks marking it as unable to merge.

Proof Test:

Failing
Created PR from my fork : #349

notoken

Success
For successful PR : https://github.com/Azure/LinuxPatchExtension/actions/runs/26258749218/job/77287296261?pr=348
tokenfound

Plausible reason: It is failing to get the Codecov secret Token when run from fork : CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

Copilot AI review requested due to automatic review settings May 21, 2026 23:17
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request updates the APT custom-sources filtering logic so that Ubuntu Pro FIPS “fips-updates” repositories are retained when generating a “Security”-only sources list, preventing security patch operations from inadvertently pulling non-FIPS packages from the standard *-security repos.

Changes:

  • Broadened the security-only filtering for one-line (*.list) sources to also include lines containing fips-updates.
  • Broadened the security-only filtering for DEB822/“deb882” (*.sources) stanzas to also include stanzas containing fips-updates.
  • Updated unit tests and mock source data to cover the added FIPS-updates inclusion and its interaction with max-publish-date snapshot rewriting.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/core/src/package_managers/AptitudePackageManager.py Extends “Security” source filtering to retain fips-updates entries for both one-line and DEB822-style parsing.
src/core/tests/Test_AptitudePackageManagerCustomSources.py Updates test expectations and mock source inputs to validate inclusion of fips-updates in generated security source lists/stanzas.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 21, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.84%. Comparing base (6f0af88) to head (bffe7ec).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #348   +/-   ##
=======================================
  Coverage   93.84%   93.84%           
=======================================
  Files         105      105           
  Lines       18218    18218           
=======================================
  Hits        17096    17096           
  Misses       1122     1122           
Flag Coverage Δ
python27 93.84% <100.00%> (ø)
python312 93.79% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@kjohn-msft kjohn-msft added feature New feature or request OE PR is considered near complete due to OE sign-off. labels May 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature or request OE PR is considered near complete due to OE sign-off.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants